cocos2d for iPhone

A fast, easy to use, free, and community supported 2D game engine

1. 

   ecosoft
   Member

   Hello,

   I have a scene with a vector of layers.
   Each layer contains some sprites, a string and a vector of color layers.

   So, I've implemented 3 'dealloc' methods:
   1. For the color layer - that calls only '[super dealloc]'.
   2. For the layer - that releases the layer's members and pops the color layers (after they've released) from the vector.
   3. For the scene - that pops and releases the layers from the vector, and also '[super dealloc]'.

   All the above works fine.

   The problem starts when I add '[super dealloc]' to the layer's dealloc method - looks like the layer's trying to be dealloced twice and the application crashes with 'exc_bad_instruction'.

   Is this the right way to dealloc, should I keep using those 3 dealloc methods?
   And if it is - how/where should I call the '[super dealloc]' in the layer's dealloc method without making it crash?

   Thanks,
   Keren

   Posted 2 years ago #
2. 

   pabloruiz55
   Member

   Hi!
   If i am not mistaken in the layers' dealloc method you should only call [super dealloc]
   and then [objects release] to any object you have previously retained/allocated.

   Posted 2 years ago #
3. 

   ecosoft
   Member

   Hi,
   Thanks for the fast answer :)

   I've tried also to call [super dealloc] and then to release anything else, but it crashed too (with the same error).

   Is there any documentation about it, maybe?
   (I've read the "Memory Management Programming Guide for Cocoa" in Apple developer center, but it doesn't seem to help (I guess I need some Cocos2D iPhone specific document)

   Posted 2 years ago #
4. 

   PhilM
   Member

   Perhaps your trying to release something you haven't specifically retained?

   Try commenting out all your custom dealloc code apart from [super dealloc];.
   If that runs fine, start uncommenting lines and seeing whats causing the crash.

   Posted 2 years ago #
5. 

   ecosoft
   Member

   I've tried that too, thanks.
   It crashes even if I comment anything expect of the [super dealloc].

   Posted 2 years ago #
6. 

   pabloruiz55
   Member

   Try leaving only [super dealloc];

   check if it crashes and check if there is any leak, if there is any, check what is leaking and add the [object release] line.

   Generally this is what i do... All the times my app crashed by releasing something it was because i had already released before or i wasn't even retaining it...

   in the debugger console write "bt" to get a backtrace and check what is the last thing the app called to get a little more info on what made it crash, maybe it helps.

   Posted 2 years ago #
7. 

   Codemattic
   Moderator

   "vector of color layers" C++ STL Vector? Or NSMutableArray?

   Post some code and I bet we'll spot the problem.

   Posted 2 years ago #
8. 

   PhilM
   Member

   hmmm, then it sounds like a problem with code before your dealloc.

   You might have to go pretty militant, and comment out the bulk of your class methods, and just get them to init and dealloc without any content first.

   Are you manually releasing something earlier on in your classes? pabloruiz55's suggestions should hopefully help track it down if thats the case.

   Posted 2 years ago #
9. 

   ecosoft
   Member

   I've left only [super dealloc], and it crashed too.
   I'm not releasing anything earlier, but I'd try to comment anything expect of the init and dealloc, it might help, thanks.

   Here are my interfaces, each following by its dealloc method:

   @interface MyColorLayer: ColorLayer
   {
   }

   -(void)dealloc
   {
   [super dealloc];
   }

   @interface MyLayer : Layer
   {
   std::vector<MyColorLayer*> myColorLayerVector;
   Sprite* background;
   NSString* title;
   }

   -(void)dealloc
   {
   int colorLayerSize = myColorLayerVector.size();
   for (; colorLayerSize-- > 0;)
   {
   MyColorLayer* aColorLayer = myColorLayerVector.back();

   // the color layer's dealloc is being called after the removeChild
   // so I don't release it again (I get a crash if I try to...)
   [self removeChild:aColorLayer cleanup:YES];

   myColorLayerVector.pop_back();
   }

   [title release];
   [background release];

   // If I add the [super dealloc] I get a crash...
   // [super dealloc];
   }

   @interface MyScene : Scene
   {
   std::vector<MyLayer*> myLayerVector;
   }

   -(void)dealloc
   {
   MyLayer *aChildLayer = *(myLayerVector.begin() + currLayerNum - 1);
   [self removeChild:aChildLayer cleanup:YES];

   for (int i = 0; i < NUM_OF_LAYERS; i++)
   {
   MyLayer* aLayer = myLayerVector.back();
   myLayerVector.pop_back();
   [aLayer release];
   aLayer = nil;
   }

   [super dealloc];
   }

   Thanks again

   Posted 2 years ago #
10. 

    Clain
    Member

    You don't need to call [self removeChild:...] in the dealloc method. This is done automatically by the superclass when you call [super dealloc].

    Posted 2 years ago #
11. 

    Codemattic
    Moderator

    I havent looked at the code closely, but I would suggest using NSMutableArray instead of a vector. Remember, when you add an object to an NSMutableArray it retains it, when you remove an object it releases it. If you are going to use a vector you should do the retain and release yourself.

    Ill look at the code closer later, but consider switching to an NSMutableArray.

    Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.