A fast, easy to use, free, and community supported 2D game engine
EasyDev
Member
Hi…
All my question is in the title. I would want how to detect running actions on a CCSprite to do some conditions with that stuff. Is it possible ? I tried this :
if (CGRectIntersectsRect([perso boundingBox], [chaussure boundingBox]) && (![chaussure isRunning])) {}
But I wanted to know if it was possible to detect if the CCSprite (chaussure) was running a specific action.
Thanks in advance,
Best regards
chrisco
Member
If you keep a reference to the action you want to check on, you could call:
BOOL isActionDone = [anAction isDone];If you don't want to keep a reference, tag your action when you create it:
CCAction *action = [CCAction action];
action.tag = kActionTag; // a constant, could use any intThen later on, you could check the node for running actions:
if ([node numberOfRunningActions] > 0) {
CCAction *action = [node getActionByTag:kActionTag];
if (nil != action) {
BOOL isActionDone = [action isDone];
}
}However, I'm not sure that will tell you if the action was actually running at the time, only if it's done. Just because it's not done doesn't mean it's actually running as it may be waiting in the queue (for example, if it's placed in a CCSequence after a CCDelayTime).
EasyDev
Member
Thanks a lot for this very helpful post !
So, I just created my actions before the implementation of my class, as that :
id actionFadingRougeLevres;
id actionScalingRougeLevres;
id bothActionsRougeLevres;
id actionMoveDoneRougeLevres;And in the init method, I init them :
actionFadingRougeLevres = [CCFadeOut actionWithDuration:durationFading];
actionScalingRougeLevres = [CCScaleBy actionWithDuration:durationScaling scale:scalingMod];
bothActionsRougeLevres = [CCSpawn actions:actionFadingRougeLevres, actionScalingRougeLevres, nil];
actionMoveDoneRougeLevres = [CCCallFuncN actionWithTarget:self selector:@selector(spriteMoveFinished:)];But when I launch my code without modifying everything else, my app crashes on the GamePlay view. I'm a bit confused. Did I do something wrong ?
Thanks in advance for your help, chrisco !
What error do you get? Also if you want to call an action later in the program i believe you have to retain them, ex.
actionFadingRougeLevres = [[CCFadeOut actionWithDuration:durationFading] retain];
Then just
[object runAction: actionFadingRougeLevres];
Then remember to release them in the dealloc
chrisco
Member
EasyDev
Member
Thanks a lot for your help, but I tried with this method and it's very complicated to put that all stuff in work. So, is it possible to tell to a CCSprite to run nothing else action when this CCSprite is running a specific action ?
EDIT : Everytime I ask this question there is no answers.
EasyDev
Member
You understood perfectly my problem, but I can't do this because (I don't know why ?) the code above doesn't work. Could you guide me ?
To help you guiding me, I'll tell you more about my game. I have a tick method who is always verifying for a collision between objects and the character or collisions between objects and enemies. When the collision happens between the character and the object, the object run an action. The problem is that if my character touches first the object, then the enemy can still touch the object and the object will run the same action as when he intersects with the character. So the action will be runned while it's already running. I want my object to do not run the action if it's already running. Could you help me to prevent that ?
Thanks a lot for your help :)
EasyDev
Member
Okey, I tried what you told me. Here is it :
if (canLaunchTheAnimation) {
if (CGRectIntersectsRect([perso boundingBox], [parfum boundingBox])) {
score = score+40;
// Unlock le succès SMELLS GOOD
[OFAchievementService unlockAchievement:SMELLS_GOOD__];
// Lance le fondu
[parfum runAction:[CCSequence actions:actionPeutPasLancer,bothActions, actionMoveDone,actionPeutLancer, nil]];
}
}The problem is that the CGRectIntersect is called each time the character touches the object. And so first the BOOL canLaunchTheAnimation is equal to YES. Then, the character touches the object and the BOOL becomes NO. Then if the character stays on the object it will relaucnh the action of CGRectIntersect, and it will not be able to finish the animation and even less able to put canLaunchTheAnimation to YES because canLaunchTheAnimation will be equal to NO and so the runAction method will not be called because of the condition
if (canLaunchTheAnimation) {
. I hope you understood this ?
So I know where do my problem come from, it's because of the CGRectIntersect method. Is it possible to tell to my CGRectIntersect method to be executed just one time, just at the first contact between the character and the object (in this case, parfum) ? Thanks in advance for your help !
Hi EasyDev
I think you can do something like that:
1- Initialize your flag with NO value when needed
canLaunchTheAnimation = YES;2- Reset your flag when user interacts with your app
if (canLaunchTheAnimation) {
if (CGRectIntersectsRect([perso boundingBox], [parfum boundingBox])) {
// reset the flag so the user can't launch the animation anymore
canLaunchTheAnimation = NO;
// do what you like now
score = score+40;
// Unlock le succès SMELLS GOOD
[OFAchievementService unlockAchievement:SMELLS_GOOD__];
// Lance le fondu
[parfum runAction:[CCSequence actions:actionPeutPasLancer,bothActions, actionMoveDone,actionPeutLancer, nil]];
}
}
EasyDev
Member
Thanks a lot leock, but it malherously doesn't work… I don't know why, it should work perfectly, but it doesn't ! With this code I can't never collide with any object… And the ennemy can't either… Perhaps it comes from my method ? I saw with some NSLogs that the canLaunchAnimation BOOL was at the first on YES, but after, it becomes NO, and it stay NO.
Here is the code :
// PARFUM PERSO
if (peutCollideAnim) {
if (CGRectIntersectsRect([perso boundingBox], [parfum boundingBox])) {
// reset the flag so the user can't launch the animation anymore
peutCollideAnim = NO;
// Incrémente le score
score = score+40;
// Unlock le succès SMELLS GOOD
[OFAchievementService unlockAchievement:SMELLS_GOOD__];
// Lance le fondu
[parfum runAction:[CCSequence actions:bothActions, actionMoveDone,actionPeutLancer, nil]];
}
}Here is the actionPeutLancer declaration :
actionPeutLancer = [[CCCallFunc actionWithTarget:self selector:@selector(autorisationLancerAnim:)] retain];
And here the method called by actionPeutLancer :
-(void)autorisationLancerAnim:(id)sender {
peutCollideAnim = YES;
NSLog(@"peutcollideanim = YES");
}I think I know what's wrong, please test this: where you call the actionPeutLancer to run, replace the code for simply
peutCollideAnim = YES;I think your action is running only one time, to run actions twice you need to 'reset' them.
But you don't need necessarily an action to simply call a function, you can call it directly.
Where are you starting the running action? (It's something like [self runAction:actionPeutLancer] )
I was trying to say that you don't need an action to simply call a function. You could call autorisationLancerAnim instead, or even set the peutCollideAnim flag to YES value directly.
EasyDev
Member
Thanks for this information, very helpful ! So I tried this :
if (peutCollideAnim==YES) {
if (CGRectIntersectsRect([soucoupe boundingBox], [sac boundingBox])) {
NSLog(@"sac/soucoupe");
// reset the flag so the user can't launch the animation anymore
peutCollideAnim = NO;
// Lance le fondu
[sac runAction:[CCSequence actions:bothActions, actionMoveDone, peutCollideAnim=YES, nil]];
}
}But malherously when I launch the app, it crashes without telling me why. I'm a bit confused now.
So I think you could post your full class source code for us to see.
Please use pastebin.com, I've started a code in http://pastebin.com/bkjQgN6Z for you to post.
Regards
Hi EasyDev,
Looking at your code I saw you was misunderstanding what I've trying to ask you.
I've changed your code a little bit, but since I don't have the entire project could you please test it and tell me what exactly happens?
http://pastebin.com/34e2FKSF
(Don't forget to put the link so I can find your code - the updates create a new link)
I was looking at your dealloc function... First you change your references to NULL and after that you release them, shouln't be the other way around? Is this working for you?
EasyDev
Member
Hi, thanks a lot, the code works now, but the bool value still stays to NO with the NSLogs. When the "soucoupe" sprite collide with an object, the bool value becomes no and it stays no during all the time. I don't really understand why… Looks like the bool value don't become YES after because the action who's supposed to put the bool on YES isn't called correctly, but I don't know why.
Good, now try this code: http://pastebin.com/Jb9GXx7v
I've changed this to not reuse the actions and build new ones instead, as reuse them is not so interesting. You could schedule a method if you like to repeat the same code many times (like change your control flag).
Please read these threads:
http://www.cocos2d-iphone.org/forum/topic/3192#post-19745
http://www.cocos2d-iphone.org/forum/topic/2701#post-16778
I think your code will work now, but if not please tell me.
It's really difficult to "run" the code on my head, but I found a little strange thing, maybe it's your solution:
You start your Sequence this way:
[parfum runAction:[CCSequence actions:bothActions, actionMoveDone, actionPeutLancer, nil]];Looking at this code you can see that actionMoveDone is being called before actionPeutLancer. But in fact, isn't actionMoveDone releasing and cleaning your sprite?
Try to change all your actions to this:
[parfum runAction:[CCSequence actions:bothActions, actionPeutLancer , actionMoveDone, nil]];
EasyDev
Member
You're right ! So I tried, and it doesn't change… The problem is that the CGRectIntersect is called each time the character touches the object. And so first the BOOL canLaunchTheAnimation is equal to YES. Then, the character touches the object and the BOOL becomes NO. Then if the character stays on the object it will relaucnh the action of CGRectIntersect, and it will not be able to finish the animation and even less able to put canLaunchTheAnimation to YES because canLaunchTheAnimation will be equal to NO and so the runAction method will not be called because of the condition.
Sorry EasyDev, but I can't get it...
- The character touches the object at first time, the CGRectIntersect will be YES and peutCollideAnim will be YES. At this moment the sequence of actions will be started and the flag will be changed to NO.
- The character stays on the object, CGRectIntersect will be YES but peutCollideAnim will be NO, so... the action will still be running at this time
- The sequence calls actionPeutLancer, who changes your flag to YES again. After that it must calls actionMoveDone, who removes your sprite.
- The flag should be YES at this moment, if not may be something else on your project...
I don't see the canLaunchTheAnimation on the code. Are you sure we are using the same code?
Even without the complete project, I was searching another piece of code who changes the flag or stops the animation, but no success... It's very strange 'cos it should work!
You must log in to post.