A fast, easy to use, free, and community supported 2D game engine
Ok so I was having issues again with the scene not being releases when I pop from director. I found and located it down to the timer I created on init that was not releasing it. First of all Im curious as to why a timer retains it so I dug and found this bit of code on line 59 in scheduler.m. What does this mean and should it be there? It says target should not be retained yet it is...
// XXX: target should not be retained. But cocosnodeTest#stress test shall not crash
target = [t retain];in v0.7.x there was a problem with circular references.
most of the circular references were removed, basically, because CocosNode doesn't not retain the actions/schedulers.
Instead ActionManager / Scheduler retains the actions/schedulers which is correct.
The comment in line 59 is previous to the ActionManager.
Now, there are no more circular references. If there are circular references, then it's a bug.
If your timer is not being released when you pop the scene, then it's a bug. I did some tests in v0.8, and timers/actions/etc. are being released on pop (whether it's the 1st scene or not). Please, see SceneTest.m.
In can case you can reproduce the issue with v0.8-rc2, please, open a bug.
I was able to fix the bug by unscheduling the timer so Im not sure if it is a bug or not. I dont think target ever gets releases if target is self. This is because it is released inside the dealloc method but if self can never be deallocated because it never reaches 0 for the release counter it never runs the dealloc method and so target never releases itself. Sounds circular to me... Does that make sense?
see the tests/TransitionTest.m / tests/SceneTest.m in v0.8
the timers are being dealloced.
perhaps your scene/node is being retained by someone else.
if you have a test case that shows that the timers are not being dealloced, please open an issue with the test case.
thanks.
Ok well I do not have a test case. I did look at the allocations though and found a release matching all retains except the targets retain. Where do i post bugs at anyhow?
cjl
Member
valleyman86:
Bugs can be posted to the issue tracker on the Google Code site:
http://code.google.com/p/cocos2d-iphone/issues/list
-cjl
cacaty
Member
I have the test case reproduct the error, and I post the code here:
#import "mySceneTest.h"
@implementation Scene1
-(id) init
{
// NSLog(@"Scene1 init ");
if (!(self=[super init] )) return nil;
MultiplexLayer *layers=[MultiplexLayer layerWithLayers: [Layer1 node], [Layer2 node], nil];
[self addChild: layers z: 1];
return self;
}
-(void) dealloc
{
NSLog(@"Scene1 dealloc");
[super dealloc];
}
@end
@implementation Layer1
-(id) init
{
if (!(self=[super init] )) return nil;
MenuItemFont *item1 = [MenuItemFont itemFromString: @"replaceScene" target:self selector:@selector(onReplaceScene:)];
MenuItemFont *item2 = [MenuItemFont itemFromString: @"switch to layer2" target:self selector:@selector(layerSwitch:)];
item2.tag = 1;
Menu *menu = [Menu menuWithItems: item1, item2, nil];
[menu alignItemsVertically];
[self addChild: menu];
[self schedule:@selector(testDealloc:)]; //this cause the bug
return self;
}
-(void) testDealloc:(ccTime) dt
{
// [self unschedule:_cmd];
}
-(void) layerSwitch: (id) sender
{
[(MultiplexLayer *)parent switchTo: [sender tag]];
}
-(void) onReplaceScene:(id) sender
{
[[Director sharedDirector] replaceScene: [Scene1 node] ];
}
-(void) dealloc
{
NSLog(@"layer1 dealloc");
[super dealloc];
}
@end
@implementation Layer2
-(id) init
{
if (!(self=[super init] )) return nil;
MenuItemFont *item1 = [MenuItemFont itemFromString: @"replaceScene" target:self selector:@selector(onReplaceScene:)];
MenuItemFont *item2 = [MenuItemFont itemFromString: @"switch to layer1" target:self selector:@selector(layerSwitch:)];
item2.tag = 0;
Menu *menu = [Menu menuWithItems: item1, item2, nil];
[menu alignItemsVertically];
[self addChild: menu];
return self;
}
-(void) layerSwitch: (id) sender
{
[(MultiplexLayer *)parent switchTo: [sender tag]];
}
-(void) onReplaceScene:(id) sender
{
[[Director sharedDirector] replaceScene: [Scene1 node] ];
}
-(void) dealloc
{
NSLog(@"layer2 dealloc");
[super dealloc];
}
@end
// CLASS IMPLEMENTATIONS
@implementation AppController
- (void) applicationDidFinishLaunching:(UIApplication*)application
{
// Init the window
window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];
[window setUserInteractionEnabled:YES];
[window setMultipleTouchEnabled:NO];
// must be called before any othe call to the director
// [Director useFastDirector];
// before creating any layer, set the landscape mode
[[Director sharedDirector] setDeviceOrientation: CCDeviceOrientationLandscapeRight];
// attach the OpenGL view to a window
[[Director sharedDirector] attachInView:window];
// show FPS
[[Director sharedDirector] setDisplayFPS:YES];
// frames per second
[[Director sharedDirector] setAnimationInterval:1.0/60];
// Default texture format for PNG/BMP/TIFF/JPEG/GIF images
// It can be RGBA8888, RGBA4444, RGB5_A1, RGB565
// You can change anytime.
[Texture2D setDefaultAlphaPixelFormat:kTexture2DPixelFormat_RGBA8888];
Scene1 *scene = [Scene1 node];
[window makeKeyAndVisible];
[[Director sharedDirector] runWithScene: scene];
}
// getting a call, pause the game
-(void) applicationWillResignActive:(UIApplication *)application
{
[[Director sharedDirector] pause];
}
// call got rejected
-(void) applicationDidBecomeActive:(UIApplication *)application
{
[[Director sharedDirector] resume];
}
// purge memroy
- (void)applicationDidReceiveMemoryWarning:(UIApplication *)application {
[[TextureMgr sharedTextureMgr] removeAllTextures];
}
// next delta time will be zero
-(void) applicationSignificantTimeChange:(UIApplication *)application
{
[[Director sharedDirector] setNextDeltaTimeZero:YES];
}
- (void) dealloc
{
[window release];
[super dealloc];
}
@end
I think I should open an issue http://code.google.com/p/cocos2d-iphone/issues/detail?id=466
thanks, I'll look at it during the week.
You must log in to post.
