[CODE] AdViewController (iAds + AdMob)

cocos2d for iPhone » Programming » high score, social and ads networks

[CODE] AdViewController (iAds + AdMob)

(55 posts) (16 voices)

Started 1 year ago by jandrad
Latest reply from col55

Tags:

Hi! I wrote some code that I would like to share. It's a class that loads an iAd in landscape mode in iOS 4 or later and an AdMob ad in iOS < 4.0. It is pretty basic and there may be some things that could be improved (By the way I'm not sure if Apple allows this =P)

Here it is:

AdViewController.h

#import <UIKit/UIKit.h>
#import <iAd/iAd.h>
#import "AdMobDelegateProtocol.h"

@protocol AdViewControllerDelegate;

@interface AdViewController : UIViewController <ADBannerViewDelegate, AdMobDelegate>
{
	id <AdViewControllerDelegate> delegate;
	id adBannerView;

	AdMobView* adMobAd;
}

@property (nonatomic, assign) id <AdViewControllerDelegate> delegate;

- (id)initWithMasterView:(UIView*)masterView;
- (void)rotateBannerView:(UIDeviceOrientation)toDeviceOrientation;

@end

@protocol AdViewControllerDelegate

- (void)adController:(AdViewController*)controller didLoadiAd:(id)iadBanner;
- (void)adController:(AdViewController*)controller didFailedToRecieveiAd:(id)iadBanner;

- (void)adController:(AdViewController*)controller didLoadAdMobAd:(AdMobView*)adMobBanner;
- (void)adController:(AdViewController*)controller didFailedToRecieveAdMobAd:(AdMobView*)adMobBanner;

@end

AdViewController.m

#import "AdViewController.h"
#import "cocos2d.h"

#import "AdMobView.h"

@implementation AdViewController

@synthesize delegate;

- (UIDeviceOrientation)currentOrientation
{
	return [[CCDirector sharedDirector] deviceOrientation];
}

- (id) initWithMasterView:(UIView*) masterView
{
	if( nil != (self = [super init]) )
	{
		[self setView:masterView];

		//Initialize the class manually to make it compatible with iOS < 4.0
		Class classAdBannerView = NSClassFromString(@"ADBannerView");
		if (classAdBannerView != nil)
		{
			adBannerView = [[classAdBannerView alloc] initWithFrame:CGRectZero];
			[adBannerView setDelegate:self];
			[adBannerView setRequiredContentSizeIdentifiers: [NSSet setWithObjects:
															  ADBannerContentSizeIdentifier320x50,
															  ADBannerContentSizeIdentifier480x32, nil]];

			[self.view addSubview:adBannerView];

			[self rotateBannerView:[self currentOrientation]];

			[adBannerView setHidden:YES];

		}
		else
		{
			//Request an AdMob Ad
			adMobAd = [AdMobView requestAdOfSize:ADMOB_SIZE_320x48 withDelegate:self];
			[adMobAd retain];
		}
	}

	return self;
}

- (void)rotateBannerView:(UIDeviceOrientation)toDeviceOrientation
{
	if (adBannerView)
	{
		if (UIDeviceOrientationIsLandscape(toDeviceOrientation))
			[adBannerView setCurrentContentSizeIdentifier:ADBannerContentSizeIdentifier480x32];
		else
			[adBannerView setCurrentContentSizeIdentifier:ADBannerContentSizeIdentifier320x50];

		[(UIView*)adBannerView setTransform:CGAffineTransformIdentity];

		//Set the transformation for each orientation
		switch (toDeviceOrientation)
		{
			case UIDeviceOrientationPortrait:
			{
				[(UIView*)adBannerView setCenter:CGPointMake(160, 455)];
			}
				break;
			case UIDeviceOrientationPortraitUpsideDown:
			{
				[(UIView*)adBannerView setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(180))];
				[adBannerView setCenter:CGPointMake(160, 25)];
			}
				break;
			case UIDeviceOrientationLandscapeLeft:
			{
				[(UIView*)adBannerView setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(90))];
				[adBannerView setCenter:CGPointMake(16, 240)];
			}
				break;
			case UIDeviceOrientationLandscapeRight:
			{
				[(UIView*)adBannerView setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(-90))];
				[adBannerView setCenter:CGPointMake(304, 240)];
			}
				break;
			default:
				break;
		}
	}

	if (adMobAd)
	{
		[adMobAd setTransform:CGAffineTransformIdentity];

		//Set the transformation for each orientation
		switch (toDeviceOrientation)
		{
			case UIDeviceOrientationPortrait:
			{
				[adMobAd setCenter:CGPointMake(160, 456)];
			}
				break;
			case UIDeviceOrientationPortraitUpsideDown:
			{
				[adMobAd setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(180))];
				[adMobAd setCenter:CGPointMake(160, 24)];
			}
				break;
			case UIDeviceOrientationLandscapeLeft:
			{
				[adMobAd setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(90))];
				[adMobAd setCenter:CGPointMake(24, 240)];
			}
				break;
			case UIDeviceOrientationLandscapeRight:
			{
				[adMobAd setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(-90))];
				[adMobAd setCenter:CGPointMake(296, 240)];
			}
				break;
			default:
				break;
		}
	}
}

#pragma mark -
#pragma mark ADBannerViewDelegate

- (BOOL)allowActionToRun
{
	return YES;
}

- (void) stopActionsForAd
{
	//Pause background music here

	[adBannerView setHidden:YES];

	[[CCDirector sharedDirector] stopAnimation];
	[[CCDirector sharedDirector] pause];
}

- (void) startActionsForAd
{
	//Resume background music here

	[self rotateBannerView:[self currentOrientation]];
	[[UIApplication sharedApplication] setStatusBarOrientation:(UIInterfaceOrientation)[self currentOrientation]];
	[adBannerView setHidden:NO];

	[[CCDirector sharedDirector] stopAnimation];
	[[CCDirector sharedDirector] resume];
	[[CCDirector sharedDirector] startAnimation];
}

- (BOOL)bannerViewActionShouldBegin:(ADBannerView *)banner willLeaveApplication:(BOOL)willLeave
{
	BOOL shouldExecuteAction = [self allowActionToRun];
    if (!willLeave && shouldExecuteAction)
    {
		[self stopActionsForAd];
    }
    return shouldExecuteAction;
}

- (void)bannerViewDidLoadAd:(ADBannerView *)banner
{
	[adBannerView setHidden:NO];
	[delegate adController:self didLoadiAd:banner];
}

- (void)bannerView:(ADBannerView *)banner didFailToReceiveAdWithError:(NSError *)error
{
	[adBannerView setHidden:YES];
	[delegate adController:self didFailedToRecieveiAd:banner];
}

- (void)bannerViewActionDidFinish:(ADBannerView *)banner
{
	[self startActionsForAd];
}

#pragma mark -
#pragma mark AdMobDelegate methods

- (NSString *)publisherIdForAd:(AdMobView *)adView
{
	return @"your_admob_publisher_id";    //replace it with you publisher id
}

- (UIViewController *)currentViewControllerForAd:(AdMobView *)adView {
	return self;
}

- (UIColor *)adBackgroundColorForAd:(AdMobView *)adView
{
	return [UIColor colorWithRed:0 green:0 blue:0 alpha:1]; // this should be prefilled; if not, provide a UIColor
}

- (UIColor *)primaryTextColorForAd:(AdMobView *)adView
{
	return [UIColor colorWithRed:1 green:1 blue:1 alpha:1]; // this should be prefilled; if not, provide a UIColor
}

- (UIColor *)secondaryTextColorForAd:(AdMobView *)adView
{
	return [UIColor colorWithRed:1 green:1 blue:1 alpha:1]; // this should be prefilled; if not, provide a UIColor
}

- (NSArray *)testDevices
{
	return [NSArray arrayWithObjects: ADMOB_SIMULATOR_ID, nil];
}

- (void)didReceiveAd:(AdMobView *)adView
{
	CCLOG(@"AdMob: Did receive ad");

	[self rotateBannerView:[self currentOrientation]];
	[self.view addSubview:adMobAd];

	[delegate adController:self didLoadAdMobAd:adView];
}

// Sent when an ad request failed to load an ad
- (void)didFailToReceiveAd:(AdMobView *)adView
{
	CCLOG(@"AdMob: Did fail to receive ad");
	[adMobAd removeFromSuperview];
	[adMobAd release];
	adMobAd = nil;

	[delegate adController:self didFailedToRecieveAdMobAd:adView];
}

#pragma mark -
#pragma mark Memory Management

- (void) dealloc
{
	if (adMobAd)
	{
		[adMobAd setDelegate:nil];
		[adMobAd removeFromSuperview];
		[adMobAd release];
		adMobAd = nil;
	}

	if (adBannerView)
	{
		[adBannerView setDelegate:nil];
		[adBannerView removeFromSuperview];
		[adBannerView release];
		adBannerView = nil;
	}

    [super dealloc];
}

@end

The usage is very simple, #import AdViewController.h in you Layer's .h and add the delegate protocol AdViewControllerDelegate

#import "AdViewController.h"

@interface Menu : CCLayer <AdViewControllerDelegate>
{
	AdViewController	*adController;
}

And in your layer's .m add this

- (void)onEnter
{
	[super onEnter];

	adController = [[AdViewController alloc] initWithMasterView:[[CCDirector sharedDirector] openGLView]];
	[adController setDelegate:self];

}

- (void)onExit
{
	//Completely remove the controller
	[adController setDelegate:nil];
	[adController release];
	adController = nil;

	[super onExit];
}

- (void)adController:(AdViewController*)controller didLoadiAd:(id)iadBanner;
{
	//Do something when the ad loads, like moving objects.
}

- (void)adController:(AdViewController*)controller didFailedToRecieveiAd:(id)iadBanner;
{
	//Do something when the ad fails to load, like moving objects.;
}

- (void)adController:(AdViewController*)controller didLoadAdMobAd:(AdMobView*)adMobBanner;
{
	//Do something when the ad loads, like moving objects.
}

- (void)adController:(AdViewController*)controller didFailedToRecieveAdMobAd:(AdMobView*)adMobBanner;
{
	//Do something when the ad fails to load, like moving objects.
}

And of course you have to weak link the iAds framework for it to work on iOS < 4.0

That's it, I hope I help someone. If you have any observations or improvements you would like to add, they are welcome. I would like to display an admob ad when the iAd fails to load but I don't know how to test this. The iAd always loads.

Posted 1 year ago #

JonKean
Member

Use Mobclix. Not only do they pay better than AdMob, but a single Mobclix banner gives you access to Mobclix + AdMob + iAds.

Posted 1 year ago #
jandrad
Member

I haven't tried Mobclix but I will do it.

Still, the code is here for anyone who wants it.

Posted 1 year ago #
pfg2009
Member

That's great code. Thanks for sharing!

Posted 1 year ago #
Tiny Technician
Member

Thanks for sharing your adviewcontroller code! I have implemented iAds in one of my other apps (everything works in that App) but somehow I can't get test ads to display in my latest cocos2d App I'm working on. Hopefully this code does the trick...really don't see why it currently isn't working since I've done it successfully already.

I'm also looking at Mobclix, since I hear it can use iAds (and everything else) also. If anyone adds that to your nice looking template here I think we'll have all bases covered, hehe.

Posted 1 year ago #
jandrad
Member

I don't see any iAd in my test device either, it seems it's a general thing. But it works fine on the simulator. This has happened before: https://devforums.apple.com/message/248850

Posted 1 year ago #
franticfingers
Member

Thanks for posting this.
It works well for me on multiple devices.

Posted 1 year ago #
max9xs
Member

Thanks for code sharing...!

Posted 1 year ago #
Diego R.
Member

I implemented jandrad code. It shows the ad, but clicking on it doesn't bring the full ad window. I'm using 4.1. Does anybody have the same issue?

Posted 1 year ago #

jandrad
Member

You are right. It seems things are broken on 4.1. I managed to make the ad clickable. But when I rotate the ad in landscape mode it is not clickable again. To be honest I don't know why it is happening. Rotation in landscape mode is working ok.

Here's the updated code:

AdViewController.h

#import <UIKit/UIKit.h>
#import <iAd/iAd.h>
#import "AdMobDelegateProtocol.h"

@protocol AdViewControllerDelegate;

@interface AdViewController : UIViewController <ADBannerViewDelegate, AdMobDelegate>
{
	id <AdViewControllerDelegate>	delegate;

	//ADBannerView Transformations:
	CGAffineTransform transformLast, transformLeft, transformRight;

	//Banners:
	id								adBannerView;
	AdMobView*						adMobAd;
}

@property (nonatomic, assign) id <AdViewControllerDelegate> delegate;

- (id)initWithMasterView:(UIView*)newMasterView;
- (void)rotateBannerView:(UIDeviceOrientation)toDeviceOrientation;
- (void)updateBannerViewOrientation;

@end

@protocol AdViewControllerDelegate

- (void)adController:(AdViewController*)controller didLoadiAd:(id)iadBanner;
- (void)adController:(AdViewController*)controller didFailedToRecieveiAd:(id)iadBanner;

- (void)adController:(AdViewController*)controller didLoadAdMobAd:(AdMobView*)adMobBanner;
- (void)adController:(AdViewController*)controller didFailedToRecieveAdMobAd:(AdMobView*)adMobBanner;

@end

AdViewController.m

#import "AdViewController.h"
#import "cocos2d.h"

#import "AdMobView.h"

@implementation AdViewController

@synthesize delegate;

- (id) initWithMasterView:(UIView*) newMasterView
{
	if( nil != (self = [super init]) )
	{
		self.view = newMasterView;

		//Initialize the class manually to make it compatible with iOS < 4.0
		Class classAdBannerView = NSClassFromString(@"ADBannerView");
		if (classAdBannerView != nil)
		{
			adBannerView = [[classAdBannerView alloc] init];
			[adBannerView setDelegate:self];
			[adBannerView setRequiredContentSizeIdentifiers: [NSSet setWithObjects:
															  ADBannerContentSizeIdentifier320x50,
															  ADBannerContentSizeIdentifier480x32, nil]];

			[self.view addSubview:adBannerView];
			[adBannerView setHidden:YES];

			[self updateBannerViewOrientation];

		}
		else
		{
			//Request an AdMob Ad
			if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad)
				adMobAd = [AdMobView requestAdOfSize:ADMOB_SIZE_748x110 withDelegate:self];
			else
				adMobAd = [AdMobView requestAdOfSize:ADMOB_SIZE_320x48 withDelegate:self];
			[adMobAd retain];
		}
	}

	return self;
}

- (UIDeviceOrientation)currentOrientation
{
	return [[CCDirector sharedDirector] deviceOrientation];
}

- (void)updateBannerViewOrientation
{
	[self rotateBannerView:[self currentOrientation]];
}

- (void)rotateBannerView:(UIDeviceOrientation)toDeviceOrientation
{
	//Get Screen Size
	CGSize screenSize = [[UIScreen mainScreen] bounds].size;

	if (adBannerView)
	{
		if (UIDeviceOrientationIsLandscape(toDeviceOrientation))
			[adBannerView setCurrentContentSizeIdentifier:ADBannerContentSizeIdentifier480x32];
		else
			[adBannerView setCurrentContentSizeIdentifier:ADBannerContentSizeIdentifier320x50];

		//Get ADBannerView Frame
		CGSize adBannerViewSize = [adBannerView frame].size;

		[(UIView*)adBannerView setTransform:CGAffineTransformIdentity];
		[adBannerView setFrame:CGRectMake(0.f, 0.f, adBannerViewSize.width, adBannerViewSize.height)];

		//Set the transformation for each orientation
		switch (toDeviceOrientation)
		{
			case UIDeviceOrientationPortrait:
			{
				[adBannerView setCenter:CGPointMake(screenSize.width/2, screenSize.height - adBannerViewSize.height/2)];
				if ([adBannerView isHidden])
					[adBannerView setCenter:CGPointMake(screenSize.width/2, screenSize.height + adBannerViewSize.height/2)];
			}
				break;
			case UIDeviceOrientationPortraitUpsideDown:
			{
				[(UIView*)adBannerView setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(180))];
				[adBannerView setCenter:CGPointMake(screenSize.width/2, adBannerViewSize.height/2)];
				if ([adBannerView isHidden])
					[adBannerView setCenter:CGPointMake(screenSize.width/2, -adBannerViewSize.height/2)];

			}
				break;
			case UIDeviceOrientationLandscapeLeft:
			{
				[(UIView*)adBannerView setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(90))];
				[adBannerView setCenter:CGPointMake(adBannerViewSize.height/2, screenSize.height/2)];
				if ([adBannerView isHidden])
					[adBannerView setCenter:CGPointMake(-adBannerViewSize.height/2, screenSize.height/2)];
			}
				break;
			case UIDeviceOrientationLandscapeRight:
			{
				[(UIView*)adBannerView setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(-90))];
				[adBannerView setCenter:CGPointMake(screenSize.width - adBannerViewSize.height/2, screenSize.height/2)];
				if ([adBannerView isHidden])
					[adBannerView setCenter:CGPointMake(screenSize.width + adBannerViewSize.height/2, screenSize.height/2)];

			}
				break;
			default:
				break;
		}
	}

	if (adMobAd)
	{
		[adMobAd setTransform:CGAffineTransformIdentity];

		CGSize adMobAdSize = adMobAd.frame.size;

		//Set the transformation for each orientation
		switch (toDeviceOrientation)
		{
			case UIDeviceOrientationPortrait:
			{
				[adMobAd setCenter:CGPointMake(screenSize.width/2, screenSize.height - adMobAdSize.height/2)];
			}
				break;
			case UIDeviceOrientationPortraitUpsideDown:
			{
				[adMobAd setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(180))];
				[adMobAd setCenter:CGPointMake(screenSize.width/2, adMobAdSize.height/2)];
			}
				break;
			case UIDeviceOrientationLandscapeLeft:
			{
				[adMobAd setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(90))];
				[adMobAd setCenter:CGPointMake(adMobAdSize.height/2, screenSize.height/2)];
			}
				break;
			case UIDeviceOrientationLandscapeRight:
			{
				[adMobAd setTransform:CGAffineTransformMakeRotation(CC_DEGREES_TO_RADIANS(-90))];
				[adMobAd setCenter:CGPointMake(screenSize.width - adMobAdSize.height/2, screenSize.height/2)];
			}
				break;
			default:
				break;
		}
	}
}

#pragma mark -
#pragma mark ADBannerViewDelegate

- (BOOL)allowActionToRun
{
	return YES;
}

- (void) stopActionsForAd
{
	//Stop Background Music and other actions...

	[adBannerView setHidden:YES];

	//Stop Director
	[[CCDirector sharedDirector] stopAnimation];
	[[CCDirector sharedDirector] pause];
}

- (void) startActionsForAd
{
	//Stort Background Music and other actions...

	[adBannerView setHidden:NO];
	[self rotateBannerView:[self currentOrientation]];
	[[UIApplication sharedApplication] setStatusBarOrientation:(UIInterfaceOrientation)[self currentOrientation]];

	//Resume Director
	[[CCDirector sharedDirector] stopAnimation];
	[[CCDirector sharedDirector] resume];
	[[CCDirector sharedDirector] startAnimation];
}

- (BOOL)bannerViewActionShouldBegin:(ADBannerView *)banner willLeaveApplication:(BOOL)willLeave
{
	BOOL shouldExecuteAction = [self allowActionToRun];
    if (!willLeave && shouldExecuteAction)
    {
		[self stopActionsForAd];
    }
    return shouldExecuteAction;
}

- (void)bannerViewDidLoadAd:(ADBannerView *)banner
{
	CCLOG(@"iAd Did Load");

	if (adMobAd)
	{
		[adMobAd setDelegate:nil];
		[adMobAd removeFromSuperview];
		[adMobAd release];
		adMobAd = nil;
	}

	if (![self.view.subviews containsObject:adBannerView])
		[self.view addSubview:adBannerView];

	[adBannerView setHidden:NO];
	[self rotateBannerView:[self currentOrientation]];

	[delegate adController:self didLoadiAd:banner];
}

- (void)bannerView:(ADBannerView *)banner didFailToReceiveAdWithError:(NSError *)error
{
	CCLOG(@"iAd Failed To Load With Error: %@", [error localizedDescription]);

	[adBannerView setHidden:YES];

	if ([self.view.subviews containsObject:adBannerView])
		[adBannerView removeFromSuperview];

	if (!adMobAd)
	{
		CCLOG(@"Loading AdMob Ad...");
		if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad)
			adMobAd = [AdMobView requestAdOfSize:ADMOB_SIZE_748x110 withDelegate:self];
		else
			adMobAd = [AdMobView requestAdOfSize:ADMOB_SIZE_320x48 withDelegate:self];
		[adMobAd retain];
	}

	[delegate adController:self didFailedToRecieveiAd:banner];
}

- (void)bannerViewActionDidFinish:(ADBannerView *)banner
{
	[self startActionsForAd];
}

#pragma mark -
#pragma mark AdMobDelegate

- (NSString *)publisherIdForAd:(AdMobView *)adView
{
	return @"your_publisher_id"; // this should be prefilled; if not, get it from http://www.admob.com
}

- (UIViewController *)currentViewControllerForAd:(AdMobView *)adView {
	return self;
}

- (UIColor *)adBackgroundColorForAd:(AdMobView *)adView
{
	return [UIColor colorWithRed:0 green:0 blue:0 alpha:1]; // this should be prefilled; if not, provide a UIColor
}

- (UIColor *)primaryTextColorForAd:(AdMobView *)adView
{
	return [UIColor colorWithRed:1 green:1 blue:1 alpha:1]; // this should be prefilled; if not, provide a UIColor
}

- (UIColor *)secondaryTextColorForAd:(AdMobView *)adView
{
	return [UIColor colorWithRed:1 green:1 blue:1 alpha:1]; // this should be prefilled; if not, provide a UIColor
}

- (NSArray *)testDevices
{
	return [NSArray arrayWithObjects:
			ADMOB_SIMULATOR_ID,								//iPhone Simulator
			nil];
}

- (void)didReceiveAd:(AdMobView *)adView
{
	CCLOG(@"AdMob: Did receive ad");

	[self rotateBannerView:[self currentOrientation]];
	[self.view addSubview:adMobAd];
	[self.view sendSubviewToBack:adMobAd];

	[delegate adController:self didLoadAdMobAd:adView];
}

// Sent when an ad request failed to load an ad
- (void)didFailToReceiveAd:(AdMobView *)adView
{
	CCLOG(@"AdMob: Did fail to receive ad");
	[adMobAd removeFromSuperview];
	[adMobAd release];
	adMobAd = nil;

	[delegate adController:self didFailedToRecieveAdMobAd:adView];
}

- (void) stopActionsForAdMobAd
{
	//Stop Background Music and other actions...
}

- (void) startActionsForAdMobAd
{
	//Start Background Music and other actions...
}

- (void)didPresentFullScreenModalFromAd:(AdMobView *)adView
{
	[self stopActionsForAdMobAd];
}

- (void)willDismissFullScreenModalFromAd:(AdMobView *)adView
{
	[self startActionsForAdMobAd];
}

- (void)didDismissFullScreenModalFromAd:(AdMobView *)adView
{
	[self rotateBannerView:[self currentOrientation]];
	[[UIApplication sharedApplication] setStatusBarOrientation:(UIInterfaceOrientation)[self currentOrientation]];
}

#pragma mark -
#pragma mark Memory Management

- (void) dealloc
{
	if (adMobAd)
	{
		[adMobAd setDelegate:nil];
		[adMobAd removeFromSuperview];
		[adMobAd release];
		adMobAd = nil;
	}

	if (adBannerView)
	{
		[adBannerView setDelegate:nil];
		[adBannerView removeFromSuperview];
		[adBannerView release];
		adBannerView = nil;
	}

    [super dealloc];
}

@end

Let me know if it works for you. I added support for iPad ads with admob. It also requests an Admob ad if iAds fail to load.

Posted 1 year ago #

Diego R.
Member

Thanks Jose,

The posted code works nicely.

A couple of questions/suggestions:

- How do you manage scene transitions with iAd. I mean, do you destroy and create the view controller every time? Does that affect the number of ads supplied by apple (do they do any caching or a backend connection is made everytime)?

- Add support for top lanscape and bottom landscape as a parameter

- You should post this small library in a public repo (github?). The code is nice enough and it would make the maintenance simpler.

Thanks again for making this code available!!

Posted 1 year ago #
Diego R.
Member

Another question to people using this code or another iAd implementation. The ad banner usually loads in the simulator, but on the device I always get this error: 'iAd Failed To Load With Error: The operation couldn’t be completed. Ad inventory unavailable'.

Did anyone else experience this issue? Any suggestions?

Thanks for your help!

Posted 1 year ago #
jandrad
Member

I'll take your suggestions. I will try to add them later. The error you are seeing is normal. It's on apple's part. It means there's no ad to display at the moment. iAds currently have a low fill rate.

Posted 1 year ago #
Webtopia
Member

Thanks for this code. It works really well.

What I do is I call the AdViewController from the appDelegate. That way I don't have to stop and start the ads at each layer.

I have another issue. My cocos app is basically a book so i have a lot of text each page. I've dealt with CCLabels and so on before and it's pretty complicated to get them lined up over several lines, scrolling etc. So I went a standard UITextView. This is fine and I attach it like this

[[[[CCDirector sharedDirector] openGLView] window] addSubview: theTextView];

However the problem is that in the app delegate I also attach the adMobViewController also to the openGLView

So when the new type of admob ads appear (the ones that keep you within the app) the UITextView is overlayed on that view.

Has anyone had this problem?

Any ideas how to attach the UITextView to the layer rather than the window. Or is there a way to send the admobView to the front when it's selected?

Thanks,
Travis

Posted 1 year ago #
Diego R.
Member

@jandrad Thanks Jose, my concern on the error message is because with the iads sample suite by Apple, both the device and the simulator show the banner.

Posted 1 year ago #
cybergreg
Member

Check to see if your landscape iAd is clickable on the far left-hand edge. That's how my app is working (well, not working :-]). THIS POST on the dev forums means we are not alone. This kind of looks like there is a problem using transforms on the banner view with iOS 4.1

Posted 1 year ago #
Diego R.
Member

In the simulator, it is clickable. In the phone, it doesn't load at all, returning the 'No ad inventory' always.

Posted 1 year ago #
cybergreg
Member

@boca_jrs - that sounds like a different problem, but I will say that the odds of getting an iAd while testing are now maybe 50%. Just a month ago that was not the case and you almost always got a test ad.

Edit: is your app ID listed in the iTunes Connect, iAd section/report?

Posted 1 year ago #
Diego R.
Member

@cybergreg - Yes, it listed in ITC. I would be happy with 50% ... even 10% :)

Posted 1 year ago #
cybergreg
Member

@boca_jrs - wait - are you IN the USA? if not that's the reason for no ad's. If you are... then do you see in iTunes/iAd it should list as "receiving test ads" or something.

Posted 1 year ago #
Diego R.
Member

@cybergreg: Yes, I am in the US, and ITC displays "receiving test ads". Are you using same code that jandrad posted above?

Posted 1 year ago #
jandrad
Member
@Webtopia remove this line in the -(void)didRecieveAd:(AdMobView*)adView method and let me know how it worked for you.
```
[self.view sendSubviewToBack:adMobAd];
```
@boca_jrs the tes ads appear on my device but it's pretty random. I wouldn't be too concerned about it. Take a look: http://img638.imageshack.us/img638/4981/img0003k.png
Posted 1 year ago #
cybergreg
Member

@boca_jrs - no, I'm using just the iAd code from jandrads other example. I think I'm going to upgrade the project and allow the glview to autorotate, maybe then I won't have to futz around with the transforms.

Update: I revised my project to use 0.99.5.2 and the RootViewController, then I actually merged the Apple iAd sample (TextViewController) so IT is now the ADBannerView delegate. Suffice to say both portrait and landscape iAd's respond properly. If I get some free time I'll create a sample project.

Posted 1 year ago #
Diego R.
Member

@cybergreg - Whenever you have a chance to post your code, please do so. I would really appreciate it.

Thanks!

Posted 1 year ago #
Webtopia
Member

@jandrad Still no luck. The CCLayer and hence the UITextView is added after the AdviewController. I even tried brignSubviewToFront but that didn't work either.

I think I might move to 0.99.5 and use the BitmapFontAtlas with multiline labels instead of UITextView.

Can anyone tell me if it's supports scrolling? I'd need to be able to have more that a page with of text.

Posted 1 year ago #
jandrad
Member

Instead of attaching the textview to the windows you should attach it to the openGlView and then push the textview to the back.

Posted 1 year ago #
cybergreg
Member

@boca_jrs - here is a sample app: DOWNLOAD

HOWEVER - there is a problem as shown in this image:

I've been trying several variations and have found many ways to break it, but none to fix it. The actual problem is when rotated the landscape view is like out of sync but this only happens on non-multitasking devices; devices that support multitasing WORK FINE!. It is also not caused in any way by iAd's. I made a new 0.99.5.2 project, set the rootviewcontroller to allow full rotation and it is showing the same problem. I'm going to submit an issue and hopefully @Riq can take a look.

Edit: ISSUE LINK

Posted 1 year ago #
wasabibit
Member

@jandrad, Thanks for sharing your code!

I started looking at this and have a basic question to ask.
I have a landscape screen. It looks like AdMob supports 320x48 image size whereas iAd shows 480x32 image for landscape. With jandrad's code, 320x48 AdMob image is displayed in my landscape screen. This AdMob ad looks "Thicker" than the iAd landscape ad images I saw in other apps. Please correct me if I am wrong.
Basically I'd like the ad image size to be consistent regardless of the source(AdMob,iAd). How do we accommodate two different sizes in a game with landscape mode only?

Thanks

Posted 1 year ago #
Diego R.
Member

@cybergreg: Thanks a lot for posting your code, I saw Riq remarks that that issue won't be fixed. What does that mean for your implementation on 3G devices. If I want only a landscape orientation in my app, will the user have the same issue?

Thanks!

Posted 1 year ago #
cybergreg
Member

@boca_jrs - I'm cool with it. I just resubmitted the update to my app and all I did was disable full rotation on devices that don't support multitasking. Full rotation was cool but certainly not a requirement. My other project is using landscape only rotation and it has been working fine on older devices so you should be all set.

The problem is only when you transform the openGL frame (resize), again on the older devices. To support 180 degrees you don't have to transform the openGL view at all.
:-]

Posted 1 year ago #

RSS feed for this topic

12 Next »

Reply »

You must log in to post.