Program recives signal EXC_BAD_ACCESS

cocos2d for iPhone » Programming » iPhone SDK / UIKit / Objective-C / Xcode

Program recives signal EXC_BAD_ACCESS

(24 posts) (4 voices)

Started 1 month ago by dcthatch
Latest reply from dcthatch

Tags:

dcthatch
Member

I am sorry that i am probably asking a very simple question, but this has really been confusing me, and i have no idea how to fix it. I thought that that error meant that there was too much memory being used, so i minimized the amount of memory that my code was using, and ran it with instruments, using allocations. I discovered that i was only using 4.37 mb of memory when the app crashed and that popped up on the debugger. If i am correct, it should be fine to use that much memory (correct me if i am wrong, i am afraid that i am fairly new to the iphone and cocos2d/box2d). Please can somebody help and suggest what the problem might be.

thanks.

Posted 1 month ago #
riq
Key Master

Please, read this post. It explains how to report a crash.

Posted 1 month ago #
hactar
Member

4 mb is fine, worry when you're in your 20s. The error you describe usually occurs when you're trying to access an object that has already been released or when you are running multiple threads and are not taking care of synchronization properly... But as riq says, without a proper post we can't really help you.

Posted 1 month ago #
lordbritishix
Member

I just had this problem yesterday and it took me a few hours to figure this out :) Anyway, this problem can also be caused if you delete elements from an array that you are currently iterating.

You can also use an NSZombie - as described in this article:
http://www.codza.com/how-to-debug-exc_bad_access-on-iphone

as a means of helping you debug the problem.

Hope this helps!

Posted 1 month ago #
dcthatch
Member

thanks for all of the help guys, sorry about the lack of detail. I didn't want to post the cod straight away, as there is a lot of it and it isn't very well written, so i didn't want to have you read through it if there was an easy solution where you did not want to see the code. I will read the links, and thanks again for them.

Posted 1 month ago #

dcthatch
Member

thanks so much lordbritishix, that fixed in five minutes, and sorry to riq.

I now have another problem, yet again EXC_BAD_ACCESS, but now zombies is returning nothing. I am using cocos2d 0.99.1 on the simulator running iOS 4.

the error only happens when ccTouchesBegan is called from inside the level class, at a certain (code included below and the point is commented).

inline b2Fixture* b2Body::GetFixtureList()
{
	return m_fixtureList; // THIS IS HIGHLIGHTED IN THE DEBUGGER
}

Here is the init method inside level.mm:

-(id)initWithWorld:(b2World *)worl ThrowableArea:(int)throwableWidth Gravity: (float)gx : (float)gy{
	if ((self = [super init])) {
		throwWidth = throwableWidth;
		self.isTouchEnabled = TRUE;
		b2Vec2 grav = b2Vec2(gx, gy);
		worl = new b2World(grav, true);
		world = worl;
		boundaryLine = [CCSprite spriteWithFile:@"Line.png"];
		boundaryLine.position = ccp(throwableWidth, -310);
		map = [CCTMXTiledMap tiledMapWithTMXFile:@"TheMap.tmx"];
		[self addChild:map z:-1 tag:kTagBackground];
		[map addChild: boundaryLine];

		groundBodyDef.position.Set(0,0);
		groundBody = world->CreateBody(&groundBodyDef);
		boxShapeDef.shape = &groundBox;
		groundBox.SetAsEdge(b2Vec2(map.position.x - (map.contentSize.width/2),(map.position.y - (map.contentSize.height/2))), b2Vec2(map.contentSize.width, (map.position.x - (map.contentSize.width/2))));
		groundBody->CreateFixture(&boxShapeDef);
		groundBox.SetAsEdge(b2Vec2(0, map.contentSize.height), b2Vec2(map.contentSize.width, map.contentSize.height));
		groundBody->CreateFixture(&boxShapeDef);
		groundBox.SetAsEdge(b2Vec2(map.contentSize.width, map.contentSize.height), b2Vec2(map.contentSize.width, 0));
		groundBody->CreateFixture(&boxShapeDef);
		[self schedule:@selector(tick:)];
		gx = nil;
		gy = nil;
		throwableWidth = nil;
		worl = nil;
	}
	return self;
}

and here is the ccTouchesBegan method inside level.mm that is making the app crash:

-(BOOL)ccTouchesBegan:(NSSet *)touches withEvent:(UIEvent *)event{
	if (mouseJoint != NULL) return NO;
	NSSet *allTouches = [event allTouches];
	UITouch *touch = [touches anyObject];
	CGPoint touchLocation = [touch locationInView: [touch view]];
	touchLocation = [[CCDirector sharedDirector] convertToGL:touchLocation];
	if ([allTouches count] == 1) { //THE PROBLEM IS CAUSED BY ONE TOUCH THAT HAS A POSITION ON THE X AXIS LESS THAN THE        THROW WIDTH
		b2Vec2 locationWorld = b2Vec2(touchLocation.x, touchLocation.y);
		if (touchLocation.x < throwWidth) {
			b2Fixture *f;
			b2Body *b = world->GetBodyList();
			int i = 0;
			for (CCSprite *s = [ballArray objectAtIndex:i]; b; b = b->GetNext(), f = b->GetFixtureList(), i++) { //I AM TRYING TO LOOP THROUGH ALL THE BALLS IN THE LEVEL (ALL IN BALLARRAY) AND FIND OUT IF THE TOUCH IS IN THEM
				NSLog(@"Point 1 reached");
				if (CGRectContainsPoint(s.textureRect ,CGPointMake(locationWorld.x, locationWorld.y))) {
					NSLog(@"Point 2 reached");

					mouseJointDef.bodyA = groundBody;
					mouseJointDef.bodyB = bod;
					mouseJointDef.target = locationWorld;
					mouseJointDef.collideConnected = true;
					mouseJointDef.maxForce = 1000000.0f * bod->GetMass();
					mouseJoint = (b2MouseJoint *)world->CreateJoint(&mouseJointDef);
					bod->SetAwake(true);
					break;
				}
			}
		}

	}

	return YES;
}

The code in tutorial.mm (which i am using as a test level):

-(id) init {
	if ((self = [super init])) {
		self.isTouchEnabled = TRUE;
		level = [[Level alloc] initWithWorld:world ThrowableArea:150 Gravity:0.0f :-300.0f];
		[self addChild:level];
		[level addCannonBallAtPosition:100 :50];
	}
	return self;
}

the output from the debugger
[Session started at 2010-07-26 21:24:49 +0100.]
GNU gdb 6.3.50-20050815 (Apple version gdb-1469) (Wed May 5 04:36:56 UTC 2010)
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB. Type "show warranty" for details.
This GDB was configured as "x86_64-apple-darwin".sharedlibrary apply-load-rules all
Attaching to process 3469.
2010-07-26 21:24:53.937 FingerSmash Beta 2.0[3469:207] cocos2d: cocos2d v0.99.1
2010-07-26 21:24:53.938 FingerSmash Beta 2.0[3469:207] cocos2d: Using Director Type:CCDisplayLinkDirector
2010-07-26 21:24:53.971 FingerSmash Beta 2.0[3469:207] cocos2d: GL_VENDOR: Apple Computer, Inc.
2010-07-26 21:24:53.974 FingerSmash Beta 2.0[3469:207] cocos2d: GL_RENDERER: Apple Software Renderer
2010-07-26 21:24:53.975 FingerSmash Beta 2.0[3469:207] cocos2d: GL_VERSION: OpenGL ES-CM 1.1 APPLE
2010-07-26 21:24:53.975 FingerSmash Beta 2.0[3469:207] cocos2d: GL_MAX_TEXTURE_SIZE: 2048
2010-07-26 21:24:53.976 FingerSmash Beta 2.0[3469:207] cocos2d: Supports PVRTC: YES
2010-07-26 21:24:53.976 FingerSmash Beta 2.0[3469:207] cocos2d: GL_MAX_MODELVIEW_STACK_DEPTH: 16
[Switching to process 3469]
[Switching to process 3469]
2010-07-26 21:24:54.061 FingerSmash Beta 2.0[3469:207] cocos2d: Frame interval: 1
2010-07-26 21:25:00.592 FingerSmash Beta 2.0[3469:207] cocos2d: CCSpriteSheet: resizing TextureAtlas capacity from [219] to [293].
2010-07-26 21:25:00.593 FingerSmash Beta 2.0[3469:207] cocos2d: CCSpriteSheet: resizing TextureAtlas capacity from [293] to [392].
2010-07-26 21:25:00.594 FingerSmash Beta 2.0[3469:207] cocos2d: CCSpriteSheet: resizing TextureAtlas capacity from [392] to [524].
2010-07-26 21:25:00.596 FingerSmash Beta 2.0[3469:207] cocos2d: CCSpriteSheet: resizing TextureAtlas capacity from [524] to [700].
2010-07-26 21:25:05.983 FingerSmash Beta 2.0[3469:207] Point 1 reached
2010-07-26 21:25:05.984 FingerSmash Beta 2.0[3469:207] Point 1 reached
Program received signal: “EXC_BAD_ACCESS”.
(gdb)

Thankyou so much if you have read through all of that, i can't say how grateful i am.

Posted 1 month ago #

lordbritishix
Member

hmm, I haven't used Box2D yet but I was wondering if the statement:

'
mouseJoint = (b2MouseJoint *)world->CreateJoint(&mouseJointDef);
'

inside your ccTouchesBegan actually modifies the b2Body array that you are currently iterating. Try commenting it out to see if it will work.

Posted 1 month ago #
dcthatch
Member

thanks again lordbritishix, but this time i am afraid that it didn't work. I have realised that the NSLog(@"Point 1 reached") statement is called twice, while i only have one ball in the ball array. This is because i am using world->GetFixtureList, which will include the body i used to represent the ground, which is not in the ball array. As i am using b; as my parameter, it will be able to loop through twice, and as there is only one object in the ballArray, i am trying to execute this: [ballArray objectAtIndex:1];, which does not exist. I am fairly sure that that is the problem, and i will try fix it, but because i am not very good, any help would be more than welcome.

Thanks again to lordbritishix fro reading through all of that code.

Posted 1 month ago #
dcthatch
Member

Well my plan was to create an NSMutable array of all of the bodies, which doesn't work unfortunately, if somebody has any ideas, please could they help, all of the posts are much appreciated

Posted 1 month ago #
lordbritishix
Member
got confused with your complex loop :) if all you need to do is to do detect if the ball has been touched (I don't like the sound of that) and if you've added the balls inside your fixture list, then you can just iterate through your fixture list (and not the ball array at the same time) but every iteration, check if the class is a ball like so:
```
if ([fixtureItem isKindOfClass:[Ball class])
{
   //do specific items to the ball
   ..
}
```
Cheers!
Posted 1 month ago #

dcthatch
Member

thanks yet again to lord britishix, but because of a few complications i am afraid that i cannot do that. but i have made some changes, i'm afraid that i still need some help. I should probably have mentioned that i am using a CCTMXTiledMap. Here is the new code:

-(BOOL)ccTouchesBegan:(NSSet *)touches withEvent:(UIEvent *)event{
	if (mouseJoint != NULL) return NO;
	NSSet *allTouches = [event allTouches];
	UITouch *touch = [touches anyObject];
	CGPoint touchLocation = [touch locationInView: [touch view]];
	touchLocation = [[CCDirector sharedDirector] convertToGL:touchLocation];
	if ([allTouches count] == 1) {
		b2Vec2 locationWorld = b2Vec2(touchLocation.x, touchLocation.y);
		if (touchLocation.x < throwWidth) {
			b2Fixture *f;

			int i = 0;
			for (b2Body *b = world->GetBodyList(); i<noOfBalls; b = b->GetNext(), f = b->GetFixtureList()) {
				NSLog(@"Point 1 reached"); //THIS POINT IS STILL REACHED TWICE IF THE BALL IS NOT ON THE SCREEN, BUT STILL ON THE MAP, IF THE BALL IS ON THE SCREEN IT IS REACHED ONCE BEFORE THE CRASH
				if (b->GetPosition().y > 0 && b->GetPosition().x < throwWidth) { //THIS MEANS THAT THE BODY IS NOT THE GROUND BODY, AS THAT HAS A Y LOCATION OF 0, AND THAT BALL IS THROWABLE (IT CAN ONLY BE THROWN IF IT BEHIND A LINE THAT HAS A X VALUE OF THE THROW WIDTH).
					i++;
					NSLog(@"Point 2 reached"); THIS POINT IS ONLY REACHED IF THE BALL IS ON THE SCREEN
					if (f->TestPoint(locationWorld)) {
						NSLog(@"Point 3 reached"); //THIS POINT IS NEVER REACHED
						bod = b;
						mouseJointDef.bodyA = groundBody;
						mouseJointDef.bodyB = bod;
						mouseJointDef.target = locationWorld;
						mouseJointDef.collideConnected = true;
						mouseJointDef.maxForce = 1000000.0f * bod->GetMass();
						mouseJoint = (b2MouseJoint *)world->CreateJoint(&mouseJointDef);
						bod->SetAwake(true);
						break;
					}
				}
			}
		}

	}

	return YES;
}

The debugger shows me this if the ball is on the screen:

inline bool b2Fixture::TestPoint(const b2Vec2& p) const
{
return m_shape->TestPoint(m_body->GetTransform(), p); //THIS LINE IS HIGHLIGHTED
}

I guess that one of the things that i need to know is how to get the position of the body in the map not the screen, i still get the EXC_BAD_ACCESS error with the test point btw
Please can you help, i am sorry for my idiocy, thankyou so much

Posted 1 month ago #

riq
Key Master
Could you post the traceback ?

Once it crashes open the Xcode debugger console, and type "bt"
```
(gbd) bt
```
Please, post the traceback between backticks (`). thanks.
Posted 1 month ago #

dcthatch
Member

here is the traceback, thanks fro the quick reply.

#0  0x000064d3 in b2Fixture::TestPoint (this=0x28385be, p=@0xbfffd43c) at b2Fixture.h:307
#1  0x00005768 in -[Level ccTouchesBegan:withEvent:] (self=0x646f2b0, _cmd=0xb0f48, touches=0x78de100, event=0x64126a0) at /Users/Daniel/Programs/iPhone apps/FingerSmash Beta 2.0/Classes/Level.mm:76
#2  0x000977b3 in -[CCTouchDispatcher touches:withEvent:withTouchType:] (self=0x6425c40, _cmd=0xb92e1, touches=0x78de100, event=0x64126a0, idx=0) at /Users/Daniel/Programs/iPhone apps/FingerSmash Beta 2.0/libs/cocos2d/CCTouchDispatcher.m:252
#3  0x00097ce2 in -[CCTouchDispatcher touchesBegan:withEvent:] (self=0x6425c40, _cmd=0xb9f46, touches=0x78de100, event=0x64126a0) at /Users/Daniel/Programs/iPhone apps/FingerSmash Beta 2.0/libs/cocos2d/CCTouchDispatcher.m:289
#4  0x0009fbe1 in -[EAGLView touchesBegan:withEvent:] (self=0x6420c20, _cmd=0xb9f46, touches=0x78de100, event=0x64126a0) at /Users/Daniel/Programs/iPhone apps/FingerSmash Beta 2.0/libs/cocos2d/Support/EAGLView.m:290
#5  0x00833253 in -[UIWindow _sendTouchesForEvent:] ()
#6  0x008151ec in -[UIApplication sendEvent:] ()
#7  0x00819ac4 in _UIApplicationHandleEvent ()
#8  0x03dbdafa in PurpleEventCallback ()
#9  0x028fedc4 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ ()
#10 0x0285f737 in __CFRunLoopDoSource1 ()
#11 0x0285c9c3 in __CFRunLoopRun ()
#12 0x0285c280 in CFRunLoopRunSpecific ()
#13 0x0285c1a1 in CFRunLoopRunInMode ()
#14 0x03dbc2c8 in GSEventRunModal ()
#15 0x03dbc38d in GSEventRun ()
#16 0x0081db58 in UIApplicationMain ()
#17 0x00002890 in main (argc=1, argv=0xbfffef2c) at /Users/Daniel/Programs/iPhone apps/FingerSmash Beta 2.0/main.m:13
Current language:  auto; currently objective-c++
Warning: the current language does not match this frame.

Posted 1 month ago #

dcthatch
Member

I have fixed it, sort of. I added this line in after i++. f = b->GetFixtureList();

Now it only crashes when the centre of the ball is off the screen. I think that this can be fixed of i know how to get the position of the ball in the CCTMXTIledMap, and not on the screen. One problem, i don't know how to do that.... Is there a way that i could do that?

Thanks so much to lordbritishix and riq, you guys are geniuses, thanks for all of the help.

Update:I have just done some testing, and off the screen os not strictly true..... It seems that it will crash if it is not in the bounds of the original position of the screen

Posted 1 month ago #
lordbritishix
Member
Well, i'm not sure how to fix your crash to be honest :) But if there's still any value to it, here's how you convert a position in 2D space into a TMX tile coordinate:
```
- (CGPoint)tileCoordForPosition:(CGPoint)position {
    int x = position.x / _tileMap.tileSize.width;
    int y = ((_tileMap.mapSize.height * _tileMap.tileSize.height) - position.y) / _tileMap.tileSize.height;
    return ccp(x, y);
}
```
This should help you figure out the position of your ball in terms of the TMX tilemap coordinate.
Posted 1 month ago #
dcthatch
Member

thanks, the crash is fixed now, but i the ball is not being moved, because TestPoint isn't taking the position on the map, it is taking the point that the others used to take. I will take a look at the code of TestPoint and see if i can change it, but i don't think i can do much, i'm afraid that i might need your help again

Posted 1 month ago #
dcthatch
Member

i failed, to put it simply. I am afraid that i will need your help. Sorry

Posted 1 month ago #
dcthatch
Member

errr, slight problem, i used your function and then i logged the coordinates of the ball. i got 0, 1073741824

that is definately wrong could you explain how it works, it is probably something in my code

Posted 1 month ago #
lordbritishix
Member

hmm.. what type of coordinates did you pass? this is supposed to work with the screen coordinates (i.e. 0,0 to 320,480). It might be that the coordinates that you are passing are from your physics world.

Posted 1 month ago #
dcthatch
Member

it might be passing the coordinates of the bodies in the b2world. the thing is though, i have no idea why it would crash with the earlier method that i was using, where i think the positions were taken from the ones on the screen. I think i will have to do a bit of research on the body positions, and try to find out why the old one was crashing.

Posted 1 month ago #
dcthatch
Member

It's seems like the ball loses it's fixture when it goes of the bottom of the screen, but is still able to be part of all the physics.... i don't get it.

Posted 1 month ago #
lordbritishix
Member

sorry, I haven't used Box2D so I can't help you with that one :(

Posted 1 month ago #
dcthatch
Member

ahah, i found out where it is crashing.
if (b->GetPosition().y > 0 && b->GetPosition().x < throwWidth)

the thing is, i have no idea why. They all seem like valid statements to me

update: it actually is the case that if the ball is off of the original position of the screen the loop occurs a third time. I will try a different condition, but i have no idea why this happens.

Posted 1 month ago #
dcthatch
Member

aaaaahhhhhhh, i have now understood why it is happening. the statement is returning a false value, so it is trying to loop through an extra body, of which there isn't. So, i now need to figure out how to get the position of the ball on the map, and use TestPont on the map properly.

Posted 1 month ago #

RSS feed for this topic

Reply

You must log in to post.