Cannot run a CCAnimate action in a method other than init

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

Cannot run a CCAnimate action in a method other than init

(11 posts) (6 voices)

Started 1 year ago by ScrambledEggs
Latest reply from cocos2dbeginner

Tags:

ScrambledEggs
Member
Sorry if this is is an obvious problem...

I have three possible states -- square, circle, and triangle -- for my player character in the game, and six animations to morph between them. The CCAnimations themselves are fine. I'm able to run the CCAnimate action on them and my sprite to make them animate exactly the way I want to using this code in the init method:

[polyGuy runAction:[CCAnimate actionWithAnimation:transformCircleToSquareAnim restoreOriginalFrame:NO]];

I have three buttons in the form of CCMenuItems in my scene, one for each shape, which each call a method which checks the current shape and animates accordingly, e.g.:
```
- (void)squareTransform {
	if (currentShape == 1) {
		[polyGuy runAction:[CCAnimate actionWithAnimation:transformCircleToSquareAnim restoreOriginalFrame:NO]];
	} else if (currentShape == 2) {
		[polyGuy runAction:[CCAnimate actionWithAnimation:transformTriangleToSquareAnim restoreOriginalFrame:NO]];
	}
	currentShape = 0;
}
```
(0 is a square, 1 is a circle, and 2 is a triangle)

However this does not work! It instead shows an EXC_BAD_ACCESS error in the debugger at the point when the runAction: is being called. I know this is is quite a common error, and so I and my lack of knowledge have tried to find a cure for the past two hours to no avail.

Please help!
Posted 1 year ago #
David994A
Member

Well, it;s kind of hard to tell without the rest of your code....but....

Where do you declare transformCircleToSquareAni and transformTriangleToSquareAnim?

Perhaps it is just an issue of scope. Put those actions in your .h file as instance variables:
id transformCircleToSquareAni; in your @interface section of the .h file for example. This would apply to the polyGuy object as well.

Posted 1 year ago #

ScrambledEggs
Member

Thanks for replying

Originally I had them declared simply at the top of the .m file out of laziness. I'd forgotten about it, so I moved them into the @interface, but the same results occured.

Here's more code:

GameScene.h:

#import "cocos2d.h"

@interface GameScene : CCLayer
{
	CCSprite *polyGuy;

	CCAnimation *transformSquareToCircleAnim;
	CCAnimation *transformCircleToTriangleAnim;
	CCAnimation *transformTriangleToSquareAnim;
	CCAnimation *transformSquareToTriangleAnim;
	CCAnimation *transformCircleToSquareAnim;
	CCAnimation *transformTriangleToCircleAnim;

	NSMutableArray *animFrames;

	int currentShape;
}
+(id) scene;

@end

GameScene.m:

#import "GameScene.h"

@implementation GameScene

+(id) scene
{
	// 'scene' is an autorelease object.
	CCScene *scene = [CCScene node];

	// 'layer' is an autorelease object.
	GameScene *layer = [GameScene node];

	// add layer as a child to scene
	[scene addChild: layer];

	// return the scene
	return scene;
}
-(id) init
{
	// always call "super" init
	// Apple recommends to re-assign "self" with the "super" return value
	if( (self=[super init] )) {
                CCSpriteSheet *polySheet = [CCSpriteSheet spriteSheetWithFile:@"transform.png" capacity:72];
		[self addChild:polySheet];
		[[CCSpriteFrameCache sharedSpriteFrameCache] addSpriteFramesWithFile:@"transform.plist"];

                polyGuy = [CCSprite spriteWithSpriteFrameName:@"transform0001.png"];
		[polySheet addChild:polyGuy];
                polyGuy.position = ccp( 240, 160 );
		polyGuy.scale = 0.5;

		animFrames = [NSMutableArray array];
		for (int i = 1; i<26; i++) {
			CCSpriteFrame *frame = [[CCSpriteFrameCache sharedSpriteFrameCache] spriteFrameByName:[NSString stringWithFormat:@"transform00%02d.png",i]];
			[animFrames addObject:frame];
		}
		transformSquareToCircleAnim = [CCAnimation animationWithName:@"transformSquareToCircle" delay:0.04f frames: animFrames];
		//some more animation creations
                CCMenuItem *squareTransformButton = [CCMenuItemImage
									itemFromNormalImage:@"squareButton.png" selectedImage:@"squareButton.png"
									target:self selector:@selector(squareTransform)];
		squareTransformButton.position = ccp(50, 50);

		//other buttons

		CCMenu *transformMenu = [CCMenu menuWithItems:squareTransformButton, circleTransformButton, triangleTransformButton, nil];
		transformMenu.position = CGPointZero;
		[self addChild:transformMenu];

		currentShape = 0;
	}
	return self;
}

- (void)squareTransform {
	if (currentShape == 1) {
		[polyGuy runAction:[CCAnimate actionWithAnimation:transformCircleToSquareAnim restoreOriginalFrame:NO]];
	} else if (currentShape == 2) {
		[polyGuy runAction:[CCAnimate actionWithAnimation:transformTriangleToSquareAnim restoreOriginalFrame:NO]];
	}
	currentShape = 0;
}

//and other irrelevant methods

Thanks!

Posted 1 year ago #

David994A
Member

Can you show me the code where you call

squareTransform

also, this method is not in your .h file. If you call it from outside GameScene you should have it in the .h file.

Posted 1 year ago #

ScrambledEggs
Member

It is called by a menu button as shown above:

CCMenuItem *squareTransformButton = [CCMenuItemImage
	itemFromNormalImage:@"squareButton.png" selectedImage:@"squareButton.png"
	target:self selector:@selector(squareTransform)];
squareTransformButton.position = ccp(50, 50);

The method gets called perfectly, as simply just changing the frame of the sprite works well:

- (void)squareTransform {
	if (currentShape == 1) {
		//[polyGuy runAction:[CCAnimate actionWithAnimation:transformCircleToSquareAnim restoreOriginalFrame:NO]];
	} else if (currentShape == 2) {
		//[polyGuy runAction:[CCAnimate actionWithAnimation:transformTriangleToSquareAnim restoreOriginalFrame:NO]];
	}
	[polyGuy setDisplayFrame:[[CCSpriteFrameCache sharedSpriteFrameCache] spriteFrameByName:@"transform0001.png"]];
	currentShape = 0;
}

However if I uncomment those two lines, it crashes when I press the menu item.

I added all of my methods to the .h file, but the same result occurs:

#import "cocos2d.h"
#import "Box2D.h"

@interface GameScene : CCLayer
{
	CCSprite *polyGuy;

	CCAnimation *transformSquareToCircleAnim;
	CCAnimation *transformCircleToTriangleAnim;
	CCAnimation *transformTriangleToSquareAnim;
	CCAnimation *transformSquareToTriangleAnim;
	CCAnimation *transformCircleToSquareAnim;
	CCAnimation *transformTriangleToCircleAnim;

	NSMutableArray *animFrames;

	int currentShape;
}

+(id) scene;
-(void) pauseGame;
- (void)moveLeft;
- (void)moveRight;
- (void)jump;
- (void)squareTransform;
- (void)circleTransform;
- (void)triangleTransform;
- (void) nextFrame:(ccTime)dt;

@end

Thanks again

Posted 1 year ago #

ScrambledEggs
Member

shameless bump

Posted 1 year ago #
kimptoc
Member

Random thought - have you tried uncommenting the animations but commenting out the setDisplayFrame - I imagine that might occur immediately whereas the action may occur async and thus clash...

HTH, Chris.

Posted 1 year ago #
crmagicxxx
Member
You need to retain those CCAnimations. Example:
```
transformSquareToCircleAnim = [CCAnimation animationWithName:@"transformSquareToCircle" delay:0.04f frames: animFrames];
[transformSquareToCircleAnim retain];
```
And don't forget to release them in your onExit method.

Another option is to add those animations to sprites. That way they are auto-retained and will be auto-released when sprite is removed.
Posted 1 year ago #
ScrambledEggs
Member

Thanks a lot, that worked perfectly!

Posted 1 year ago #
MrIsaacs
Member

i fail to comprehend how CCAnimation's message frames work... it needs datatype nsarray. whats in this array? CCSpriteFrame datatypes or what?

sorry, didn't see it in the code quote...

Posted 1 year ago #
cocos2dbeginner
Member

Thanks a lot worked for me too!

Posted 1 year ago #

RSS feed for this topic

Reply

You must log in to post.