ParticleSystem release/dealloc bug?

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

ParticleSystem release/dealloc bug?

(6 posts) (4 voices)

Started 2 years ago by UserX2d
Latest reply from artakus

Tags:

UserX2d
Member
I'm using cocos2d 0.7.1 and am running into problems releasing a ParticleSystem object. After the memory is released, my game crashes as if a bad pointer is being accessed.

You can reproduce the crash even in the ParticleDemo.

For example if you change this...
```
@implementation DemoFlower
-(void) onEnter
{
	[super onEnter];
	ParticleSystem *emitter = [ParticleFlower node];
	[self addChild: emitter z:0 tag:kTagEmitter];
}
```
...into this (so the ParticleSystem is created then just released right away) then the demo will crash:
```
@implementation DemoFlower
-(void) onEnter
{
	[super onEnter];
	ParticleSystem *emitter = [ParticleFlower node];
        [emitter release]; // [emitter dealloc] causes crash too

	//[self addChild: emitter z:0 tag:kTagEmitter];
}
```
Am I not releasing the memory for a ParticleSystem correctly? Are there any known issues with ParticleSystem memory management?
Posted 2 years ago #
tehsuck
Member

Since you're using the class method node to initialize *emitter, you can't release it manually it gets put into the autorelease pool, so when you try to release it will die. At least that's my n00b understanding of it.

you might want to read up on "Convenience constructors"

Posted 2 years ago #
UserX2d
Member

I see, thanks for pointing that out. I guess I need to dive into the inner workings of how cocos2d is managing the memory.

Are there any best practice tips for manually managing the memory for ParticleSystem objects?

Posted 2 years ago #
UserX2d
Member
For anyone who came across my post...I see my mistake, which is more of an Objective C one than a cocos2d one.

Doing this is would be the proper way to manage the memory (make sure to increment the reference count by calling retain on pointer). After the game loop for that frame where the ParticleSystem object was created (and retained/released) the ParticleSystem object will be properly deallocated.
```
-(void) onEnter
{
	[super onEnter];
	ParticleSystem *emitter = [[ParticleFlower node] retain];
        [emitter release]; // [emitter dealloc] causes crash too

	//[self addChild: emitter z:0 tag:kTagEmitter];
}
```
Posted 2 years ago #
Codemattic
Moderator
Actually:
```
-(void) onEnter
{
	[super onEnter];
	ParticleSystem *emitter = [ParticleFlower node];
	// do stuff with emitter
}
```
is fine. emitter is created autoreleased, so its useable for the rest of the method, but if you want to keep it longer (for ex, if emitter was an instance variable) then you need to retain it and make sure you release it in your -dealloc. Dont ever call -dealloc on an object (except for [super dealloc]; at the end of a -dealloc method)
Posted 2 years ago #
artakus
Member

@Codemattic regarding to ur code above, does the creating an instance above also intialize the variable inside my class? something looks like this:

ParticleSystem *emitter = [[ParticleFlower node] init]; <-- is this right?

Posted 1 year ago #

RSS feed for this topic

Reply

You must log in to post.