Layer not deallocing, but others that are also children of the same scene are???

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

Layer not deallocing, but others that are also children of the same scene are???

(9 posts) (3 voices)

Started 1 year ago by Bongeh
Latest reply from Zammy

Tags:

Bongeh
Member
Hey guys, ive got a very peculiar bug appear today.

I've been working on my project a long time now, and i must have added something today to cause this..

Basically, i have a CCScene called GameScene

GameScene has 2 children, HUDLayer and GameLayer

The problem is, GameLayer is not deallocating. I have an NSLog in [GameLayer dealloc], the method never gets called. It means that when you loose, if you go back into the level, it crashes because it says you can't add the same child twice.

Very very rarely, it does deallocate.

What would stop a Layer from deallocating, perhaps I have a retained child of that layer somewhere?

My Control layer's dealloc method
```
- (void) dealloc
{
	// in case you have something to dealloc, do it in this method
	// in this particular example nothing needs to be released.
	// don't forget to call "super dealloc"

	NSLog(@"control layer dealloc called");
	[_mapsheet removeAllChildrenWithCleanup:YES];
	[self removeChild:_mapsheet cleanup:YES];
	_mapsheet = nil;

	[_mapsheetNonAlpha removeAllChildrenWithCleanup:YES];
	[self removeChild:_mapsheetNonAlpha cleanup:YES];
	_mapsheetNonAlpha = nil;

	cpSpaceFreeChildren(_gameSpace);
	cpSpaceFree(_gameSpace);
	_gameSpace = nil;
	NSLog(@"gamespace purged???");
	[_movingSprites release];
	_movingSprites = nil;
	[self removeAllChildrenWithCleanup:YES];
	[super dealloc];
}
```
This does not get called though..
Posted 1 year ago #
Bongeh
Member

if i forcefully deallocate it, cocos2d then trys to also dealloc it, causing a EXC BAD ACCESS, if i don't dealloc it, cocos2d never bothers too... oh man...

Posted 1 year ago #
jd
Member

Check that you unschedule schedulers when exiting them. You can also override onExit and check your retain count.

Posted 1 year ago #
Bongeh
Member

i unschedule any remaining schedules within my dealloc method, but this doesn't get called.

Posted 1 year ago #

2010-06-08 16:05:00.818 blobstacle[5325:207] hud layer dealloc called
2010-06-08 16:05:00.883 blobstacle[5325:207] cocos2d: deallocing <CCTimer = 002AD3F0 | target:PlayerSprite selector:(moveMe:)>

This logged after i moved back into my home screen (hud layer (my nslog call) hit, but my GameLayer didnt. PlayerSprite is a child of GameLayer, and it's timer was dealloc'd, so surely, GameLayer should have?

I then click back onto my game..

2010-06-08 16:05:05.799 blobstacle[5325:207] 1 pressed item level num
2010-06-08 16:05:05.851 blobstacle[5325:6aef] Finished Loading Chipmunk Game Space
2010-06-08 16:05:06.017 blobstacle[5325:6aef] Starting to add the sprite sheets
2010-06-08 16:05:06.072 blobstacle[5325:6aef] *** Assertion failure in -[GameLayer addChild:z:tag:], /Users/me/Desktop/final/libs/cocos2d/CCNode.m:275
2010-06-08 16:05:06.106 blobstacle[5325:6aef] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'child already added. It can't be added again'

So GameLayer's children see to be being deallocated, but it isnt?..

When it terminates, it is trying to do this

_mapsheet = [[LevelManager sharedLevelManager] sendMapSheetAlpha];
	[self addChild:_mapsheet z:100];

_mapsheet is a CCSpritesheet * pointer, the level manager command is a singleton that sends an id.

So what is happening, is the same instance of my GameLayer is being pulled forward and being added to my new GameScene, and not being dealloced so a new one can be made.. if i try to forcefully dealloc it, then cocos2d tries to dealloc it again, causing a crash..

Posted 1 year ago #

Bongeh
Member

i take it the retain count onExit should be 1?, mines 6! :S hmmmm

Posted 1 year ago #
Bongeh
Member

hmmm, it seems that when i unschedule a selector, it does not lower my retain count?, is this meant to happen?

Posted 1 year ago #
Bongeh
Member

i just learnt a golden rule the hard way.

If you override the onExit method to check the retainCount, remember to put [super onExit]; at the bottom of the method, else your layers will never deallocate!!

Lol.. i fixed the issue with the schedulers, but when i overwrote the onExit method i didnt put a super call in, i then spent 9hours debugging my own idiocy.

Hope others can see this and learn from my mistakes!

Posted 1 year ago #
Zammy
Member
Your post actually helped me!
Remove schedulers onExit in your scenes. Otherwise your scene wont be dealloced.
```
-(void)onExit {
	[[CCTouchDispatcher sharedDispatcher] removeDelegate:self];
	[self unschedule:@selector(step:)];
	[super onExit];
}
```
Posted 1 year ago #

RSS feed for this topic

Reply

You must log in to post.