Exc_bad_access when returnin a CGRect

cocos2d for iPhone » Programming » Programming - Everything else

Exc_bad_access when returnin a CGRect

(6 posts) (3 voices)

Started 1 year ago by pabloruiz55
Latest reply from robodude666

Tags:

No tags yet.

pabloruiz55
Member
Hi! i have the following problem:

I have a class which must return a CGRect from one of its methods:
```
-(CGRect)myRect
{
    CGRect rect = CGRectMake(self.mySprite.position.x,self.mySprite.position.y,self.mySprite.textureRect.size.width, self.mySprite.textureRect.size.height);
    return rect;
}
```
I get an exc_bad_access as soon as i try to access the mySprite ivar.

Thing is if i call it, the instance variable mySprite is full of garbage. BUT if i change the function to return void, self.mySprite does contain the correct data.
```
-(void)myRect
{
    CGRect rect = CGRectMake(self.mySprite.position.x,self.mySprite.position.y,self.mySprite.textureRect.size.width, self.mySprite.textureRect.size.height);
    return rect;
}
```
that does not crash when accessing mySprite...
Posted 1 year ago #
Codemattic
Moderator

You almost definitely have a memory leak somewhere else in your code. They are the worst bc sometimes they dont crash, and then you make a change that doesnt seem related, and now they do. Its probably with mySprite, but not definitely - it could be some other memory thats overwriting mySprite's memory.

Posted 1 year ago #
robodude666
Member

What happens when you use the CGRectMake directly where you are calling this method?

Are you setting the texture properly? textureRect is only set when a valid texture is created for the sprite. If the filename is wrong or the sprite is missing, no texture will be assigned thus textureRect won't be initialized (I believe). Try using contentSize instead, possibly.

If worst comes to worst, get a shotgun for the Zombies:

http://iphonedevelopertips.com/debugging/tracking-down-exc_bad_access-errors-with-nszombieenabled.html

Posted 1 year ago #
pabloruiz55
Member

Thanks!
I solved it by... changing nothing ¬¬

I just got up and was ready to try what robodude666 said so i could find the problem, launched the app and now it does not crash!

So i don't know what was happening or if i will get the same crash someday soon...

Anyways, thanks! i didn't know i do what robodude666 said.

Posted 1 year ago #
pabloruiz55
Member
Mhh, happening again, i am doing what robodude666 wrote but i am not getting any messages, is there anything else i must do?

The actual problem is with the whole object.

I have a ccnode object that contains some ivars the mySprite among them. Anyway, when i inspect the line where it crashed it shows garbage an ALL the ivars of that object.

in my gameLayer i am creating the object:

hero = [[Hero alloc] initWithGame:self];

Then in this other class i do:
```
if([self checkCollisions:[theGame.hero myRect]]) // here it crashes, when calling that method
{
    [theGame.hero destroy];
}
```
Posted 1 year ago #
robodude666
Member
What is -checkCollisions: and what is -destory: ?

Mostly likely the cause of the issue is you're releasing the hero, but then referring to him later again. The only way you'd have a bad memory access crash from looking at the rect of an object is if that object didn't exist, which is unlikely if your game works up to this point.

Keep in mind that Cocos2D will take responsibility to cleanup after you. If you add a CCNode as a child, and release it yourself you'll get a crash. This is because the CCLayer still thinks the node exists and tries to visit it in the loop but finds nothing and freaks out. If you plan to have responsibility for the release, you need to retain it:
```
CCSprite *mySprite = [[CCSprite spriteWithFile:@"HappySprite.png"] retain];
[self addChild:mySprite];
[mySprite release];
```
Posted 1 year ago #

RSS feed for this topic

Reply

You must log in to post.