A fast, easy to use, free, and community supported 2D game engine
i got a problem with this coding where it got leak. i already release but still leaking. anybody can help?
sword2 = [[items alloc] initWithName:@"Double Sword" description:@"Kill Faster" image:@"sword2a.png" statHP:20 statMP:20 statInt:1 statStr:2 damage:20 Ldamage:10 defence:10 type:3 level:1];
sword2.sell = 1700; release in dealloc
[sword2 release];
sword2=nil;What's "items" ? What kind of class is it ?
item is the object class that contains
- (id)initWithName:(NSString *)Name description:(NSString *)Desc image:(NSString *)img statHP:(int)HP statMP:(int)MP statInt:(int)Intel statStr:(int)Str damage:(int)Damage Ldamage:(int)ldamage defence:(int)Defence type:(int)EquipType level:(int)Level
{
self = [super init];
if (self) {
name = Name;
desc = Desc;
image = img;
hp=HP;
mp=MP;
gold=0;
type=EquipType;
strength=Str;
intelligence=Intel;
damage=Damage;
level=Level;
defence=Defence;
insertable=YES;
lowerDamage=ldamage;
}
return self;
}i didnt retains anything... once i allocated the swords as shown above then i release it at same class at dealloc. =_=" i use instrument then it always shown the leaking in this part.
sword2 = [[items alloc] initWithName:@"Double Sword" description:@"Kill Faster" image:@"sword2a.png" statHP:20 statMP:20 statInt:1 statStr:2 damage:20 Ldamage:10 defence:10 type:3 level:1];
it is because of this i put the items in the npc?
[allNPC addObject:[[NPC alloc] init:merchant entities:[[NSArray alloc] initWithObjects:sword2,nil] spawnPoint:CGPointMake(5800,145) animation:animation11 staticCharacter:[UIImage imageFromResource:@"NPC a1.png"] position:CGPointMake(5800,210) description:@"Herbalist Aida"]];then i release the allNPC. allNPC is NSMutabbleArray
[allNPC removeAllObjects]
[allNPC release];
allNPC=nil;The item and also the allNPC got leaking when i check with instrument.
Blue Ether
Member
Wow, you really stack a lot of allocs into one line!
You seem to be over-retaining things. For example, the array you are passing for "entities." If the NPC you are allocing is retaining the entities array in some way, you should autorelease it as you create it. You can do that simply by using the convenience method arrayWithObjects instead of using the alloc/initWithObjects combo (the convenience method will autorelease for you). The alloc/init is adding an extra retain, and since you don't even bother to store a reference to it, that extra retain is more than likely never getting released.
Also, the allNPC array is putting a retain on the NPC (when adding an object to an array or dictionary, a retain is placed on the object), but once again so is your alloc/init combination. So unless you autorelease the NPC as you create it, it will get over-retained.
Hope this helps.
thanks for the advice Blue Ether. i try your advice arrayWithObjects, seem like the application is crash somehow.
[allNPC addObject:[[NPC alloc] init:merchant entities:[[NSArray arrayWithObjects:sword2,sword3,nil] spawnPoint:CGPointMake(5800,145) animation:animation11 staticCharacter:[UIImage imageFromResource:@"NPC a1.png"] position:CGPointMake(5800,210) description:@"Herbalist Aida"]];in my coding how im gonna autorelease it.
Codemattic
Moderator
your initializer should retain objects that are passed to it, if it wants to keep them.
- (id)initWithName:(NSString *)Name description:(NSString *)Desc image:(NSString *)img statHP:(int)HP statMP:(int)MP statInt:(int)Intel statStr:(int)Str damage:(int)Damage Ldamage:(int)ldamage defence:(int)Defence type:(int)EquipType level:(int)Level
{
self = [super init];
if (self) {
name = Name;
[name retain];
desc = Desc;
[desc retain];
image = img;
[image retain];
...
nash8114
Member
@codemattic Be careful with thos retains. If name is defined as a property, then "name = Name" already retains it.
You must log in to post.