A fast, easy to use, free, and community supported 2D game engine
gametest
Member
Hello,
I read somewhere that sprites increase memory. I use many sprites in my game. In "Activity Monitor" it reaches 26 mb. I am using png files in sprites.
My game slows down after some time.
For example i am using
[self schedule:@selector(movePlayerTank:)];
this function to move tank. so after some time tank moves slowly.
Pls help me to solve this problem.
Thanks in advance.
Hi!
It would help if you posted some code...
Also check if in activity monitor if at the left it is checked something like "objects created and still alive" (i don't have my mac at hand) that should give you the amount of memory used at the current time,and not the total for the current run...
Ohh and i don't think you should be creating many threads for this issue... it is the third time you ask the same thing... have you tried what you have been told before?
gametest
Member
1) For memory Problem.
I posted code in the previous thread.
http://www.cocos2d-iphone.org/forum/topic/592?replies=1#post-3547
yes, i asked memory question many time. but all time i have different problem.
First i think it was due to not releasing array and other thing. Now i am releasing all the things and also optimize code.
I think it is due to more sprites i am using. Pls give me some important information to solve this problem by reading the previous question.
2) Game slow down
i am using following threads with "movePlayerTank".
[self schedule:@selector(obstacleAnimation:)];
[self schedule:@selector(enemyAnimation:)];
Hi!
You are separating the memory issue and the slowdown but they could be related.
From the other post i am understanding that you are adding layers in a single scene, maybe you should try having an scene for eachone instead... an scene for the menu, another one for the game itself, another one for the settings, etc. (check the sceneTest)
Also check that you are removing your sprites, maybe you are accumulating them in your game and as time passes there are hundreds of sprites in there.
You could also post some screens of what you see with Instruments for us to see.
It would help if you posted what is inside the functions you are scheduling...
obstacleAnimation and enemyAnimation
gametest
Member
thnks for quick reply.
Yes, memory issue and slowdown are related.
ok, I will separate the scene from the main screen for help, about us and other thing.
I was just releasing sprite [sprite release];
I read somewhere that use
[[TextureMgr sharedTextureMgr] removeAllTextures]; to release actual memory.
So i will use it and then check it with activity monitor.
I will send u screens of it and code for other functions after adding above statement to release sprite's memory.
gametest
Member
Hello,
I tried too much to solve the problem of memory but it is still 15 to 16 mb. & my game slows down.
I have 30 levels in my game. There is xml file for each level. in my xml file i set the position,strength,.... for obstacles , enemy info, player tank info, power comes in that level.
I declare arrObstacle, arrPower, arrEnemy globally. when xml loads all sprites are add in array accordingly.
I have obstacle , enemy, power, bullet class files inherited from NSObject.
And all has many attributes as per requirement. eg obstacle class has following things.
NSString *name;
int type;
int life;
int effectType;
int direction;
float speed;
Now, i am moving player tank with accelerometer. I made one function [self schedule:@selector(movePlayerTank:)]; & set direction in accelerate event.
[self schedule:@selector(obstacleAnimation:)];
in which obstacle animation occurs of obstacle.
[self schedule:@selector(enemyAnimation:)];
in which I wrote the code to move enemy. it is very big function. I add the enemyType(int) attribute in my game. i am moving enemy with different logic.
-(void)enemyAnimation:(ccTime)dt
{
for(enemy *e in arrEnemy)
{
if(e.enemyType == 1)
{
//Logic of one type of moving
Check that enemy is not going to collide with any of obstacle and enemy
int resultCollision = [self collisionForEnemy:e direction:e.direction]; // this is the function which checks collision.
if(resultCollision == 0)
{
if no collision then move enemy in the same direction
}
else
{
[self setDirectionfortype1]; // Else i change the direction & this function differs for different enemy type.
}
}
else if(e.enemyType == 2)
{
//Logic of one type of moving
}
.........
else if(e.enemyType == 7)
{
//Logic of one type of moving
}
}
}
@interface obstacles : NSObject
{
Sprite *destroySprite;
NSString *animationname;
int animindex;
}
When player or enemy fires on obstacle one I add "destroySprite " in layer and one animation occurs and when animation completes I remove that sprite and obstacle from layer and array of obstacle.
This is what i am doing in coding.
my game slows down. enemy movement , player tank movement, animation get stuck etc . Pls help me to solve the problem. Is this due to memory???
I complete the game. i am waiting for only this problem to solve.
I made my game in v0.7. Today I downloaded vo.8 & made test application in it to check difference between sprite and Atlas sprite but both use the same memory. so, i didn't convert game to v0.8. is it really make difference if i use AtlasSprite instead of Sprite.??
Thanks in advance.
gametest
Member
every time when user touch on screen bulletfires
- (BOOL)ccTouchesBegan:(NSSet *)touches withEvent:(UIEvent *)event
{
bullet *objBullet = [[bullet alloc]init];
objBullet.sprite = [Sprite spriteWithFile:@"bullet-fire.png"];
objBullet.sprite.position = cpv(playerVehicle.position.x,playerVehicle.position.y);
objBullet.direction = playerDirection;
objBullet.strength = bulletStrength;
[self add:objBullet.sprite z:0];
[arrPlayerbullet addObject:objBullet];
[objBullet release];
}
So every time new sprite added in the layer.I release that bullet sprite as it is no in use.
Is this code increase memory ???
Have you run the Leaks tool in Instruments ? If you have leaks, then it means there are some things you are not releasing correctly. Plus, you'll have a clue on what types of objects are leaked.
Also, you don't want to call [[TextureMgr sharedTextureMgr] removeAllTextures]; after the release of every sprite. You usually call that in the dealloc function of your scene.
rx82
Member
This post has me curious about how you guys add and remove sprites during gameplay.. Do you preallocate sprites in an array and reuse the same sprites during gameplay OR do you add sprites only when necessary ( this of course would mean removing the sprites when not necessary, IE. [self removeChild:asprite Cleanup:YES])?
adpro
Member
If you have a lot of sprites, why aren't you using AtlasSprites?
cleanup is also in 0.7 - not sure about regular sprites, but for AtlasSprite I believe it exists, if I am not mistaken.
Either way, if you are using any images more than once for more than one sprite, use AtlasSprites
I also found that re-using sprites or pre-allocating sprites by putting them in an array works quite well as well.
I created my own sprite objects for all of my 'enemies' - when one would die and another show up of the same type of enemy, I would re-use the dead one. Not sure if that will help you, but it kind of opens the door to the idea and logic of re-using things that are already in memory anyway.
@gametest,
Memory: Why do you think 15/16 MB is a lot? anything under 20MB is pretty safe to run in my opinion.
Speed: I'm assuming you refer to a drastic drop on your FPS (to see it on screen use [[Director sharedDirector] setDisplayFPS:YES];). Have you checked that you are not printing NSLogs/CCLogs on the Console at runtime?
rx82
Member
Have you done any performance tests on how AtlasSprites perform different than regular Sprites? What I've found is that the performance difference in using AtlasSprites vs Sprites appears negligible. (I load the same image over and over again ) I'm also aware that once you load a sprite once, it will stay in texturemanager until you "RemoveAllTextures". I don't see how you gain any performance by using AtlasSprites since TextureManager is holding the image in memory anyway...
symadept
Member
Hi Gametest,
I am facing a problem in shooting the bullet. Are you using chipmunk for collision detection? If so without the shape/body of the bullet how can you handle the collision. Can you let me know how are you handling,
1. Motion of the bullet at the rated speed, say 2 seconds should take to travel to the playerShip.
2. Collision detection if you are not using chipmunk.
Regards
Mustafa
gametest
Member
hello symadept,
I have not used chipmunk. I am moving bullet by making one function in which I set the position of bullet sprite (increase x / y according to deirection) & check collision detection with CGRectContainsPoint.
I have array of bullets.
-(void)movePlayerBullet:(ccTime)dt
{
for(int i=0; i<[arrPlayerbullet count];i++)
{
if([collision function == FALSE)
{
//move bullet
}
}
}
adpro
Member
As far as your atlas sprite question.
If you have a bunch of sprites that are using the exact same image, it is going to help A LOT for performance. If you have a bunch of sprites that are all different images, it will help to get them in memory first, but other than that it probably won't make a huge difference.
I have a crap load of sprites for my game and many of them use the exact same image. If I wasn't using atlas sprites, and I have tested this, my game would be sitting at 30fps the entire time probably.
It all depends on your game I guess, but I found using atlas sprites and atlas labels helped performance a lot.
That reminds me. Are you using any regular labels? If so, switch them to atlas labels and see the difference! It should be noticable.
gametest
Member
I declare sprite as
@property(readwrite,assign)Sprite *sprite;
so is it ok?? no need to release?
I use sprites with different images. & yes i use label not atlas label. Actually my game is in v0.7 so it has not the facility of AtlasSprite and AtlasLabel. If it affects memory lot then i will change version.
Codemattic
Moderator
gametest, you should get in the habit, if you have an ObjectiveC Object that you want to keep as a property, define the property as:
@property(readwrite,retain)Sprite *sprite;
and in your -dealloc method:
[sprite release];
There are only a few special cases where you dont retain an ObjectiveC Object property.
You must log in to post.
