cocos2d for iPhone

A fast, easy to use, free, and community supported 2D game engine

1. 

   colonel custer
   Member

   I just switched to the .8 beta of cocos 2d. I was using [myAction isDone] == YES to check when my actions were done but this seems to be broken now. It appears that the action is released the frame before isDone == YES and thus I never know when the action is done.

   As a patch, I retain my actions so that they are not released. Since I add a retain, I release them after [myAction isDone] == YES but this seems to cause memory leaks. Not sure why because I know I balanced the one retain with the one release.

   Are you planning on depreciating the isDone function or am I just doing something wrong?

   Thanks again

   Posted 2 years ago #
2. 

   riq
   Key Master

   isDone is not deprecated, and it is not in the plans to deprecate it.

   What you are doing seems to be OK: retain / release the action so that it is not freed from memory when it finishes.

   Posted 2 years ago #
3. 

   Dan
   Member

   I'm coming up with the same issue. It seems that there is a release being done somewhere on the action within the framework. Only by calling a retain when the action is being defined does the isDone function work. I'm on 0.8 as well.

   I'm a newb to cocosd, so what I'm trying to do is stop my walk animation when my sprite reaches its location via MoveTo. Here's my code:

   '
   - (void) moveSpriteTo: (Sprite*) theSprite destination:(CGPoint) whereTo
   {

   if(theSprite)
   {
   bartenderMove = [MoveTo actionWithDuration:2 position:whereTo];
   [bartenderMove retain]; // Have to retain otherwise code crashes
   AtlasAnimation* theWalk = (AtlasAnimation*)[theSprite animationByName:@"walk"];
   id walkAnim = [Animate actionWithAnimation: theWalk restoreOriginalFrame: TRUE];
   [theSprite runAction:[RepeatForever actionWithAction:walkAnim]];
   [theSprite runAction:bartenderMove];

   }
   }
   '
   and in my Tick() function:

   '
   if(bartenderMove)
   {
   if( [bartenderMove isDone] )
   {
   NSLog(@"Bartender done!");
   [sprite stopAllActions];
   //[bartenderMove release]; // Cant do or it crashes with 'sending isDone to a freed object'
   }
   else
   {
   NSLog(@"Bartender not done!");
   }
   '

   Is this the only way to coordinate a walk anim with a move?

   Thanks,
   -Dan

   Posted 2 years ago #
4. 

   Dan
   Member

   Damn, sorry, used apostrophe instead of backtick. My bad. -Dan

   Posted 2 years ago #
5. 

   Dan
   Member

   Sorry to keep replying to myself, but after a bit more debugging, I saw that the actionWithDuration method is autorelease, and it seems that its going away before isDone can actually get called. If I use the following, it seems to be ok:

   `
   bartenderMove = [[MoveTo alloc] initWithDuration:2 position:whereTo];
   '

   and later in the Tick() call the release, it seems to be fine.

   Again, I'm new to this, so I might be doing things incorrectly. Please let me know if that is the case. Thanks! -Dan

   Posted 2 years ago #
6. 

   Codemattic
   Moderator

   just for fun try:
   

   ...
   if( [bartenderMove isDone] )
   {
    NSLog(@"Bartender done!");
    [sprite stopAllActions];
    [bartenderMove release];
    bartenderMove=nil;
   }
   ...

   still crash the same way?

   Posted 2 years ago #
7. 

   Dan
   Member

   Changing it back to actionWithDuration, doing a retain, then doing a nil check, release, and nil set in the tick seems to work:

   bartenderMove = [MoveTo actionWithDuration:2 position:whereTo];
   [bartenderMove retain];

   in Tick():
   

   if(bartenderMove)
   {
    if( [bartenderMove isDone] )
    {
     NSLog(@"Bartender done!");
     [sprite stopAllActions];
     [bartenderMove release];
     bartenderMove=nil;
    }
   }

   Which is the proper method to use? It seems strange that a isDone method would be called on an object that autoreleases when, uh, its done. But it makes sense that it hangs around if specifically retained, making the method valid.

   With regards to what I'm doing (trying to have a sprite move & playing an animation to go with it), is this the right way to do it under this framework?

   Thanks!

   Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.