Removing and creating UIViews - works once, crashes second time

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

Removing and creating UIViews - works once, crashes second time

(8 posts) (4 voices)

Started 1 year ago by Arttu Ekholm
Latest reply from Arttu Ekholm

Tags:

Arttu Ekholm
Member

I have a problem with CCDirector and UIViews

The navigation of my game basically looks like this:
MainScene -> GameOverScene -> HighScoreView(:UIView) --> and back to the MainScene...

HighScoreView opens and closes normally ONCE, but during the second round of the game, the program quits when it should load HighScoreView again. No error messages, nothing.

HighScoreView is at the moment simple UIView with one button that calls closeHighScoreViewAndStartNewGame method to hide the view and move to the next scene.

Methods in my AppDelegate:

// there's global variable HighScoreView * hs

-(void)openHighScoreView {

	GameOverView *tempView = [[HighScoreView alloc] init];
	selfish = tempView;
	[tempView release];
	[[CCDirector sharedDirector]replaceScene:[MainScene node]];
	[UIView beginAnimations:nil context:NULL];
	[UIView setAnimationDuration:.5];
	[UIView setAnimationTransition:UIViewAnimationTransitionCurlUp forView:[[CCDirector sharedDirector] openGLView] cache:YES];
	[[[CCDirector sharedDirector] openGLView] addSubview:go.view];
	[UIView commitAnimations];

}

-(void)closeHighScoreViewAndStartNewGame {

	[UIView beginAnimations:nil context:NULL];
	[UIView setAnimationDuration:.5];
	[UIView setAnimationDelegate:self];
	[UIView setAnimationDidStopSelector:@selector(animDone:finished:context:)];
	[UIView setAnimationTransition:UIViewAnimationTransitionCurlDown forView:[[CCDirector sharedDirector] openGLView] cache:YES];
	[hs.view removeFromSuperview];
	[UIView commitAnimations];
	[hs release];
	hs = nil;
}

I let MainScene run in the background because [[CCDirector sharedDirector] resume] somehow crashes the program.

Does anyone know what's wrong in my code and how to fix it? Debugger console shows no error, and neither does try-catch blocks give me any explanation.

Posted 1 year ago #

jd
Member

I don't see where you do anything with go.view besides adding it as a subview. I don't think the appdelegate is a good place for this. I think you should have a separate scene that you can push/pop that contains this view. You will also be able to trace your retains better that way. My guess is you are not really getting rid of the view the first time and then there is a conflict the second call.

Posted 1 year ago #
greyhoundgames
Member

GameOverView *tempView = [[HighScoreView alloc] init];
selfish = tempView;
[tempView release];

That looks very wrong. You alloc, set it, release it. Its not destroyed unless you did something sneaky.

Posted 1 year ago #
Codemattic
Moderator
+1 greyhoundgames. selfish = [tempView retain]; or why do you need tempview at all? Why not:
```
selfish = [[HighScoreView alloc] init];
```
Also is HighScoreView a subclass of GameOverView? Because you are creating a HighScoreView and then assigning it to a GameOverView-typed variable. Also I dont see where the HighScoreView you create is stored in your hs global.

Why keep creating and destroying your HighScoreView. Why not create it once, store it, and show when you need it and hide it when you dont.
```
[[[CCDirector sharedDirector] openGLView] addSubview:go.view];
```
whats go?
Posted 1 year ago #

Arttu Ekholm
Member

Sorry for the confusing code in the last post. I made my code more easier to read. I also moved handling of GameOverView to GameOverScene. I'm not so familiar with handling UIViews :)

I also found out that debugger gives EXC_BAD_ACCESS when init method of GAmeOverScene tries to return itself during the second run.

Scenes are changed like this now:
// in the game scene game ends
[[CCDirector sharedDirector] replaceScene:[MainMenuScene scene]];
[[CCDirector sharedDirector] pushScene:[GameOverScene scene]];

Code for GameOverScene:

GameOverScene: CCScene 

// variables defined in GameOverScene.h
NSNotificationCenter * ns // handles messaging between GameOverView and GameOverScene
GameOverView * go // subclass of UIViewController. contains only one button that sends a notification to GameOverScene

-(id) init {
	if( (self=[super init] )) {
		self.isTouchEnabled = YES;
		self.nc = [NSNotificationCenter defaultCenter];
		[nc addObserver:self selector:@selector(notificationToCloseView:) name:nil object:nil]; // this listens to GameOverView's button presses
		go = [[GameOverView alloc]init]; // this is the view to be displayed
		[[[CCDirector sharedDirector] openGLView] addSubview:go.view]; // here the view is attached
	}
	return self;
}

- (void) dealloc
{
	self.go = nil;
	[self.go release];
	[super dealloc];
}

- (void) notificationToCloseView: (NSNotification *) notification { // this method is called when a button is pressed in GameOverView (which is a subclass of UIViewController)

		//NSNotificationCenter is removed here
		[nc removeObserver:self];
		[nc release]; 

		[go.view removeFromSuperview]; // view is removed from the superview
		[[CCDirector sharedDirector] popScene]; // GameOverScene is removed --> MainMenuScene appears
}

Works fell during first run, but gives EXC_BAD_ACCESS when GameOverScene is created second time.

Posted 1 year ago #

greyhoundgames
Member

Your not releasing right. Look at your code:
self.go = nil;
[self.go release];

You need to release it first then make it nil.
Also you release ns but you don't retain it. Thats a extra release and can produce the error your seeing. If you want to hold onto something you should retain it then release it when your done with it.

Posted 1 year ago #

Arttu Ekholm
Member

I changed methods dealloc and notificationToCloseview. Now nc and go will have retainCount == 0 during dealloc method. Still, it crashes on second time. I have no idea what to fix :/

The code looks now like this:

-(void) dealloc {
	[self.go release];
	nc = nil;
	go = nil;
	[super dealloc];
}

- (void) notificationToCloseView: (NSNotification *) notification {
	[go.view removeFromSuperview];
	[nc removeObserver:self];

	[[CCDirector sharedDirector] popScene];
}

Posted 1 year ago #

Arttu Ekholm
Member

I found the solution... I had accidentally added and GameOverView object to the GameOverView.xib. Removing it fixed the problem.
Sorry, and thanks for the help anyway :)

Posted 1 year ago #

RSS feed for this topic

Reply

You must log in to post.