A fast, easy to use, free, and community supported 2D game engine
Hi riq and others,
I was wondering has anyone tried to start implementing score deletion when rank is enabled?
I feel like my game could use it before the next update, so I am interested in implementing it for CocosLive.
I'm not sure how to begin though, such as how can I become a member of the CocosLive Google Code Group? And what other steps/things I should do or take note of?
Let me know, thank you.
- Sherwin
Edison's Labs
Hi,
It's not difficult to support 'delete on ranking'.
Actually it's a matter of time. I didn't find the time to do it, but I've explained more or less how to do it here:
http://groups.google.com/group/cocoslive-discuss/browse_thread/thread/c83bc067fdb77db6/2416bafd160b3bc9?lnk=gst&q=SetScore#2416bafd160b3bc9
If you could fix it, I'll be happy to apply the patch to the server.
Thnks riq, I looked at the code and I emailed you what I think, but it seems to be too easy of a fix.
To Everyone Else:
Is anyone else interested in working on the cocoslive score deletion for when ranking is enabled? If so, please look at line 787 and on for user.py http://code.google.com/p/cocoslive/source/browse/trunk/cocoslive/user.py#787 .
My thoughts are to uncomment the ranker deletion code SetScore(name,none) in the delete_score_transac method and just add a condition statement before it to check whether ranking is enabled. So then in the delete_score method we would directly call the delete_score_transac without any of those conditional statements.
Of course that seems to be too easy. I'm very new to Python, so I'll be interested in discussing this with anyone.
If rankings are enabled, then 2 things should happen:
- you need to delete the score from the DB (like when no rankings are enabled)
- you need to delete the score from the Rankings (using SetScore() )
The thing is that these 2 operations run a in transaction. For the moment GAE doesn't support nested transactions. It would be excellent to support exceptions in any of these transactions. This is not easy to implement, but it's not that difficult either.
How to implement multiple transactions with a fail support:
http://groups.google.com/group/google-app-engine-ranklist/browse_thread/thread/36ecaa495b6c3413
But going back to the 'delete score', the code should look like this:
users.py. line 806:
if score:
self.delete_score_transac( score, game, score_country )
if game.ranking_enabled:
profile_id = self.obtain_profile_id() # XXX implement this method. profile_id = device_id + cc_playername
ranker = self.get_ranker( self.game.key(), self.category )
ranker.SetScore( profile_id, None )
else:
raise Exception('EditScores: Score not not found')Hi riq,
I understand that score from the DB and Ranker needs to be deleted. However, I have a very limited knowledge on both Python and Databases, so I am still on Google figuring things out. I saw the link you gave, but it seems like if we want to implement that, we have to make some major changes to the code...
From what I can understand, the score deletion from the DB is a transaction, and the score deletion from the Ranker (by setScore(None)) is another transaction. And if the score deletion of the Ranker fail, we need to reverse the steps we've done to the DB score delete transaction, is that right?
If that is so, why don't we just run the transaction to delete score from the ranker first? If it does fail, then the score won't be deleted from the DB, which nothing will be changed and the user can try again. If it does succeed, then we will proceed to run the transaction to delete the score from the DB. If the DB transaction fails, nothing will be changed to the DB and CocosLive (besides the Ranker), so the user can have another chance to retry to delete the score again. Trying to delete again from the Ranker won't do anything harmful since if that score is gone, then it won't do anything.
To fill in what you posted:
user.py, line 806:
if score:
if game.ranking_enabled:
profile_id = "%s@%s" % (score.cc_playername, score.cc_device_id) #NOTE: this is the implementation to get profile ID in api.py
ranker = self.get_ranker( self.game.key(), self.category )
ranker.SetScore( profile_id, None )
self.delete_score_transac( score, game, score_country ) #Delete score from DB after score is deleted from Ranker
else:
raise Exception('EditScores: Score not not found')Sorry if I am way off, still got a lot to learn from this..
@edisonlabs: I'll try your patch tomorrow. I think your patch adds deletion to rankings.
thanks.
NP, I'll be very happy if that actually works :)
Hi,
delete scores from rankings are working now. thanks for the patch.
YESSSSSSSSSSSSS! Thanks so much riq!!!
You must log in to post.