Hi, newb here with a problem(IntroScene)

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

Hi, newb here with a problem(IntroScene)

(19 posts) (4 voices)

Started 2 years ago by Greenkirby21
Latest reply from Greenkirby21

Tags:

Greenkirby21
Member

Hey guys, I am new here! I am 18, and just started making games for iPhone with 2 years of java under my belt! Cocos2d is really great, and has helped me learn about about making iPhone games! I have a error >_> .Don't flame me! I read before making this post and searched! Basically I have the menu for my game working, and now I am trying to do an introduction scene via a "slideshow". I am basically putting up images, and as soon as the image is touched, the next image is shown(or at least thats what the tutorial is trying to show me!). I am using the tutorial from

http://lethain.com/entry/2008/oct/29/creating-slideshows-with-cocos2d-iphone/

So, I have one small error that I have no clue what it means!
Here is my code.

#import "SimpleGameAppDelegate.h"
#import <UIKit/UIKit.h>
#import "cocos2d.h"
#import "MenuScene.h"
#import "IntroScene.h"
#import "GameScene.h"

@implementation SimpleGameAppDelegate

- (void)applicationDidFinishLaunching:(UIApplication *)application {
UIWindow *window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];
[window setUserInteractionEnabled:YES];
[window setMultipleTouchEnabled:YES];
[[Director sharedDirector] setLandscape: YES];
[[Director sharedDirector] attachInWindow:window];

[window makeKeyAndVisible];

IntroScene * intro = [IntroScene node];
// Initialize scene and slide show layer.

IntroLayer *layer1 = [IntroLayer node];

// Set positions for the background.
// Generally you'll be using full screen backgrounds
// (screenshots), and positioning them at the center.
[layer1 setBackgroundXPosition:100];
[layer1 setBackgroundYPosition:100];;

// Add slides in order they appear.
[layer1 addSlideWithBackground:@"pic1.png"];
[layer1 addSlideWithBackground:@"pic2.png"];
[layer1 addSlideWithBackground:@"pic3.png"];
[layer1 addSlideWithBackground:@"pic4.png"];
[layer1 addSlideWithBackground:@"pic5.png"];
[layer1 addSlideWithBackground:@"pic6.png"];

// Start and display the slide show.
[layer1 displayFirstSlide];
[IntroScene add:layer1];
[[Director sharedDirector] pushScene:intro];
//[[Director sharedDirector] runWithScene:intro];
}

IntroScene.h

#import <Foundation/Foundation.h>
#import <UIKit/UIKit.h>
#import "CocosNode.h"
#import "Layer.h"
#import "Label.h"
#import "Sprite.h"

@interface IntroScene : Scene {}
@end

@interface IntroLayer : Layer {
int slidePosition;
int backgroundXPosition;
int backgroundYPosition;
NSMutableArray * backgrounds;
Sprite * background;
}

/*
* This is the only method for adding slides to the slide show.
*/
-(void)addSlideWithBackground: (NSString *)imageString;
/*
* Methods for advancing, retreating, and starting the slideshow.
* There currently isn't a UI mechanism for retreating to already
* seen slides, but you could rig something up if you tried hard
* enough. ;)
*/
-(void)displayFirstSlide;
-(void)displayNextSlide;
-(void)displayPreviousSlide;
-(void)displaySlide: (int)slideNumber;
-(BOOL)hasPreviousSlide;
-(BOOL)hasNextSlide;

/*
* Mutators and Accessors
*/
-(NSMutableArray *)backgrounds;
-(Sprite *)background;
-(void)setBackground: (Sprite *)aSprite;
-(int)slidePosition;
-(void)setSlidePosition: (int)anInt;
-(int)backgroundXPosition;
-(void)setBackgroundXPosition: (int)anInt;
-(int)backgroundYPosition;
-(void)setBackgroundYPosition: (int)anInt;
@end

IntroScene.m
#import "SimpleGameAppDelegate.h"
#import <UIKit/UIKit.h>
#import "cocos2d.h"
#import "MenuScene.h"
#import "IntroScene.h"
#import "GameScene.h"

@implementation IntroScene
- (id) init {/*
self = [super init];
if (self != nil) {
Sprite * bg = [Sprite spriteWithFile:@"pic1.png"];
[bg setPosition:ccp(240, 160)];
[self addChild:bg z:0];
[self addChild:[IntroLayer node] z:1];

}
return self;*/
}
@end

@implementation IntroLayer
- (id) init {
self = [super init];
if (self != nil ) {
isTouchEnabled = YES;
slidePosition = -1;
backgrounds = [[NSMutableArray alloc] init];
/*[MenuItemFont setFontSize:20];
[MenuItemFont setFontName:@"Helvetica"];
MenuItem *skip = [MenuItemFont itemFromString:@"Help" target:self selector:@selector(skip:)];
Menu *menu = [Menu menuWithItems:skip, nil];
[menu alignItemsVertically];
[self addChild:menu];*/

}
return self;
}
/*-(void)skip: (id)sender {
MenuScene *gs = [MenuScene node];
[[Director sharedDirector] replaceScene:gs];
}*/
- (void) dealloc {
[backgrounds release];
backgrounds = nil;
[background release];
background = nil;
[super dealloc];
}

-(void)touchesEnded:(NSSet *)touches withEvent:(UIEvent *)event {
/*
* We are using pushScene/popScene instead of replaceScene
* (which has superior memory usage characteristics), because
* it makes integrating SlideShowLayer much simpler, and helps
* avoid binding the code to one application without requiring
* us to use the delegate pattern.
*/
if ([self hasNextSlide]) [self displayNextSlide];
else [[Director sharedDirector] popScene];
}

-(void)addSlideWithBackground: (NSString *)imageString{
[[self backgrounds] addObject:imageString];
}

-(void)displayFirstSlide {
if ([[self backgrounds] count] > 0) {
[self setSlidePosition:0];
[self displaySlide:[self slidePosition]];
}
}

-(void)displayNextSlide {
if ([self hasNextSlide]) {
[self setSlidePosition:[self slidePosition]+1];
[self displaySlide:[self slidePosition]];
}
}

-(void)displayPreviousSlide {
if ([self hasPreviousSlide]) {
[self setSlidePosition:[self slidePosition]-1];
[self displaySlide:[self slidePosition]];
}
}

-(void)displaySlide: (int)slideNumber {
/*
* Remove existing slide and description.
*/
if ([self background]) {
[self remove:[self background]];
}
/*
* Retrieve and generate necessary details for next slide.
*/
NSString * bgString = [[self backgrounds] objectAtIndex:slideNumber];
Sprite * bg = [Sprite spriteWithFile:bgString];
bg.position = cpv([self backgroundXPosition], [self backgroundYPosition]);

// Add the background and desc to the layer.
[self setBackground:bg];
[self add:bg];
}

-(BOOL)hasNextSlide {
return ([self slidePosition]+1 < [[self backgrounds] count]);
}

-(BOOL)hasPreviousSlide {
return ([self slidePosition] > 0);
}

-(Sprite *)background {
return background;
}
-(void)setBackground: (Sprite *)aSprite {
if (background) [background release];
background = [aSprite retain];
}

-(NSMutableArray *)backgrounds {
return backgrounds;
}

-(int)slidePosition {
return slidePosition;
}

-(void)setSlidePosition: (int)anInt {
slidePosition = anInt;
}

-(int)backgroundXPosition {
return backgroundXPosition;
}

-(void)setBackgroundXPosition: (int)anInt {
backgroundXPosition = anInt;
}

-(int)backgroundYPosition {
return backgroundYPosition;
}

-(void)setBackgroundYPosition: (int)anInt {
backgroundYPosition = anInt;
}

@end

The error I get is from introScene.m in the displaySlide method

NSString * bgString = [[self backgrounds] objectAtIndex:slideNumber];
Sprite * bg = [Sprite spriteWithFile:bgString];
bg.position = cpv([self backgroundXPosition], [self backgroundYPosition]);

On the last line, I get error:incompatible type for first position!
I tried changing things, but it is not working! Please help! Thanks! Once again, sorry if my code is miserable and lousy. I am just learning ._.!

Posted 2 years ago #
Codemattic
Moderator

Hey Greenkirby21,

Your code looks pretty good, welcome to cocos! Can you upload your project (or make a new small project with the error) somewhere? If so Ill download it and take a look.

What version of cocos are you using? If this is a newish project maybe use v0.8

You are using cpv which is a chipmunk vector, have you included the chipmunk sources? You may need to.

Try:
bg.position = cpv(1, 1); //test

If that gives you an error too, then maybe something is wrong with your chipmunk installation. BTW - the newer cocos releases dont have the same dependency on chipmunk vectors.

anyway, hth, Codemattic

Posted 2 years ago #
Clain
Member

You should use ccp for everything cocos. So try replacing your cpv(x, y) with ccp(x, y). You can also take a look at the CGPointExtension.h file in the cocos2d/Support directory.

Posted 2 years ago #
Codemattic
Moderator

yes - if you are using a recent version of cocos, go with ccp instead.

Posted 2 years ago #
Greenkirby21
Member

alright guys thanks! So I changed it to coco v.8, and used ccp instead of cvp, and it compiles and build. However, when I hit build, it just displays a black screen! I don't know why! If anyone else could help me, that would be of great help!

http://www.megaupload.com/?d=K2UUFE5U

theres the file, if you want it uploaded to something else just tell me.
Now remember, I am just learning how to use cocos2d, this is not my game or anyone elses, I am just experimenting xD.

Thank you so much!

Posted 2 years ago #
gnomesgames
Member

So, i found part of the problem i think, i can see the menu, and go to "game", where i see the game over picture, but other button lead nowhere.

So in SimpleGameAppDelegate.m at line 49:
Replace the line with : [intro addChild:layer1];
(You tried to add an object to the class itself, which is not possible)

And then in IntroScene.m at line 110 :
Replace [self add:bg]; by [self addChild:bg];
(add is deprecated, now it's addChild to add child to the object)

When you try to solve crash like this, it's help a lot to look at the console (when your prog is running, the little black square at the top of your code window), it tells you if there is problem like an object that don't respond to a method, or things like this :).

Good luck ;) !

Posted 2 years ago #
Greenkirby21
Member

hehe thanks! So, I changed what you told me, and now it just crashes the phone on start up xD. basically, i want it to run like this,

intro>menu>game.

i havent implemented the other buttons in the menu because I haven't gotten it working yet! lol. So, anytime i use add now, i need to use addchild instead, what about remove? is it the same thing?

Posted 2 years ago #
gnomesgames
Member

Same thing but with on more thing :
[self removeChild:<#(CocosNode *)node#> cleanup:<#(BOOL)cleanup#>];

<#(CocosNode *)node#> : The child you want to remove
<#(BOOL)cleanup#> : I think it's :
TRUE : release the child from memory
FALSE : kept it in memory (you can add it to another scene)

There is a useful thing in XCode, when you don't know what you can do with an object, XCode can tell it for you, just type :
[myObject

And when you are here, press alt+escape, there is a list of all method available for this object :), just type the first letters to get a filtered list. For exemple for a scene if you type :
[myScene rem
Then you will have : removeChild, removeChildByTag etc...
It work the same way for attributes :) !

Posted 2 years ago #
Greenkirby21
Member

thanks. i still seem to be getting an error with just this method(console says it is causing the crash)

[Session started at 2009-07-04 12:41:19 -0500.]
SimpleGame(7560,0xa0402720) malloc: *** error for object 0x107da0c: Non-aligned pointer being freed
*** set a breakpoint in malloc_error_break to debug

Posted 2 years ago #
gnomesgames
Member

Hum... Don't know what you are doing wrong :s... Does it show something at the top of the code after the crash ? Sometimes there is a text where you can click to access the list of actions made just before the crash, and if you click on it, you access the part of the code witch cause the crash.
If there is nothing, you can try re-up, and i will look again for you :)

Posted 2 years ago #
Greenkirby21
Member

well, when i go to there, it shows me the code for the displayslide method. I meant to post it in the last post >_>. guess i forgot xD

I reuploaded what I currently have

http://www.megaupload.com/?d=OJ6V060R

thank you so much! your really kind!

Posted 2 years ago #
gnomesgames
Member

So, you wants to show the tutorial (IntroScene) before or after the menu ?

Posted 2 years ago #
Greenkirby21
Member

before the menu. I am going to add a skip button later so people can skip the game intro and go straight to the menu

Posted 2 years ago #
gnomesgames
Member

Ok, i will try to do that ^^

Posted 2 years ago #
gnomesgames
Member

So, this version work as you want, i commented it, tell me if there is something that you don't understand for some reasons
http://dl.free.fr/qGo5gRA0J

Posted 2 years ago #
Greenkirby21
Member

alight thanks a lot ^^. your the best

Posted 2 years ago #
gnomesgames
Member

You are welcome :), everybody have to learn :)

Posted 2 years ago #
Greenkirby21
Member

So, didn't wanna create a new thread because this problem is pretty noob too. please bare with me! I almost get it! So basically, I have 2 images in my menu(aside from the buttons I will create later). One spins around, while the other follows wherever the user pressed. The spinning image works, but the tapping does not. The sprite(in this case gurl), is not moving to where the finger was tapped, in fact, it is being static. Please help!

//
// cocos2d Hello Actions example
// http://www.cocos2d-iphone.org
//

// IMPORTANT:
// This example ONLY shows the basic steps to render a label on the screen.
// Some advanced options regarding the initialization were removed to simplify the sample.
// Once you understand this example, read "HelloActions" sample.
// Needed for UIWindow, NSAutoReleasePool, and other objects
#import <UIKit/UIKit.h>
#import "MenuScene.h"
//Implementation
@implementation MenuScene
@synthesize window;

enum {
kTagSprite = 2,
};

// on "init" you need to initialize your instance
-(id) init
{
// always call "super" init
// Apple recommends to re-assign "self" with the "super" return value
if( (self=[super init] )) {

// create and initialize a Label
Label *label = [Label labelWithString:@"Begin Adventure" fontName:@"Marker Felt" fontSize:20 ];
// ask director the the window size
CGSize size = [[Director sharedDirector] winSize];

// position the label on the center of the screen
// "ccp" is a helper macro that creates a point. It means: "CoCos Point"
label.position = ccp( size.width /2 , size.height/2 );
// add the label as a child to this Layer
[self addChild: label z:1];

// objective-c can be an static or dynamic language.
// "id" is a reserved word that means "this is an object, but I don't care it's type"
// scales the label 2.5x in 3 seconds.
id growAction = [ScaleBy actionWithDuration:3.0f scale:2.5f];
id shrinkAction = [ScaleBy actionWithDuration:3.0f scale:.4f];

// tell the "label" to run the action.The action will be execute once this Layer appears on the screen (not before).
[label runAction:growAction];

//
// Sprites
//
Sprite *back = [Sprite spriteWithFile:@"background.png"];
back.position = ccp(240,160);
Sprite *imagelol = [Sprite spriteWithFile:@"alf.png"];
imagelol.position = ccp(100, 100);
Sprite *gurl = [Sprite spriteWithFile:@"gurl.png"];
gurl.position = ccp(200, 200);

// z is the z-order. Greater values means on top of lower values.
// default z value is 0.
// So the sprite will be on top of the label.
[self addChild:back z:0];
[self addChild:imagelol z:2];
[self addChild:gurl z:2 tag:kTagSprite];
[self addChild:[MenuLayer node] z:2];

// create a RotateBy action.
// "By" means relative. "To" means absolute.
id rotateAction = [RotateBy actionWithDuration:4 angle:180*4];

// create a JumpBy action.
id jumpAction = [JumpBy actionWithDuration:4 position:ccp(100,0) height:100 jumps:4];

// spawn is an action that executes 2 or more actions at the same time
id fordward = [Spawn actions:rotateAction, jumpAction, nil];

// almost all actions supports the "reverse" method.
// It will create a new actions that is the reversed action.
id backwards = [fordward reverse];

// Sequence is an action that executes one action after another one
id sequence = [Sequence actions: fordward, backwards, growAction, shrinkAction, nil];

// Finally, you can repeat an action as many times as you want.
// You can repeat an action forever using the "RepeatForEver" action.
id repeat = [RepeatForever actionWithAction:sequence];

// Tell the sprite to execute the actions.
// The action will be execute once this Layer appears on the screen (not before).
[imagelol runAction:repeat];
}
return self;
}

// on "dealloc" you need to release all your retained objects
- (void) dealloc
{
// in case you have something to dealloc, do it in this method
// in this particular example nothing needs to be released.
// cocos2d will automatically release all the children (Label)

// don't forget to call "super dealloc"
[super dealloc];
}

@end

@implementation MenuLayer
- (id) init {
if( (self=[super init] )) {
self.isTouchEnabled = YES;
}
return self;
}

// This callback will be called because 'isTouchesEnabled' is YES.
// Possible events:
// * ccTouchesBegan
// * ccTouchesMoved
// * ccTouchesEnded
// * cctouchesCancelled
- (BOOL)ccTouchesEnded:(NSSet *)touches withEvent:(UIEvent *)event
{
UITouch *touch = [touches anyObject];

if( touch ) {
CGPoint location = [touch locationInView: [touch view]];

// IMPORTANT:
// The touches are always in "portrait" coordinates. You need to convert them to your current orientation
CGPoint convertedPoint = [[Director sharedDirector] convertCoordinate:location];

CocosNode *sprite = [self getChildByTag:kTagSprite];

// we stop the all running actions
[sprite stopAllActions];

// and we run a new action
[sprite runAction: [MoveTo actionWithDuration:1 position:convertedPoint]];

// no other handlers will receive this event
return kEventHandled;
}

// we ignore the event. Other receivers will receive this event.
return kEventIgnored;
}

@end

Posted 2 years ago #
Greenkirby21
Member

wow okay! I got this hehehe. I needed to put my sprite into the layer!

Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.