Animation isnt working « cocos2d for iPhone

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

Animation isnt working

(11 posts) (3 voices)

Started 2 years ago by martin.knotek
Latest reply from martin.knotek

Tags:

No tags yet.

martin.knotek
Member

hi, im trying create animation in cocos2d example project Chipmunk application:

-(void) addNewSpriteX: (float)x y:(float)y
{
	int posx, posy;

	CCSpriteSheet *sheet = (CCSpriteSheet*) [self getChildByTag:kTagAtlasSpriteSheet];

	posx = (CCRANDOM_0_1() * 200);
	posy = (CCRANDOM_0_1() * 200);

	posx = (posx % 4) * 85;
	posy = (posy % 3) * 121;

	CCSprite *sprite = [sheet createSpriteWithRect:CGRectMake(posx, posy, 85, 121)];
	[sheet addChild: sprite];

	sprite.position = ccp(x,y);

	int num = 4;
	CGPoint verts[] = {
		ccp(-24,-54),
		ccp(-24, 54),
		ccp( 24, 54),
		ccp( 24,-54),
	};

	cpBody *body = cpBodyNew(1.0f, cpMomentForPoly(1.0f, num, verts, CGPointZero));

	// TIP:
	// since v0.7.1 you can assign CGPoint to chipmunk instead of cpVect.
	// cpVect == CGPoint
	body->p = ccp(x, y);
	cpSpaceAddBody(space, body);

	cpShape* shape = cpPolyShapeNew(body, num, verts, CGPointZero);
	shape->e = 0.5f; shape->u = 0.5f;
	shape->data = sprite;
	cpSpaceAddShape(space, shape);

}

im trying put this code:

CGPoint point = ccp(5,5);
	CCAction * actionBy = (CCAction *) [CCRepeatForever actionWithAction: [CCMoveBy actionWithDuration:0.1 position:point]];

	[sprite runAction:actionBy];

But without success, any idea why? Sprite isn't moving.

Posted 2 years ago #

gaminghorror
Member
Maybe try it with a simpler approach first:
```
[sprite runAction:[CCMoveBy actionWithDuration:10 position:point]];
```
Maybe the CCRepeatForever with the short interval of 0.1f just doesn't work? I'm just guessing.
Posted 2 years ago #
crmagicxxx
Member

It's not the problem with action, but with trying to run an action on sprite that's already bound to Chipmunk simulation. So in every step Chipmunk set sprite's position/rotation, that's why action wouldn't work on that node... (actually, action works, but you can't see results)

@martin.knotek
Analyze little more how Chipmunk works, and what it does in every step, and how it iterates every shape/body through each step, and you'll understand why your actions aren't working on those nodes...

Posted 2 years ago #
martin.knotek
Member

Could you pls give some url with direct point? Icant find what do you mean

Posted 2 years ago #
crmagicxxx
Member

I don't have any url, just analyze your code and you'll see what's happening. Anyway, the code you posted already isn't the problematic one. As you can see you assigned your sprite to shape->data which is important later. Post your step: or tick: method, and your c function that's called from that step (usually eachShape) and I'll try to explain you better...

Posted 2 years ago #

martin.knotek
Member

-(void) step: (ccTime) delta
{
	int steps = 2;
	CGFloat dt = delta/(CGFloat)steps;

	for(int i=0; i<steps; i++){
		cpSpaceStep(space, dt);
	}
	cpSpaceHashEach(space->activeShapes, &eachShape, nil);
	cpSpaceHashEach(space->staticShapes, &eachShape, nil);
}

Its my first try with chipmunk, im using attached example in cocos2d framework, xcode template for chipmunk

Posted 2 years ago #

martin.knotek
Member

Entire example with my code:

//
// cocos2d Hello World example
// http://www.cocos2d-iphone.org
//

// Import the interfaces
#import "HelloWorldScene.h"

enum {
	kTagAtlasSpriteSheet = 1,
};

static void
eachShape(void *ptr, void* unused)
{
	cpShape *shape = (cpShape*) ptr;
	CCSprite *sprite = shape->data;
	if( sprite ) {
		cpBody *body = shape->body;

		// TIP: cocos2d and chipmunk uses the same struct to store it's position
		// chipmunk uses: cpVect, and cocos2d uses CGPoint but in reality the are the same
		// since v0.7.1 you can mix them if you want.
		[sprite setPosition: body->p];

		[sprite setRotation: (float) CC_RADIANS_TO_DEGREES( -body->a )];
	}
}

// HelloWorld implementation
@implementation HelloWorld

+(id) scene
{
	// 'scene' is an autorelease object.
	CCScene *scene = [CCScene node];

	// 'layer' is an autorelease object.
	HelloWorld *layer = [HelloWorld node];

	// add layer as a child to scene
	[scene addChild: layer];

	// return the scene
	return scene;
}

-(void) addNewSpriteX: (float)x y:(float)y
{
	int posx, posy;

	CCSpriteSheet *sheet = (CCSpriteSheet*) [self getChildByTag:kTagAtlasSpriteSheet];

	posx = (CCRANDOM_0_1() * 200);
	posy = (CCRANDOM_0_1() * 200);

	posx = (posx % 4) * 85;
	posy = (posy % 3) * 121;

	CCSprite *sprite = [sheet createSpriteWithRect:CGRectMake(posx, posy, 85, 121)];
	[sheet addChild: sprite];

	sprite.position = ccp(x,y);

	int num = 4;
	CGPoint verts[] = {
		ccp(-24,-54),
		ccp(-24, 54),
		ccp( 24, 54),
		ccp( 24,-54),
	};

	cpBody *body = cpBodyNew(1.0f, cpMomentForPoly(1.0f, num, verts, CGPointZero));

	// TIP:
	// since v0.7.1 you can assign CGPoint to chipmunk instead of cpVect.
	// cpVect == CGPoint
	body->p = ccp(x, y);
	cpSpaceAddBody(space, body);

	cpShape* shape = cpPolyShapeNew(body, num, verts, CGPointZero);
	shape->e = 1; shape->u = 1;
	shape->data = sprite;
	cpSpaceAddShape(space, shape);

	//my code
	CGPoint point = ccp(5,5);
	CCAction * actionBy = (CCAction *) [CCRepeatForever actionWithAction: [CCMoveBy actionWithDuration:0.1 position:point]];

	[sprite runAction:actionBy];

}
-(id) init
{
	if( (self=[super init])) {

		self.isTouchEnabled = YES;
		self.isAccelerometerEnabled = YES;

		CGSize wins = [[CCDirector sharedDirector] winSize];
		cpInitChipmunk();

		cpBody *staticBody = cpBodyNew(INFINITY, INFINITY);
		space = cpSpaceNew();
		cpSpaceResizeStaticHash(space, 400.0f, 40);
		cpSpaceResizeActiveHash(space, 100, 600);

		space->gravity = ccp(0, 0);
		space->elasticIterations = space->iterations;

		cpShape *shape;

		// bottom
		shape = cpSegmentShapeNew(staticBody, ccp(0,0), ccp(wins.width,0), 0.0f);
		shape->e = 1.0f; shape->u = 1.0f;
		cpSpaceAddStaticShape(space, shape);

		// top
		shape = cpSegmentShapeNew(staticBody, ccp(0,wins.height), ccp(wins.width,wins.height), 0.0f);
		shape->e = 1.0f; shape->u = 1.0f;
		cpSpaceAddStaticShape(space, shape);

		// left
		shape = cpSegmentShapeNew(staticBody, ccp(0,0), ccp(0,wins.height), 0.0f);
		shape->e = 1.0f; shape->u = 1.0f;
		cpSpaceAddStaticShape(space, shape);

		// right
		shape = cpSegmentShapeNew(staticBody, ccp(wins.width,0), ccp(wins.width,wins.height), 0.0f);
		shape->e = 1.0f; shape->u = 1.0f;
		cpSpaceAddStaticShape(space, shape);

		CCSpriteSheet *sheet = [CCSpriteSheet spriteSheetWithFile:@"grossini_dance_atlas.png" capacity:100];
		[self addChild:sheet z:0 tag:kTagAtlasSpriteSheet];

		[self addNewSpriteX: 200 y:200];

		[self schedule: @selector(step:)];
	}

	return self;
}

-(void) onEnter
{
	[super onEnter];

	[[UIAccelerometer sharedAccelerometer] setUpdateInterval:(1.0 / 60)];
}

-(void) step: (ccTime) delta
{
	int steps = 2;
	CGFloat dt = delta/(CGFloat)steps;

	for(int i=0; i<steps; i++){
		cpSpaceStep(space, dt);
	}
	cpSpaceHashEach(space->activeShapes, &eachShape, nil);
	cpSpaceHashEach(space->staticShapes, &eachShape, nil);
}

- (BOOL)ccTouchesEnded:(NSSet *)touches withEvent:(UIEvent *)event
{
	for( UITouch *touch in touches ) {
		CGPoint location = [touch locationInView: [touch view]];

		location = [[CCDirector sharedDirector] convertToGL: location];

		[self addNewSpriteX: location.x y:location.y];
	}
	return kEventHandled;
}

- (void)accelerometer:(UIAccelerometer*)accelerometer didAccelerate:(UIAcceleration*)acceleration
{
	static float prevX=0, prevY=0;

#define kFilterFactor 0.05f

	float accelX = (float) acceleration.x * kFilterFactor + (1- kFilterFactor)*prevX;
	float accelY = (float) acceleration.y * kFilterFactor + (1- kFilterFactor)*prevY;

	prevX = accelX;
	prevY = accelY;

	CGPoint v = ccp( accelX, accelY);

	space->gravity = ccpMult(v, 200);
}
@end

Posted 2 years ago #

martin.knotek
Member

I have added from differed example:

// Updates a shape's visual representation (i.e. sprite)
void updateShape(void *ptr, void* unused) {
	// Get our shape
	cpShape *shape = (cpShape*)ptr;

	// Make sure everything is as expected or tip & exit
	if(shape == nil || shape->body == nil || shape->data == nil) {
		NSLog(@"Unexpected shape please debug here...");
		return;
	}

	// Lastly checks if the object is an UIView of any kind
	// and update its position accordingly
	if([shape->data isKindOfClass:[UIView class]]) {
		[(UIView *)shape->data setCenter:CGPointMake(shape->body->p.x, 480 - shape->body->p.y)];
	}
	else
		NSLog(@"The shape data wasn't updateable using this code.");
}

-(void) step: (ccTime) delta
{
	//int steps = 2;
	//CGFloat dt = delta/(CGFloat)steps;

	//for(int i=0; i<steps; i++){
	//	cpSpaceStep(space, dt);
	//}
	//cpSpaceHashEach(space->activeShapes, &eachShape, nil);
	//cpSpaceHashEach(space->staticShapes, &eachShape, nil);

	// Tell Chipmuck to take another "step" in the simulation
	cpSpaceStep(space, 1.0f/60.0f);

	// Call our function for each shape
	cpSpaceHashEach(space->activeShapes, &updateShape, nil);
}

and its working, thx for tip

Posted 2 years ago #

martin.knotek
Member

Ok sprite is moving, bud i have expected, that, after achievement of window border, will object bounce?

Posted 2 years ago #
crmagicxxx
Member
Listen, the code you posted before was good (title: Entire example with my code)
Now in step: method you don't have to hash your static objects as you're not moving them obviously. So comment this line:
```
cpSpaceHashEach(space->staticShapes, &eachShape, nil);
```
Now, in your main init you scheduled step: and it ticks all the time. In step: you are updating you simulation with cpSpaceStep(space, dt); and also iterating through all active shapes cpSpaceHashEach(space->activeShapes, &eachShape, nil)... and all that is good. Just remove your code from the init method...

Not what cpSpaceHashEach does is calling c function eachShape in every tick to update positions/rotations of your assigned sprites (to shapes)...

Now look static void eachShape(void *ptr, void* unused)
It's called every step and for every shape in your simulation. And what it does? It gets your sprite through the data pointer of the shape and updates its position and rotation. And that happens like 60 times per second...

So the reason your actions doesn't work on your sprite is because that function already sets position/rotation of your sprite. So you run action to e.g. move sprite 100 px right, but then chipmunk simulation sets another position for your sprite. So action and simulation interfere with each other 60 times per second and your action can't be seen.

Simply: you can't do actions that change position/rotation of your sprite that's already included in simulation. You can of course make it run action that changes color, scale, etc, and that will work. But if you scale your sprite it will not reflect actual chipmunk simulation...

I hope you understand better now how chipmunk works. No tutorial can help you better than your experiments with posted code. If you have time though...

Maye it was better if you told us what you wanted to achieve in the first place...
Posted 2 years ago #
martin.knotek
Member

Thx a lot. Now it’s for me update process clear. But, what about physics? With animation aren’t respect borders? Why isn’t image bouncing? After receiving border.

Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.