A fast, easy to use, free, and community supported 2D game engine
napierzaza
Member
I am porting my 0.99 beta 1 code to o.99 RC. Has anyone else noticed that it appears as if sprite.visible is now equal to -1? It appears not to be used anymore considering my sprites are visible on the screen. But I used to use them in my app for different iff statements and now it keeps reading them as -1 instead of +1 (aka YES).
Oh, they're CCSpritesheet sprites
visible is a "bit" in v0.99 and not a byte. Perhaps that the issue, but it should work.
if it doesn't , could you open a bug ? thanks.
These should work
if( visible ) {
// it is visible
}
if( ! visible ) {
// it is not visible
}And these should also work
if (visible == YES)
;
if( visible == NO)
;Hey Riq,
if (visible == YES)really doesn't work for sdk 3.0+ anymore
Just had funny experience with my last project. Everything worked, then I integrated OF and had to change to SDK 3.1.2 and my game started to behave strange. I traced it to this snippet where I constantly check node's visibility with node.visible == YES.
This still works:
if( node.visible )What was the purpose of changing booleans to bits anyway? Just saving some memory?
Edit: Eh, just saw there is an issue already for this:
http://code.google.com/p/cocos2d-iphone/issues/detail?id=743
Can this issue go as urgent because I am not sure I can find all stuff in my code where I check something against "YES"? And is only visibility affected by this or there are other boolean properties included?
crmagicxxx: yes, it was for saving memory, but if visible == YES doesn't work:
- I will try to fix it
- And if I can't fix it, I'll rollback the change.
@Riq
Thanks for fast response. I am really at deadline and not sure I can trace all the things now to simply check if visibility is greater than zero...
Btw, is really only visibility affected, or maybe other boolean properties also?
@crmagicxxx:
see CCNode.h and see the CC_BOOL_IS_BIT macro.
OK, see it now.
So there are other properties affected as isRunning_, relativeAnchorPoint_, ... But as long as we don't use those properties I think we are safe, because as I could trace in cocos2d code you nowhere checked something against "YES", always simple if ( isRunning_ ) for example...
Anyway, I think that byte to bit change should be rolled back if it's not safe. I really doubt that memory saving is so significant. Or I am wrong?
You must log in to post.