Is it the Correct Way to use NSAutoreleasePool? Memory Management Question :D

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

Is it the Correct Way to use NSAutoreleasePool? Memory Management Question :D

(4 posts) (3 voices)

Started 2 years ago by privateson
Latest reply from privateson

Tags:

memory management

privateson
Member

Hi, this is the Code I write to read the sprite sheet and generate Animation.
Am I doing the right thing in terms of Memory Management?
Is it the right way to use NSAutoreleasePool?
Right now, I am puting NSAutoreleasePool in each if statement...

if(movingSpriteSheetFileName != nil && movingSpriteSheetFileName != @"")
	{
		NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];

		NSString* plistPath = [[NSBundle mainBundle] pathForResource:movingSpriteSheetFileName ofType:@""];
		NSDictionary *plistDictionary = [NSDictionary dictionaryWithContentsOfFile:plistPath];		

		NSArray* keysArray = [plistDictionary allKeys];

		..................................

	//	[animation release];
		//[plistPath release];
	//	[plistDictionary release];
//		[keysArray release];

		[pool release];
	}

By the way,
Why I can't call
[plistPath release];
[plistDictionary release];
[keysArray release];
At the end of the If Statement?
It kind of crashes if I do so..

Thanks for answering.

Posted 2 years ago #

Codemattic
Moderator

unless this code is inside of a very big loop you do not need to create your own NSAutoreleasePool here. You very rarely have to create your own pool. You dont send a -release to those objects bc they were created by convenience constructors which return the new object autoreleased.

Also - when pasting in code, put backticks ` on the line before and after the code so it gets formatted correctly.

Posted 2 years ago #
CJ
Moderator

First, like Codemattic said, you probably don't need to create the Autorelease Pool for this code because it's not an intensive loop.
Second, you don't actually alloc, or retain any objects here so you don't need to call release on anything either.

I suggest you read up again on memory management in a reference counted system, but the short summary is this...

If you do any of the following, you must balance the call with a corresponding autorelease or release.

- alloc
- retain
- ...New...

Things you certainly do not need to call release on are objects obtained from Class convenience methods like:

- [NSString stringWithFormat:....];
- [NSArray arrayWith.....];

Posted 2 years ago #
privateson
Member

THank you so much! :D

Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.