subclassing atlasSprite - confusion with manager / layer communication

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

subclassing atlasSprite - confusion with manager / layer communication

(9 posts) (4 voices)

Started 2 years ago by jonathan0382
Latest reply from Karl

Tags:

jonathan0382
Member
Hi,

I have a question concerning layer-subclassed atlasSprite communication which I think just stems from a lack of experience with obj-C. In my gameLayer I have:
```
enemySpriteMgr = [AtlasSpriteManager spriteManagerWithFile:@"enemy1_spritesheet_cutout.png" capacity:480];
		Enemies1 = [[NSMutableArray alloc] initWithCapacity:kNumberOfEnemies1];
		for(int n=0; n<kNumberOfEnemies1; n++){
			EnemyType1 *b = [[[EnemyType1 alloc] init] autorelease];
			[Enemies1 addObject: b];
			[b release];
		}
```
Inside of the EnemyType1 I have initWithRec which requires the atlasSprite manager, but I'm having difficulty referencing the enemySpriteMgr from the gameLayer so I can add the atlasSprite to it. I've previously used code like [(layer*)[self.parent getChildByTag:#]... but this doesn't work as the atlasSprite manager is not the parent until after the atlasSprite is initiated.

I hope this makes sense. If not I can try to clarify. Thank you in advance for your help.

Jonathan0382
Posted 2 years ago #
Codemattic
Moderator

"Inside of the EnemyType1 I have initWithRec which requires the atlasSprite manager"

yes, but you are calling -init, not -initWithRec

Posted 2 years ago #

jonathan0382
Member

RIght, but in my subclassed atlasSprite I have:

-(id) init
{
	self = [super init];
	if (self)
	{
		NSLog(@"init called");
		enemySpriteMgr = ? need to get reference to atlasSprite manager in GameLayer here. How?
		[self initWithRect:CGRectMake(2*16, 0*13, 16, 14) spriteManager:enemySpriteMgr];
		[enemySpriteMgr addChild:self];
etc

So although I am calling init I am initWithRec'ing within the init. Perhaps I am not doing this the most efficient way.

Any thoughts, or suggestions about doing it this way?

The other way is to call initWithRect in my GameLayer like this:

enemySpriteMgr = [AtlasSpriteManager spriteManagerWithFile:@"spritesheet_cutout.png" capacity:480];
		[self addChild:enemySpriteMgr];
		Enemies1 = [[NSMutableArray alloc] initWithCapacity:kNumberOfEnemies1];
		for(int n=0; n<kNumberOfEnemies1; n++){
			EnemySprite1 *b = [[[EnemySprite1 alloc] initWithRect:CGRectMake(2*16, 0*13, 16, 14) spriteManager:enemySpriteMgr] autorelease];
			[Enemies1 addObject: b];
			[b release];
		}

and then in the EnemySprite1 do this:

-(id) initWithRect:(CGRect)rect spriteManager:(AtlasSpriteManager*)manager
{
	self = [super init];
	if (self)
	{
		NSLog(@"init called");

		runDown = [AtlasAnimation animationWithName:@"runDown" delay:0.15f];
		[runDown addFrameWithRect: CGRectMake(0*16, 0*14, 16, 13) ];
		[runDown addFrameWithRect: CGRectMake(1*16, 0*14, 16, 13) ];
		[runDown addFrameWithRect: CGRectMake(2*16, 0*14, 16, 13) ];
		[runDown addFrameWithRect: CGRectMake(1*16, 0*14, 16, 13) ];

		runDownAction = [Animate actionWithAnimation: runDown restoreOriginalFrame:NO];
		[runDownAction retain];
		runDownForever = [RepeatForever actionWithAction:runDownAction];
		[runDownForever retain];

//other animations, properties etc defined here

		[manager addChild:self];
	}
	return self;
}

This compiles and I know the enemies are there and moving around, and I am able to interact with them, but they are invisible, so I'm doing something wrong with the texture of the spriteManager.

Posted 2 years ago #

Codemattic
Moderator

you should rework that first -init method so it doesnt initialize itself twice. Not sure if thats *the* bug, but its *a* bug.

Posted 2 years ago #

jonathan0382
Member

Oh yeah, you're right. Sorry for including that. I'd already spotted and changed it, so I pasted the wrong code. Basically the init within the init goes around and around, and crashes.

Any thoughts on the invisible atlasSprites in the second way of doing it? Am I passing the sprite manager correctly? This is what I'm doing:

In my GameLayer:

enemySpriteMgr = [AtlasSpriteManager spriteManagerWithFile:@"spritesheet_cutout.png" capacity:480];
		[self addChild:enemySpriteMgr];
		Enemies1 = [[NSMutableArray alloc] initWithCapacity:kNumberOfEnemies1];
		for(int n=0; n<kNumberOfEnemies1; n++){
			EnemySprite1 *b = [[[EnemySprite1 alloc] initWithRect:CGRectMake(2*16, 0*13, 16, 14) spriteManager:enemySpriteMgr] autorelease];
			[Enemies1 addObject: b];
			[b release];
		}

and then in the EnemySprite1 do this:

-(id) initWithRect:(CGRect)rect spriteManager:(AtlasSpriteManager*)manager
{
	self = [super init];
	if (self)
	{
		NSLog(@"init called");

		runDown = [AtlasAnimation animationWithName:@"runDown" delay:0.15f];
		[runDown addFrameWithRect: CGRectMake(0*16, 0*14, 16, 13) ];
		[runDown addFrameWithRect: CGRectMake(1*16, 0*14, 16, 13) ];
		[runDown addFrameWithRect: CGRectMake(2*16, 0*14, 16, 13) ];
		[runDown addFrameWithRect: CGRectMake(1*16, 0*14, 16, 13) ];

		runDownAction = [Animate actionWithAnimation: runDown restoreOriginalFrame:NO];
		[runDownAction retain];
		runDownForever = [RepeatForever actionWithAction:runDownAction];
		[runDownForever retain];

//other animations, properties etc defined here

		[manager addChild:self];
	}
	return self;
}

I must be messing up the passing of the spriteManager, because all animations are blank - the sprite is invisble. That said, the sprites are there, so they are being added to the manager. I'm confused.

Thanks,

Jonathan0382

Posted 2 years ago #

jonathan0382
Member

So, it seems that although atlasAnimations can be defined within a subclassed atlasSprite, when you call them they show as having no texture. Is there a way of easily encapsulating an atlasAnimation inside a subclassed atlasSprite, or should I stick to defining them where the spriteManager is defined?

Question: what would the performance negatives be to having each subclassed atlasSprite having its own atlasSprite manager defined within it? Would it be much slower?

Thanks,

jonathan0382

Posted 2 years ago #
riq
Key Master

If each AtlasSprite has it's own AtlasSpriteManager (on manager per sprite) then the rendering will be as fast as using normal Sprites (slow rendering)

ApriteSprite works best when you render multiple AtlasSprites at the time using just 1 AtlasSpriteManager

Posted 2 years ago #
jonathan0382
Member

@riq: thanks for the confirmation. That was what I expected.

Has anyone else run into problems with the texture not displaying when defining atlasAnimations inside a atlasSprite? If so, how did you work around it? Did you just define them all where the atlasSpriteManager is defined? I would love to be able to keep all of my atlasAnimations inside of the subclassed atlasSprite, if for no other reason than cleaner code...

Thanks,

Jonathan0382

Posted 2 years ago #
Karl
Member

Actually, you could avoid all of these headaches by using composition instead of inheritance.

Make an EnemyManager class:

@interface EnemyManager : NSObject
{
AtlasSpriteManager* myManager;
NSMutableArray* allEnemies;
}
- (void) setParent:(CocosNode*) parent;
- (Enemy*) addEnemyToScene;
- (void) removeEnemyFromScene:(Enemy*) enemy;
- (void) updateEnemies:(ccTime)deltaTime;

And an Enemy class:

@interface Enemy : NSObject
{
AtlasSprite* mySprite;
CGRect collisionBox;
int state;
}
- (void) moveTo:(CGPoint) location duration:(ccTime) duration;
- (void) updateStateMachine:(ccTime) deltaTime;
- (bool) checkCollision:(Player*) player;

Use delegation for position and other things that the sprite holds.

That sort of thing. Enemies are not sprites. Sprites are a part of the enemy (the visible part), but enemies are so much more.

Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.