how to remove a overlapped sprite.

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

how to remove a overlapped sprite.

(12 posts) (6 voices)

Started 4 months ago by phantomsri
Latest reply from elsevero

Tags:

phantomsri
Member

Hi need help,
I have 3 sprites overlapped, with tag 1 to 3. How i can remove multiple overlapped sprite in a single touch?
I have a loop code below to remove sprite based on tag, its not working. All im getting is that i need to click the same spot 3 times to remove the 3 sprites.

-(void)ccTouchesBegan:(NSSet *)touches withEvent:(UIEvent *)event
{
    UITouch* myTouch = [touches anyObject];
    CGPoint location = [myTouch locationInView: [myTouch view]];
    location = [[CCDirector sharedDirector]convertToGL:location];
    location = [self convertToNodeSpace:location];

    int totalNumberOfItems=4;
    for (int y=0; y < totalNumberOfItems; y++){
        CCSprite *temp = (CCSprite*)[self getChildByTag:y];

        CGRect test1 = [temp boundingBox];

        if (CGRectContainsPoint(test1, location)) {
            NSLog(@"touched");
            [self removeChild:temp cleanup:YES ];
            return;
        }
    }  

}

Posted 4 months ago #

shefyg
Member

Why do you use return? If you will continue looping I think it would remove all of them

Posted 4 months ago #
kalpanasingh
Member

I am also unable to understand this what you want to ask ?

Posted 4 months ago #
phantomsri
Member

thanks @shefyg i never realize i made a mistake by using the return code.
After removal it works. Im still learning this cocos2d. thanks again

Posted 4 months ago #
shefyg
Member

No problem - glad I could help

Posted 4 months ago #

elsevero
Member

@phantomsri: How did you manage to remove overlapped sprites?

I was thinking to use Ray's tutorial example (http://www.raywenderlich.com/2343/how-to-drag-and-drop-sprites-with-cocos2d) and adjust it, but I have some issues with the overlapped sprites; The issue is that I can't remove the objects that are place below the first sprite.

Here's the code which I'm using right now (I'm using some animation but I don't think that causes that):

- (void)selectSpriteForTouch:(CGPoint)touchLocation {
    CCSprite * newSprite = nil;
    for (CCSprite *sprite in selectedSpritesArray) {
        if (CGRectContainsPoint(sprite.boundingBox, touchLocation)) {
            newSprite = sprite;
            break;
        }
    }

    if (newSprite) {
        CCSprite *fixedSprite = [CCSprite spriteWithSpriteFrameName:@"Animation_01.png"];

        fixedSprite.position = ccp(newSprite.contentSize.width/2,newSprite.contentSize.height/2);
        [newSprite addChild:fixedSprite];

        NSMutableArray *animFrames = [NSMutableArray array];
        for(int i = 1; i <= 10; ++i) {

            [animFrames addObject: [[CCSpriteFrameCache sharedSpriteFrameCache] spriteFrameByName: [NSString stringWithFormat:@"Animation_%02d.png", i]]];
        }

        CCAnimation *anim = [CCAnimation animationWithFrames:animFrames delay:0.05f];
        CCActionInterval *animAction = [CCAnimate actionWithAnimation:anim restoreOriginalFrame:NO];

        id seq = [CCSequence actions: animAction, [CCCallFunc actionWithTarget:fixedSprite selector:@selector(removeFromParentAndCleanup:)], [CCCallFunc actionWithTarget:newSprite selector:@selector(removeFromParentAndCleanup:)], nil];
        [fixedSprite runAction:seq];
    }
}

- (BOOL)ccTouchBegan:(UITouch *)touch withEvent:(UIEvent *)event {
    CGPoint touchLocation = [self convertTouchToNodeSpace:touch];
    [self selectSpriteForTouch:touchLocation];
    return TRUE;
}

If anyone knows, please guide me; thanks!

Posted 3 months ago #

breskit
Member

Replace the CCCallFunc with CCCallFuncN. This was you pass a reference to the object you are working on.

Posted 3 months ago #

phantomsri
Member

hi @elsevero first of all, all the sprites i used comes with a tag.

I used the tag to remove the sprite. I had tagged it from Number 1 to 3. The code i posted in my tread comes with a loop, each time the user touches the overlapped sprite, the code will check is the sprite tag is number 1 to 3, if its the correct tag it will remove it .

Try this if you are using the code from http://www.raywenderlich.com/

movableSprites = [[NSMutableArray alloc] init];
        NSArray *images = [NSArray arrayWithObjects:@"bird.png", @"cat.png", @"dog.png", @"turtle.png", nil];
        for(int i = 0; i < images.count; ++i) {
            NSString *image = [images objectAtIndex:i];
            CCSprite *sprite = [CCSprite spriteWithFile:image];
            float offsetFraction = ((float)(i+1))/(images.count+1);
            sprite.position = ccp(winSize.width*offsetFraction, winSize.height/2);
            [self addChild:sprite z:1 tag:i]; // the tag i based on image count 1 to 4, so the tag will start from 1 to 4
            [movableSprites addObject:sprite];

try this touch code

-(void)ccTouchesBegan:(NSSet *)touches withEvent:(UIEvent *)event
{
    UITouch* myTouch = [touches anyObject];
    CGPoint location = [myTouch locationInView: [myTouch view]];
    location = [[CCDirector sharedDirector]convertToGL:location];
    location = [self convertToNodeSpace:location];

    int totalNumberOfItems=5;
    for (int y=0; y < totalNumberOfItems; y++){
        CCSprite *temp = (CCSprite*)[self getChildByTag:y];

        CGRect test1 = [temp boundingBox];

        if (CGRectContainsPoint(test1, location)) {

            [self removeChild:temp cleanup:YES ];
            // i have removed "return;"
        }
    }  

}

Posted 3 months ago #

Birkemose
Moderator

You can not iterate forward through an array, removing array members on the fly. It simply does not work.
You have to iterate backwards.

Posted 3 months ago #
elsevero
Member

@breskit: Thanks! I'll try that, and let you know the results :)

@phantomsri: Thank you for the code! I'm using Ray's tutorial with dragging sprites to the screen but I don't think will be useful for me...
I'm saying that because I have objects that are placed to the exact position (lets say: box.png sprite must be always to ccp(128,128) and if I'm trying to touch the sprite object by tag I have a issue and that is always I'll be able to touch the box.png object around the position 128(x), 128(y)
I'm using a parallaxNode to scroll my two CCLayers in which I've added the sprite objects.

Another reason for adding the objects to array and remove them is to track them. I'll have to know if the player removed 4 specific sprites to display a message or do something else..

If there's any other possibility, I'd love to know it!

@Birkemose: Thanks! You mean:

for (CCSprite *sprite in [selectedSpritesArray reverseObjectEnumerator]) ?

Posted 3 months ago #

Birkemose
Moderator

@elsevero
No. I dont think it is allowed to modify arrays, using that syntax. Do it the old fashioned way.

for ( int index = selectedSpritesArray.count - 1; index >= 0; index -- ) {
  selectedSprite = [ selectedSpritesArray objectAtIndex:index ];
  if ( ... ) [ selectedSpriteArray removeObjectAtIndex: index ];
}

Posted 3 months ago #

elsevero
Member

@breskit: I've replaced with CCCallFuncN and doesn't work...

@Birkemose: Tried your code but it doesn't work either, maybe I'm not use it correctly; Can you explain? Thanks!

Would look like this?

for ( int index = selectedSpritesArray.count - 1; index >= 0; index -- ) {
        selectedSprite = [ selectedSpritesArray objectAtIndex:index ];
        if (CGRectContainsPoint(selectedSprite.boundingBox, touchLocation) ) {
            [selectedSpritesArray removeObjectAtIndex: index ];
        newSprite = selectedSprite;
        break;
        }
    }

Posted 3 months ago #

RSS feed for this topic

Reply

You must log in to post.