A fast, easy to use, free, and community supported 2D game engine
I have subclassed the Layer class and added my own dealloc method but it never gets called. I have seen similar posts about this but never a solution. I'm thinking it might be because there are still references to the Layer object, but I don't know where. My game is merely a Layer subclass with a single sprite.
Any ideas or suggestions?
Can either of you upload the simplest project where that error occurs to a file sharing site (like rapidshare). I'll take a look at it.
I have been quite busy the last week so I haven't had time to work on this. Now I'm back on it and I've been doing some debugging.
At first my scene's dealloc was not called either, but I've added [[Director sharedDirect] end]; in applicationWillTerminate, just before the line [[Director sharedDirector] release];
Now my scene's dealloc is called, but the layer still isn't. Should I call release on the layer somewhere or maybe removeAllChildrenWithCleanup?
The scene dealloc is called but the layer is not? Quite strange.. how are you init'ng your layer? are you retaining it?
Is any of the layer child's retaining the layer?
I can't think of anything else... :S
Layer has no children.
One thing I've noticed now, if there are two scenes', say GameScene with GameLayer and MenuScene with MenuLayer. If I start the MenuScene with director runWithScene:menu and then switch to GameScene with director replaceScene:game and then quit with the home button, every scene and layer is created and dealloced as it should.
But it doesn't work without the replaceScene.
replaceScene is not working for me either. My scenes each have a retain count above 1 so none of them are deallocating. I am running into the same errors Carpy is running into with the scheduler (replied to his post). Can anyone offer a solution to unscheduling a schedule to decrement the retaincount?
Say you have this line:
`[self schedule: @selector(someMethod) interval: .1];'
Add this as the first line within someMethod:
[self unschedule: @selector(someMethod)];
This worked for me.
Also, if you are using a UIActivityIndicatorView you need to remove it when done using it:
[activityIndicatorView removeFromSuperview];
Hope this helps.
Where should I be calling my unscheduling function? I want the scheduler to change to the next scene after two seconds then get the retain count down to zero so I can release the scene from memory. Please help me. This scheduling thing is the only thing I need to resolve before I release my game.
Here's my code:
- (id) init
{
time_limit = 0;
[self schedule: @selector(step2:) interval:1.0f];
//[self myUnscheduler];
}
-(void) step2: (ccTime) delta //keeps time
{
if(time_limit == 2)
{
MenuScene * ms = [MenuScene node];
[[Director sharedDirector] replaceScene:[FadeTransition transitionWithDuration:1.0f scene:ms]];
//[self myUnscheduler];
}
time_limit++;
}
-(void) myUnscheduler
{
[self unschedule: @selector(step2:)];
}
-(void) step2: (ccTime) delta //keeps time
{
////////////////// Unschedule /////////////////////////
[self unschedule: @selector(step2)];
if(time_limit == 2)
{
MenuScene * ms = [MenuScene node];
[[Director sharedDirector] replaceScene:[FadeTransition transitionWithDuration:1.0f scene:ms]];
}
time_limit++;
}You are not calling:
[super init];and you are not returning self.
It might that or not.
But I've just added a similar test in r1103 and the layers are being dealloced.
Checkout the latest SVN revision and see the tests/SceneTest.m file for an example.
@jd: When I implement your code, the unschedule halts the execution of replaceScene. I read a post in the forums that said you can't unschedule a schedule from within the function that is being scheduled (sorry if that's convoluted). How do I unschedule after the time_limit == 2 code has been called?
@riq: I am calling [super init] and returning self (I just didn't include it in the sample code). I will try the tests/SceneTest.m file as you suggested.
Thank you both for the feedback. I will post my progress.
For my clarification, in order to free the scene from memory should I call dealloc on both the scene and the layer? Or does the call to [super dealloc] in the layer's dealloc method deallocate the scene from memory? I assume that [super dealloc] called from the scene's layer means that the layer is deallocating the scene from memory. Is that correct?
@Codemattic :
Actually, [super dealloc] should be the last line of the dealloc method.
@deeniri :
What you said is not correct. First, as Codemattic pointed out, you don't call dealloc on the scene nor the layer. You can call release on them if you explicitly retained them in your code (otherwise cocos will do it for you). Second, when you call [super dealloc] or say [super someMethod], it doesn't mean it calls someMethod on the parent. It means it calls someMethod on the superclass of your object.
This is cut and paste from my code and it has no issues. That's the only reason I suggested it. Maybe your code has something else going on that mine does not:
[self schedule: @selector(loadingDone) interval: .1];
Then in the method:
- (void) loadingDone
{
NSLog(@"loading Done");
[self unschedule: @selector(loadingDone)];
GameScene *gs = [GameScene node];
[[Director sharedDirector] replaceScene:gs];
}@codemattic: Thanks, I got it, "one dealloc per class."
@clain: I do not explicitly retain any scenes and dealloc is called from my scene
@jd: where are you calling [self schedule: @selector(loadingDone) interval: .1]; from? a scene or a node?
Thank you for your insights. dealloc is now being called each time I call replaceScene.
For my clarification, when I call [self addChild:[myLayer node] z:1]; from the init method in my scene's implementation (which is implemented in the same class file as myLayer node's implementation), does that bind myLayer node to scene node in such a way that my scene node is released when dealloc is called from myLayer node?
@deeniri :
dealloc is called automatically when the retainCount of an object reaches zero. When you replace a scene, the old scene receives a release message from the director, and since you didn't explicitly retain the scene, its retainCount reaches zero and its dealloc method gets called.
For my clarification, when I call [self addChild:[myLayer node] z:1]; from the init method in my scene's implementation (which is implemented in the same class file as myLayer node's implementation), does that bind myLayer node to scene node in such a way that my scene node is released when dealloc is called from myLayer node?
The other way around : your myLayer node receives a release message from your scene when the scene is dealloc'd. And again, if your layer wasn't explicitly retained by you in your code, its retainCount reaches zero and therefore its dealloc method gets called.
You must log in to post.