NSMutableArray as sequence actions parameter

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

NSMutableArray as sequence actions parameter

(9 posts) (6 voices)

Started 2 years ago by daemonk
Latest reply from jandujar

Tags:

daemonk
Member

Seems like there was a lot of posts asking how to add actions to a sequence dynamically. So I wrote a function that you can add to IntervalAction.m and header that'll take a NSMutableArray of actions as the parameter:

+(id) actionMutableArray: (NSMutableArray*) _actionList {
	FiniteTimeAction *now;
	FiniteTimeAction *prev = [_actionList objectAtIndex:0];

	for (int i = 1 ; i < [_actionList count] ; i++) {
		now = [_actionList objectAtIndex:i];
		prev = [Sequence actionOne: prev two: now];
	}

	return prev;
}

So to use this, just create an NSMutableArray of actions that you want sequenced, then pass it to the actionMutableArray function.

NSMutableArray* actionList = [[NSMutableArray alloc] initWithCapacity:1];
[actionList addObject:yourActionOne];
[actionList addObject:yourActionTwo];
[actionList addObject:yourActionThree];

[yourSprite runAction:[Sequence actionMutableArray:actionList]];

This seems to run faster than using:

-(id) addAction:(id) _action ToSequence:(id) _seq {
	return [Sequence actions: _seq, _action, nil];
}

Posted 2 years ago #

gonzooin
Member

thanks a lot, this is very usefull !

Posted 1 year ago #
smallpresence
Member
Had to add the correct 'CC' prefix to the classes, but that was it, compiled well.

Problem is, I still get a SIGBART exception because:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[NSCFArray duration]: unrecognized selector sent to instance 0x4d316d0'

I am using this code:
```
NSMutableArray *movements	= [[NSMutableArray array] autorelease];
...
[movements addObject:[CCMoveTo actionWithDuration:1/12.0f position:ccp(x,y)]];
...
CCAnimate *antest	= [CCAnimate actionWithAnimation:animation restoreOriginalFrame:NO];
CCSequence *seqtest	= [CCSequence actionsMutableArray:movements];
[sprite runAction:[CCSpawn actions:antest, seqtest ]];
```
It seems to seems to me that the object hasn't released9as expected) and that it still exists in memory, but the object type doesn't respond to 'duration', which is a 'CCAction' class I believe. I don't understand why it is not getting access to the 'CCMoveTo' actions that's I've added to the array. Any ideas?

I would really appreciate help on this, it's blowing my mind.
Posted 1 year ago #
Benihana
Member

[[NSMutableArray array] autorelease];

This line calls autorelease twice (using the array initializer handles the alloc and autorelease call).

The real problem is that at some point, you're passing an Array where you should be passing an Action, but I don't see it based on the code you posted. What class is your animation object? Was this code copy and pasted from your project or did you type it in?

Posted 1 year ago #
smallpresence
Member
I fixed the double autorelease.

The class is declared like so after the array is populated in the loop:
```
CCAnimation *animation = [CCAnimation animationWithName:sheetName delay:1/12.0f frames:frames];
```
While I wait for an answer on this I am experimenting with a dynamic va_list(e.g.: http://stackoverflow.com/questions/688070/is-there-any-way-to-pass-an-nsarray-to-a-method-that-expects-a-variable-number-of).
Posted 1 year ago #
smallpresence
Member

PROBLEM:
Need to load CCSequence actions dynamically at runtime via NSArray.

SOLUTION:
Category extension of CCSequence class found in CCIntervalAction.m that adds method to accept NSMutableArray(could just be a NSArray) with a list of CCActions.

NOTES:
You can use the code from the original poster, but make sure to correct the class names as I mentioned above to include the 'CC' prefix.

My 'NSInvalidArgumentException' error was due to my double autoreleasing, I believe.

On a technical note, it appears CCSequence forms a linked list of actions. Each instance has an action array property that has 2 elements. This makes sense conceptually since each action happens one at a time in order of addition.

I hope this helps others, as this seems to have been a common question for people in the forum.

Posted 1 year ago #

jandujar
Member

I created a CCSequenceHelper that does the trick. Maybe will be usefull for somebody other than me.

//
//  CCSequenceHelper.h
//
//  Created by Jose Antonio Andújar Clavell on 09/02/11.
//  Alias "jandujar"
//
//  More snippets on http://www.jandujar.com
//
//  License http://creativecommons.org/licenses/by/3.0/
//
//  Based upon code by daemonk
//  http://www.cocos2d-iphone.org/forum/topic/2547
//

#import <Foundation/Foundation.h>
#import "cocos2d.h"

@interface CCSequenceHelper : CCSequence {

}

+(id) actionMutableArray: (NSMutableArray*) _actionList;
@end

//
//  CCSequenceHelper.m
//  Created by Jose Antonio Andújar Clavell on 09/02/11.
//  Alias "jandujar"
//
//  More snippets on http://www.jandujar.com
//
//  License http://creativecommons.org/licenses/by/3.0/
//
//  Based upon code by daemonk
//  http://www.cocos2d-iphone.org/forum/topic/2547
//

#import "CCSequenceHelper.h"

@implementation CCSequenceHelper

+(id) actionMutableArray: (NSMutableArray*) _actionList {
	CCFiniteTimeAction *now;
	CCFiniteTimeAction *prev = [_actionList objectAtIndex:0];

	for (int i = 1 ; i < [_actionList count] ; i++) {
		now = [_actionList objectAtIndex:i];
		prev = [CCSequence actionOne: prev two: now];
	}

	return prev;
}

@end

Or you can download the code from my webpage.
http://www.jandujar.com/node/7

Posted 11 months ago #

Normal Force
Member
Thanks for the code, jandujar! Works splendidly.

This is just a superficial change, but my personal preference is to use categories to extend the CCSequence class.

CCSequence+Helper.h
```
#import <Foundation/Foundation.h>
#import "cocos2d.h"

@interface CCSequence (Helper)
  +(id) actionMutableArray: (NSMutableArray*) actionList_;
@end
```
CCSequence+Helper.m
```
#import "CCSequence+Helper.h"
@implementation CCSequence (Helper)
.
.
.
@end
```
Then I can just use CCSequence is I normally would...

CCSequence *seq = [CCSequence actionMutableArray: actionArray];
Posted 7 months ago #
jandujar
Member

Thank for your info, I didn't known categories. I'm new in Objective-C

Posted 7 months ago #

RSS feed for this topic

Reply

You must log in to post.