Different touches show the same location.

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

Different touches show the same location.

(8 posts) (3 voices)

Started 5 months ago by cokoco
Latest reply from cokoco

Tags:

cokoco
Member

I am trying to get a keyboard type of thing going with multitouch.

Even though I touch with two finger at separate positions, the same sprite is played.

Im sure it's something i've missed concerning the basics of touches.

- (void)ccTouchesBegan:(NSSet *)touches withEvent:(UIEvent *)event
{
	NSSet *allTouches = [event allTouches];

    switch ([[allTouches allObjects] count]) {

        case 1:

            NSLog(@"One Touch");
             UITouch *touch1 = [[allTouches allObjects] objectAtIndex:0];
             CGPoint location1 = [touch1 locationInView: [touch1 view]];
             location1 = [[CCDirector sharedDirector] convertToGL: location1];

            for(int i=0;i<8;i++){
                  if(CGRectContainsPoint(xSprite[i].boundingBox, location1)){
                      [synthObject startNote:i];
                  }
            }
            break;

        case 2:

            NSLog(@"Two Touches");
            UITouch *touch2 = [[allTouches allObjects] objectAtIndex:1];
            CGPoint location2 = [touch2 locationInView: [touch2 view]];
            location2 = [[CCDirector sharedDirector] convertToGL: location2];

                for(int i=0;i<8;i++){
                    if(CGRectContainsPoint(xSprite[i].boundingBox, location2)){
                        [synthObject startNote:i+1];
                    }
                }
            break;

    }
}

Posted 5 months ago #

Dragyn
Member

I believe your problem here is that if there are 2 touches, your "case 2" is only parsing the second touch, and ignoring the first touch. So if the count is 2, the "case 1:" code is not being evaluated. There's more elegant ways, but the easiest to try would be to also copy the "case 1" logic into the "case 2" section as well.

Posted 5 months ago #
cokoco
Member

Great, that worked.

Thought, do you think it would be better to use the 'Targeted Touch Delegate'? In the case of a synth keyboard..(notes holding, several other notes played at same time, etc.)

Thanks

Posted 5 months ago #

cokoco
Member

So i've been fiddling around with this now, and can't get it to work perfectly.
For some reason both two if statements within the for loops in case 2: of the switch are correct,
and the synth stops both the notes, instead of just the one.

What is a better solution for this?

-(void) ccTouchesEnded:(NSSet *)touches withEvent:(UIEvent *)event{

    NSSet *allTouches = [event allTouches];

    switch ([[allTouches allObjects] count]) {
        case 1:

            NSLog(@"Case1End\n");
            UITouch *touch1Single = [[allTouches allObjects] objectAtIndex:0];
            CGPoint location10 = [touch1Single locationInView: [touch1Single view]];
            location10 = [[CCDirector sharedDirector] convertToGL: location10];

              //stopping the note if first touch in singletouch is released

            for(int i=0;i<8;i++){

                if(CGRectContainsPoint(xSprite[i].boundingBox, location10)){
                    [self stopNoteFirstTouch:i+1];                }
            }
            break;

        case 2:

            NSLog(@"case2End\n");
            UITouch *touch1 = [[allTouches allObjects] objectAtIndex:0];
            CGPoint location1 = [touch1 locationInView: [touch1 view]];
            location1 = [[CCDirector sharedDirector] convertToGL: location1];

            UITouch *touch2 = [[allTouches allObjects] objectAtIndex:1];
            CGPoint location2 = [touch2 locationInView: [touch2 view]];
            location2 = [[CCDirector sharedDirector] convertToGL: location2];

          //stopping the note if first touch in mutitouch is released

            for(int i=0;i<8;i++){
                if (firstTouchNoteIsPlaying[i+1]==YES) {
                    if(CGRectContainsPoint(xSprite[i].boundingBox, location1)){
                        [self stopNoteFirstTouch:i+1]; 

                        NSLog(@"Touch One gets Cancelled %i\n", i+1);
                }

               }
            }

          //stopping the note if second touch in mutitouch is released

            for(int i=0;i<8;i++){
                if (SecondTouchNoteIsPlaying[i+1]==YES) {
                    if(CGRectContainsPoint(xSprite[i].boundingBox, location2)){
                        [self stopNoteSecondTouch:i+1];

                        NSLog(@"Touch Two gets Cancelled %i\n", i+1);
                    }
                }
            }
            break;
    }
}

Posted 5 months ago #

unrealaz
Member

You get both nslog in case2 to print right?
This happens cause you get both touches on both sprites at the same it.
You should only test if the currently released touch.

I usually use

- (void) ccTouchEnded:(UITouch *)touch withEvent:(UIEvent *)event

and I know which of the two touches is released.

In you case, on case 2:
you only need to test for UITouch *touch2 = [[allTouches allObjects] objectAtIndex:1];
because this is the one that was released.

so I think this should work:

case 2:

            UITouch *touch2 = [[allTouches allObjects] objectAtIndex:1];
            CGPoint location2 = [touch2 locationInView: [touch2 view]];
            location2 = [[CCDirector sharedDirector] convertToGL: location2];

          //stopping the note if second touch in mutitouch is released

            for(int i=0;i<8;i++){
                if (SecondTouchNoteIsPlaying[i+1]==YES) {
                    if(CGRectContainsPoint(xSprite[i].boundingBox, location2)){
                        [self stopNoteSecondTouch:i+1];

                        NSLog(@"Touch Two gets Cancelled %i\n", i+1);
                    }
                }
            }

Posted 5 months ago #

cokoco
Member
Hmm..

But what if there are two thouches, but the number one touch is the one that was released?
Then the 'case' would be '2' and it would only check that touch in for loop.

Should i use
```
- (void) ccTouchEnded:(UITouch *)touch withEvent:(UIEvent *)event
```
IE. non plural method? I I thought that would not work with multitouch.

Cheers
Posted 5 months ago #

unrealaz
Member

It works with multitouch.
What I do:
- in the init of the layer I set .isTouchEnabled = YES;
- I have 2 UITouch variables Touch1 & Touch2
Then these methods get called:

- (BOOL)ccTouchBegan:(UITouch *)touch withEvent:(UIEvent *)event
{
NSSet *allTouches = [event allTouches];
	if (allTouches.count == 1) //This is in case both touches aren't null by any chance when only a finger is on the screen.
	{
		Touch1 = NULL;Touch2 = NULL;
	}
	if (Touch1 == NULL)
	{
		Touch1 = touch;
	}
	else
	{
		Touch2 = Touch;
	}
}
- (void)ccTouchMoved:(UITouch *)touch withEvent:(UIEvent *)event
{
}
- (void) ccTouchEnded:(UITouch *)touch withEvent:(UIEvent *)event
{
	if (touch == Touch1)
	{
		case1
		Touch1 = null;
	}
	if (touch == Touch2)
	{
		case2
		Touch2 = null;
	}
}

Posted 5 months ago #

cokoco
Member

So at the moment I am trying this, the problem here is that it wont seperate between the two touches when the finger moves out of the sprite.

As you can see this is a synth, so when i move one of two fingers of a key, both gets cut of, instead of just one.

How can I fix this?

Btw. This is on my main layer.

-(void) ccTouchMoved:(UITouch *)touch withEvent:(UIEvent *)event   {

    CGPoint location = [touch locationInView: [touch view]];
    location = [[CCDirector sharedDirector] convertToGL: location];

        for(int i=0;i<8;i++){

            if(CGRectContainsPoint(xSprite[i].boundingBox, location)){
                if (noteIsPLaying[i+1] == NO) {
                    [self playNote:i+1];
                }

                }else {
                    if (noteIsPLaying[i+1]) {
                    [self stopNote:i+1];
                }
            }
        }
}

- (BOOL)ccTouchBegan:(UITouch *)touch withEvent:(UIEvent *)event{

    CGPoint location = [touch locationInView: [touch view]];
    location = [[CCDirector sharedDirector] convertToGL: location];

    for(int i=0;i<8;i++){
        if(CGRectContainsPoint(xSprite[i].boundingBox, location)){
            [self playNote:i+1]; 

        }
    }
    return NO;
}

-(void) ccTouchEnded:(UITouch *)touch withEvent:(UIEvent *)event     {

    CGPoint location = [touch locationInView: [touch view]];
    location = [[CCDirector sharedDirector] convertToGL: location];

        for(int i=0;i<8;i++){
            if(CGRectContainsPoint(xSprite[i].boundingBox, location)){
            [self stopNote:i+1]; 

        }
    }
}

Posted 5 months ago #

RSS feed for this topic

Reply

You must log in to post.