CCLabelBMFont not removed from screen

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

CCLabelBMFont not removed from screen

(12 posts) (4 voices)

Started 9 months ago by Folkdev
Latest reply from Folkdev

Tags:

Folkdev
Member

I have a CCLabelBMFont which I add as a child to a sprite. But when I run a CCFadeOut action it isn't removed. The sprite gets removed but not the label. Here's the code:

-(void)fadeOutSprite:(CCSprite *)sprite withDuration:(float)duartion{

    id fadeOut = [CCFadeOut actionWithDuration:duartion];
    [sprite runAction: [CCSequence actions:fadeOut, [CCCallFunc actionWithTarget:self selector:@selector(removeFromParent:)], nil]];
}

-(void)removeFromParent:(CCSprite *)sender{

    [self removeChild:sender cleanup:YES];
}

CCSprite *achievementSprite = [CCSprite spriteWithFile:@"achievementSlider.png"];

        CCLabelBMFont *achievementLabel = [CCLabelBMFont labelWithString:@"Achievement descp" fntFile:@"pointsTime.fnt"];

        //Place the label in the center of the sprite
        float Xpos = achievementSprite.contentSize.width * 0.5;
        float Ypos = achievementSprite.contentSize.height * 0.5;
        achievementLabel.position = ccp(Xpos, Ypos);

        [achievementSprite addChild:achievementLabel];

        CGSize screenSize = [Helper screenWidthAndHeight];
        float achievementSpriteSizeHalved = achievementSprite.contentSize.height * 0.5;
        achievementSprite.position = ccp([Helper screenCenter].x, (screenSize.height - achievementSpriteSizeHalved) - 60);

        [self addChild:achievementSprite z:9];
        [self fadeOutSprite:achievementSprite withDuration:2.3];

But if I comment out [self fadeOutSprite:achievementSprite withDuration:2.3]; and do [self removeChild:sliderSprite cleanup:YES]; instead, it's working (the label gets removed). So it must have to do with the CCFadeOut action.

Posted 9 months ago #

cocojoe
Member

Interesting, I just posted a similar issue....
http://www.cocos2d-iphone.org/forum/topic/19314

Posted 9 months ago #
Folkdev
Member

cocojoe:

We better hope that some clever guy has a solution :/

Maybe a moderator should remove my thread. I totally missed that you just had created a thread with a similar issue.

Posted 9 months ago #

bryce
Member

Try:

[sender removeAllChildrenWithCleanup:YES];
[self removeChild:sender cleanup:YES];

Posted 9 months ago #

Folkdev
Member

[sender removeAllChildrenWithCleanup:YES];
[self removeChild:sender cleanup:YES];

I get EXC_BAD_ACCESS. Maybe I should've mentioned that I did something similar. I looped trough all the sprites children and removed but I got EXC_BAD_ACCESS then as well. Didn't thought of the removeAllChildrenWithCleanup method.

-(void) execute
{
[targetCallback_ performSelector:selector_];
}

Posted 9 months ago #
bryce
Member

Change
-(void)removeFromParent:(CCSprite *)sender{
to
-(void)removeFromParent:(id)sender{
and see if that works.

Posted 9 months ago #
Folkdev
Member

bryce:

Already did that. That was what I had before I changed the parameter to CCSprite.

Posted 9 months ago #
cocojoe
Member

@Folkdev actually I have same issue as it was working, then it stopped working for some reason and after checking code all I've added were some actions, Scale & Fade.

Posted 9 months ago #
Folkdev
Member

@cocojoe

Yea it's works like a charm when you remove the child (CCSprite) with [self removeChild...] but if you call some sort of action it's not working - the label doesn't get removed. I've tried with other actions as well but it's the exact same.

Posted 9 months ago #
Folkdev
Member
@cocojoe

I have come up with a simple solution. In the removeFromParent selector. Use removeChildByTag and it'll work!
```
-(void)removeFromParent:(id)sender{

    [self removeChildByTag:AchievementTag cleanup:YES];
}
```
It isn't pretty and dynamic but it works. It must be a bug in the CCCallFunc class.

Edit: the label doesn't fade out but it gets removed.
Posted 9 months ago #
Normal Force
Member
When you do this:
```
[sprite runAction: [CCSequence actions:fadeOut,
                     [CCCallFunc actionWithTarget:self
                                         selector:@selector(removeFromParent:)],
                      nil]];
```
You use CCCallFunc but in the @selector you are expecting it to pass a parameter to removeFromParent since you use a colon after the method name. Just change CCCallFunc to CCCallFuncN and see if removeFromParent is actually being passed a sender. Because I think that's what the problem is. removeFromParent is being called, but sender is nil so it can't do anything.
Posted 9 months ago #
Folkdev
Member
@Normal Force

Yea, thanks! That was the problem. But I think it's strange that the sprite got removed but not the label with CCCallFunc. If the sender was nil why did the sprite got removed?

Solution:
```
[sprite runAction: [CCSequence actions:fadeOut,
                     [CCCallFuncN actionWithTarget:self
                                         selector:@selector(removeFromParent:)],
                      nil]];
```
Posted 9 months ago #

RSS feed for this topic

Reply

You must log in to post.