CPU usage increases,frames drop, THE LONGER I PLAY.

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

CPU usage increases,frames drop, THE LONGER I PLAY.

(20 posts) (7 voices)

Started 10 months ago by y2kreddy
Latest reply from y2kreddy

Tags:

y2kreddy
Member
hi

i am using spacemanager/chipmunk for my game. i have designed 8 levels and the problem is , the longer i play the app runs very slowly. i ran my app with instruments to check the perfromace (checked cpu moniter and coremotion). initially the app takes 20% of cpu time and has 60fps. as i play along the cpu usage increases from 20% to 95 % and FPS drops in 10-15 minutes or so. to get back on track i have to quit the app from background and restart the game.

to change between scenes i always use the following code. is this where i am going wrong?
please let me know what else you need from my code.
```
-(void)Next

{
    CCScene *game = [CCScene node];
    Level2 *gamel = [Level2  node];
    [game addChild:gamel z:0 tag:0];
    [[CCDirector sharedDirector] replaceScene:[CCTransitionMoveInR transitionWithDuration:0.5 scene:game]];
    [[CCDirector sharedDirector] resume];
}
```
Posted 10 months ago #
Daniel López
Member

But are you releasing memory used by chipmunk? It seems that each level you do, more "processing power" you need because of don't "releasing" resources of chipmunk.

You should place the code to dealloc everything related to chipmunk in the dealloc method of the scene.

When you do a replace scene, this method automatically calls the dealloc method, so that's the only thing you need, to fill the dealloc method.

Posted 10 months ago #
Gray Olson
Member

Yes, run it through leaks, it should point your leaks out to you. Definitely sounds like a leak.

Posted 10 months ago #

y2kreddy
Member

Hi,

This is my level1 .h file. it is a subclass of CCLayer. smgr is the only object i init and allocate. so i am releasing it in dealloc.

CCLabelTTF *ScoreTitle;
CCLabelTTF *levelcleared;
CCLabelTTF *highscore;
CCLabelTTF *scorelabel;
CCLabelTTF *levelnum;
CCLabelTTF *LblScore;

int score;
int oldScore;
int finalscore;

#pragma mark GameLayer Class
@interface Level1 : CCLayer
{
	SpaceManagerCocos2d *smgr;
    cpShape *Ground;

    cpShape *redmarble;
	cpCCSprite *redmarbleSprite;
    BOOL REDselected;
    BOOL REDdisappeared;

    cpShape *bluemarble;
	cpCCSprite *bluemarbleSprite;
    BOOL BLUEselected;
    BOOL BLUEdisappeared;

    cpShape *yellowmarble;
	cpCCSprite *yellowmarbleSprite;
    BOOL YELLOWselected;
    BOOL YELLOWdisappeared;

	//CCLabelTTF *label;

    cpMouse *mouse;

    CCSprite *BackGround;

    CCSprite *ballglow;

    CGPoint touchLocation;
    int MarblesInGlass;

    BOOL RED;
    BOOL BLUE;
    BOOL YELLOW;

    CCMenu *tempmenu;

    CCSprite *PauseBG;

    //pShape *leg2;

    CCMenuItem *pauseMenuItem;

    CCMenuItemImage *SoundsOn;

    CCMenuItemImage*SoundsOff;

    cpShape *temp;

}   

@end

and here is my dealloc function

- (void) dealloc
{
    [[CCTouchDispatcher sharedDispatcher] removeDelegate:self];
	[self removeAllChildrenWithCleanup:YES];
	[smgr release];
	[super dealloc];
}

do i have to put all my member vairables = nil in dealloc even if i dont allocate memory for them?
Please advice.
Thanks.

Posted 10 months ago #

slembcke
Administrator

This page has pretty much everything you'll ever need to know about Cocoa memory management:
Apple Docs

If you are taking shortcuts and not retaining objects when storing them into instance variables because something else already did it, you are asking for trouble. You'll just end up with dangling pointers or memory leaks later when you forget about this and move the object around between structures.

Also, try putting a breakpoint in your dealloc method to make sure it's getting called. It's very possible that you created a cycle in your object graph and so dealloc is never even getting called.

Posted 10 months ago #
y2kreddy
Member
@Daniel López , my dealloc looks like this. are you saying [smgr release] does not free the memory of chipmunk?
```
- (void) dealloc
{
    [[CCTouchDispatcher sharedDispatcher] removeDelegate:self];
	[self removeAllChildrenWithCleanup:YES];
	[smgr release];
	[super dealloc];
}
```
Kindly please suggest me what to do. i have designed all the levels and now i have performance issue. i am past my deadline. Please help.
Posted 10 months ago #
clarus
Member

When you do a replace scene, this method automatically calls the dealloc method, so that's the only thing you need, to fill the dealloc method.

But, note that this will only happen if you're not retaining the scene somewhere else (in an array, retained in an iVar or by some other object). You should make sure your dealloc methods are even being called. This goes for anything you allocate. dealloc is only called when the retain count of an object reaches zero. @slembcke's link to the memory management docs should be the first thing anyone developing for iOS reads. You have to understand that, and it's really not difficult. I'm not saying that you don't understand it, but a lot of people seem to just guess about when to use retain, autorelease, release, autorelease pools and so on.

You should definitely be testing through Instruments. Every app should be tested that way, and not at the last minute. It's easier to debug one leak at a time early on than to debug many leaks after they've accumulated. Something to keep in mind next time. ;)

Posted 10 months ago #
slembcke
Administrator

SpaceManager releases the Chipmunk memory yes, but only when it's dealloc method is called. The fact that your CPU usage keeps getting worse, I'm 90% certain that your scene never gets deallocated, so it never releases the space and so the space cannot be deallocated.

Posted 10 months ago #
andrew
Member
I think that for cpCCSprites you can do this so that once they are removed (i.e. [self removeChild:redmarbleSprite cleanup:YES];) it will deallocate the shape:
```
redmarbleSprite = [cpCCSprite blahblahblah]; // initialize here
redmarbleSprite.spaceManager = smgr;
redmarbleSprite.autoFreeShape = YES;
```
Posted 10 months ago #

y2kreddy
Member

@clarus @slembcke @andrew . i thank you all for the help you are providing.

Now i have some member variables like so

cpShape *redmarble;
	cpCCSprite *redmarbleSprite;

i am assigning shapes and sprites like so,

redmarble = [smgr addCircleAt:cpv(xredpos,yredpos) mass:0.5 radius:18];
	redmarble->collision_type = KMarbleCollisiontype;
    redmarbleSprite= [cpCCSprite spriteWithShape:redmarble file:@"redmar.png"];
    redmarble->e = 0.5;
   	[self addChild:redmarbleSprite];
    redmarbleSprite.spaceManager = smgr;

i have a schedular that keeps checking the velocity of the horizontal velocity of the ball. if it is near zero i make the ball disappear. And that is the only place i ever remove the ball from the space. And here is the code for that.

-(void)checkifREDsleeping
{

    cpVect velocity = redmarble->body->v;
    NSLog(@" RED velocity X,Y is %f,%f",velocity.x,velocity.y);
    if (REDselected ==YES && velocity.y == 0.0)
    {
        if ([GameDelegate getvolumestatus]==@"1")
        {
         [[SimpleAudioEngine sharedEngine] playEffect:@"Sound 1a.mp3"];
        }

        [smgr removeShape:redmarble];
        [self removeChild:redmarbleSprite cleanup:YES];
        [self unschedule: @selector(checkifREDsleeping)];
        REDdisappeared = YES;
    }

}

i have tested my app in instruments and surprisingly it shows leaks in cpCircleShapeAlloc. not sure why? Here is the screenshot.

This is how i am replacing a scene

-(void)Next

{
    CCScene *game = [CCScene node];
    Level2 *gamel = [Level2  node];
    [game addChild:gamel z:0 tag:0];
    NSLog(@"replacing scene");
    [[CCDirector sharedDirector] replaceScene:[CCTransitionMoveInR transitionWithDuration:0.5 scene:game]];
    [[CCDirector sharedDirector] resume];
}

and here is my dealloc

- (void) dealloc
{
    NSLog(@"i am inside delloc - level one");
    [[CCTouchDispatcher sharedDispatcher] removeDelegate:self];
   	[self removeAllChildrenWithCleanup:YES];
	[smgr release];
   	[super dealloc];
}

wheneever i replace a scene i have a NSLog statement in dealloc. i am 100% sure that it executes the dealloc whenever replace scene is called. here is the screenshot for that.

UPDATE : Sorry i could not get the images uploaded.

Posted 10 months ago #

andrew
Member

try using [smgr removeAndFreeShape:shape];

Posted 10 months ago #
y2kreddy
Member
@andrew , i tried that and it did not work either.

what i did now is, i downloaded the spacemanager sample program again from this link

http://code.google.com/p/chipmunk-spacemanager/downloads/detail?name=SpaceManager%200.1.0.zip

The ccTouchesBegan looks like this.
```
- (void)ccTouchesBegan:(NSSet *)touches withEvent:(UIEvent *)event
{	

	CGPoint pt = [self convertTouchToNodeSpace:[touches anyObject]];
	[smgr applyLinearExplosionAt:pt radius:240 maxForce:200];

    if ([touches count] > 1)
    {
        CCScene *scene = [CCScene node];
        [scene addChild:[GameLayer node]];
        [[CCDirector sharedDirector] replaceScene:[CCTransitionFade transitionWithDuration:.4 scene:scene  withColor:ccBLUE]];
    }
}
```
i just changed the if condition to look like
```
if ([touches count] == 1)
```
when i tap the screen it replaces with the same scene again. after like 20 taps the frames drop gradually. this is what is exactly happening to my Game also. Do you think there is a problem with spacemanager?
Posted 10 months ago #
Jnani
Member

You might want to try setting the Thumb compilier flag off. That brought my frame rate from 30 to 60 instantly. See this link: iPhone OpenGL Speed Tip – Turn Off Thumb Instructions

Posted 10 months ago #
y2kreddy
Member

Posted 10 months ago #
y2kreddy
Member

@Jnani Thumb compilier flag is already set to NO.

Posted 10 months ago #
y2kreddy
Member

Finally i managed to put and end to this problem. Putting [smgr stop]; before [smgr release]; did the trick.

i was thinking if smgr is deallocated there is not way it would be running. hence i never put [smgr stop]; earlier.

Thank You all for helping me with suggestions.

Posted 10 months ago #
clarus
Member

Hmm. Are you sure smgr is getting released? It sounds like you've got a retain on the smgr object so its dealloc isn't called when you send release, and that's why it didn't stop. It doesn't make sense that something you've deallocated could be running. You may have stopped it, but you're probably leaking.

How and where do you allocate the smgr object--what's that code look like? Is there a property declaration for it with the retain attribute by any chance?

Posted 10 months ago #

y2kreddy
Member

@clarus

Here is my dealloc Method. i have just put in some NSLogs to verify again.

- (void) dealloc
{
    NSLog(@"i am inside delloc - level one");
    [[CCTouchDispatcher sharedDispatcher] removeDelegate:self];
   	[self removeAllChildrenWithCleanup:YES];
    [smgr stop];
    NSLog(@"retain count of smgr is %d",[smgr retainCount]);
	[smgr release];
     NSLog(@"retain count of smgr is %d",[smgr retainCount]);
   	[super dealloc];
}

Surprisingly my logs printed this.

2011-07-29 12:51:27.322 3Marbles[300:707] i am inside delloc - level one
2011-07-29 12:51:27.337 3Marbles[300:707] retain count of smgr is 1
2011-07-29 12:51:27.339 3Marbles[300:707] retain count of smgr is 1

i was expecting it to crash at [smgr retainCount] (in the third NSLog statement).
But it did not .
Not sure why. something crazy is going on with my program.

i don't have a property set for smgr. i am allocating it in the init method.

Posted 10 months ago #

y2kreddy
Member
@clarus . Woooh ..... i just found out that

after

'
smgr = [[SpaceManagerCocos2d alloc] init];
'
the retain count is 1

after
```
[smgr start];
```
the retaincount bumped to 2. Crazy thing to find now!!!!!!!
Posted 10 months ago #
y2kreddy
Member

http://forum.mobile-bros.com/viewtopic.php?f=4&t=1496

Posted 9 months ago #

RSS feed for this topic

Reply

You must log in to post.