HKTMXTiledMap « cocos2d for iPhone

cocos2d for iPhone » Programming » cocos2d 3rd party extensions

HKTMXTiledMap

(290 posts) (51 voices)

Started 1 year ago by skyhawk
Latest reply from cliveminni

Tags:

MaxMan
Member

Hey! I just tried to get that Tilemaps to work with cocos2d 2.0 and I found / fixed a bug in the HKTMXLayer class - here's my fix:

#if GL_ES_VERSION_2_0
        self.shaderProgram = [[CCShaderCache sharedShaderCache] programForKey:kCCShader_PositionTexture];
	texture_ = [[CCTextureCache sharedTextureCache] addImage:tilesetInfo.sourceImage];
        tilesetInfo.imageSize = CC_SIZE_POINTS_TO_PIXELS(texture_.contentSize); // convertng size is important for devices with CC_CONTENT_SCALE_FACTOR() > 1
#else
	texture_ = [[CCTextureCache sharedTextureCache] addImage:tilesetInfo.sourceImage];
        tilesetInfo.imageSize = texture_.contentSizeInPixels;
#endif

Posted 6 months ago #

actinism
Member

Hm, I recently tested it with the mentioned bugfix from @MaxMan, but in my project it doesnt work. I have the following:

1. GameControlLayer (CCNode)
2. attached "Level" CCNode with level.tileMap = HKTMXTileMap
3. level.scale = 2.0f; (due to retro effect)

The screen remains blank (except controls and player sprite), if I use level.scale = 1.0f it works, but something is messed up with the positioning of the tmx layer and the texture stuff is somewhat antialiased with lines (the old fashioned artifacts). I am using a pixel perfect retro look so I am confused a bit now.

May I find a fix for that, tilesetInfo.imageSize = CC_SIZE_POINTS_TO_PIXELS(texture_.contentSize); does not really work for me if other parentlayers are scaled > 1.0f

Posted 6 months ago #
peng90
Member

HKTMXTiledMap is really helpful for crazy large maps but I still have one question.
Is there a way I can load more tiles than just the size of the screen? I have a map that can rotate at some angle, but when the map rotates, it seems like the map won't load tiles that were not in screen therefore I got a blank area after rotate the map for a certain angle... I looked into the HKTMXLayer.m and figured out how to load more tiles extending in positive x and y direction but I can't figure out how to extend the size of the map into negative x and y direction. I tried to set the offset but it did work. Any help would be greatly appreciated... thanks everyone...

Posted 6 months ago #
skyhawk
Member

in HKTMXLayer.h there is a SCALE LIMIT, this allows you to support more tiles on the map than the default screen.
See comment right above it.

Posted 6 months ago #
peng90
Member

@skyhawk, thx for ur reply. I changed that value but it only increase the number of tiles in positive x and y direction. I want it to increase the number of tile in negative x and y direction as well. Is there a way to do that?

Posted 6 months ago #
skyhawk
Member

not off the top of my head, no.

Posted 6 months ago #
peng90
Member

@skyhawk, thank you... i think that way is a dead end now... do you think I can shift up (and right) the view to achieve the same effect that I want then? many many thanks....

Posted 6 months ago #
vennt
Member

Haven't been able to get this to work. Is there a test project somewhere which will run without many modifications?

Posted 5 months ago #
peng90
Member

@vennt, what I did is just include those h and m files for the extension (you need that HKTMXTiledMap and HKTMXLayer, 4 files in total) in your project then include those h file and use it exactly like the CCTMXTiledMap, only change the name. They will work.

Posted 5 months ago #
greyhoundgames
Member

I also tried to use this for the sequel to our successful RPG Dragon Island. My original problem was not bad performance(im sure it would have come) but just that layers with tons of tiles(our tmx file is 320x300) just didnt render at all until we cut the # of tiles wayyyyy down.

After I dropped in this code I got a crash during rendering in:
CCTextureAtlas -(void) drawNumberOfQuads: (NSUInteger) n fromIndex: (NSUInteger) start

EXC BAD ACCESS in the else block of:
#if CC_TEXTURE_ATLAS_USE_TRIANGLE_STRIP
glDrawElements(GL_TRIANGLE_STRIP, (GLsizei) n*6, GL_UNSIGNED_SHORT, (GLvoid*) (start*6*sizeof(indices_[0])) );
#else
glDrawElements(GL_TRIANGLES, (GLsizei) n*6, GL_UNSIGNED_SHORT, (GLvoid*) (start*6*sizeof(indices_[0])) );
#endif // CC_TEXTURE_ATLAS_USE_TRIANGLE_STRIP

I used both the updated code example here and the later bug fix but neither helped with this issue.
Its late so I will look into this more in the morning but thought I would check if anyone else had encountered this error.

Posted 5 months ago #
greyhoundgames
Member

Update on this, for some reason this crash is coming from the directors SPFLabel when this HKTMXTiledMap is used. Not the actual map thats having the exception. On further investigation adding this map during startup causes no problems, adding it as a CCTMXTiledMap when its actually supposed to be added causes no problems, but adding any HKTMXTiledMap (even a small tiny one) later in the games lifecycle causes this bug to appear.. Its almost like memory is being corrupted for some reason.

I Tracked the line of code thats causing this to happen down. It happens during creation of the layers which uses the HKTMXLayer class. In there its doing this:

#if __IPHONE_OS_VERSION_MAX_ALLOWED
glUnmapBufferOES(GL_ARRAY_BUFFER);
#elif __MAC_OS_X_VERSION_MAX_ALLOWED
glUnmapBuffer(GL_ARRAY_BUFFER);
#endif
// allocate texcoord buffer
glBindBuffer(GL_ARRAY_BUFFER, buffers_[1]);
glBufferData(GL_ARRAY_BUFFER, screenTileCount * 4 * 2 * sizeof(GLfloat), NULL, GL_DYNAMIC_DRAW);
// allocate index buffer
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, buffers_[2]);
glBufferData(GL_ELEMENT_ARRAY_BUFFER, screenTileCount * 6 * sizeof(GLushort), NULL, GL_DYNAMIC_DRAW);

glBindBuffer(GL_ARRAY_BUFFER, 0);
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, 0);

If i comment out everything from here down there is no problem. Specifically it breaks when the
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, buffers_[2]);
glBufferData(GL_ELEMENT_ARRAY_BUFFER, screenTileCount * 6 * sizeof(GLushort), NULL, GL_DYNAMIC_DRAW);

is allowed to happen. Because it works ok earlier in my app, im wondering if some GL state should be reset before this happens or something like that.

Posted 5 months ago #
greyhoundgames
Member

Some more info on this. If i use this class on my very first scene and do nothing else it works. If I do the exact same thing but delay adding the map until the intial creation \on enter finishes using
[self performSelector:@selector(test) withObject:nil afterDelay:0];

It then blows up.

Posted 5 months ago #
rakkarage
Member

For one shot animations:
* If you add a delay, but no Next on the last frame of the animation, then after that delay, it will remove the tile (eg. for an explosion)
* if you do not add a delay, then the last frame will continue on forever without being updated (eg a bush rustling as you walk through it)

It should be noted that if you setatilegid to the start of a one shot animation before the same oneshotanimation finishes (no matter where it is on the map), it will reset the loop for all of them

can you see anyway around this?
since the last frame continues forever, any other bush i rustle will cause all previously rustled bushes to rustle again it seems?

thanks a lot

Posted 5 months ago #
skyhawk
Member

rakkarage: probably using the "experimental feature" (which will get you a normal CCSprite from a tile).

Posted 5 months ago #

ffede81
Member

Hey @skyhawk nice job!

I am using Cocos2d 2.1 beta4 and I would really want to use HKTMXTiledMap just for animation. If I use it directly I get the error "Only one tileset per layer is supported", so what I did was trying to apply the animation part of the HKTMXLayer to CCTMXLayer bundled in Cocos2D 2.1

By tweaking some stuff I managed to make it run and using a lot of breakpoints and CCLOGs I see that it goes through pretty well, the game starts but the stuff I want to animate doesn't animate at all unfortunately.

So, here are the methods I've modified in CCTMXLayer.m. Could you please check it?

-(id) initWithTilesetInfo:(CCTMXTilesetInfo*)tilesetInfo layerInfo:(CCTMXLayerInfo*)layerInfo mapInfo:(CCTMXMapInfo*)mapInfo
{
	// XXX: is 35% a good estimate ?
	CGSize size = layerInfo.layerSize;
	float totalNumberOfTiles = size.width * size.height;
	float capacity = totalNumberOfTiles * 0.35f + 1; // 35 percent is occupied ?

	CCTexture2D *tex = nil;
	if( tilesetInfo )
		tex = [[CCTextureCache sharedTextureCache] addImage:tilesetInfo.sourceImage];

	if((self = [super initWithTexture:tex capacity:capacity])) {

		// layerInfo
		self.layerName = layerInfo.name;
		layerSize_ = size;
		tiles_ = layerInfo.tiles;
		//minGID_ = layerInfo.minGID;
		//maxGID_ = layerInfo.maxGID;
        minGID_ = tilesetInfo.firstGid;
        maxGID_ = minGID_
        + (tilesetInfo.imageSize.width - tilesetInfo.margin * 2 + tilesetInfo.spacing)
        / (tilesetInfo.tileSize.width + tilesetInfo.spacing)
        * (tilesetInfo.imageSize.height - tilesetInfo.margin * 2 + tilesetInfo.spacing)
        / (tilesetInfo.tileSize.height + tilesetInfo.spacing)
        - 1;
		opacity_ = layerInfo.opacity;
		self.properties = [NSMutableDictionary dictionaryWithDictionary:layerInfo.properties];

		// tilesetInfo
		self.tileset = tilesetInfo;

		// mapInfo
		mapTileSize_ = mapInfo.tileSize;
		layerOrientation_ = mapInfo.orientation;

		// offset (after layer orientation is set);
		CGPoint offset = [self calculateLayerOffset:layerInfo.offset];
		[self setPosition:CC_POINT_PIXELS_TO_POINTS(offset)];

		atlasIndexArray_ = ccCArrayNew(totalNumberOfTiles);

		[self setContentSize:CC_SIZE_PIXELS_TO_POINTS(CGSizeMake( layerSize_.width * mapTileSize_.width, layerSize_.height * mapTileSize_.height ))];

		useAutomaticVertexZ_= NO;
		vertexZvalue_ = 0;

        //CCLOG(@"tileproperties %@",mapInfo.tileProperties);

        // --= set up animations =--
        // XXX should belong to tileset or map to avoid redundancy
        __block int animCount = 0;
        // read relevant tile properties from the map
        animRules_ = calloc(maxGID_ - minGID_ + 1, sizeof *animRules_);
        animCache_ = calloc(maxGID_ - minGID_ + 1, sizeof *animCache_);
#if NS_BLOCKS_AVAILABLE
        [mapInfo.tileProperties enumerateKeysAndObjectsUsingBlock:
         ^(id key, id obj, BOOL *stop)
         {
             CCLOG(@"key %@",key);
             CCLOG(@"obj %@",obj);
             CCLOG(@"minGID %i",minGID_);
             unsigned int idx = [key unsignedIntValue] - minGID_;
             CCLOG(@"idx %i",idx);
             CCLOG(@"maxGID %i",maxGID_);
             if (idx > maxGID_) return;
             unsigned int next = [[obj objectForKey:@"Next"] intValue];
             double delay = [[obj objectForKey:@"Delay"] doubleValue];
             if (next && delay > 0) {
                 animRules_[idx].delay = delay;
                 animRules_[idx].next = next;
                 animCount++;
             }
             else if(delay > 0)
             {
                 animRules_[idx].delay = delay;
             }

         }];
#else

        for(id key in [mapInfo.tileProperties keyEnumerator])
        {
            unsigned int idx = [key unsignedIntValue] - minGID_;
            if (idx > maxGID_) continue;
            id obj = [mapInfo.tileProperties objectForKey:key];
            unsigned int next = [[obj objectForKey:@"Next"] intValue];
            double delay = [[obj objectForKey:@"Delay"] doubleValue];
            if (next && delay > 0) {
                animRules_[idx].delay = delay;
                animRules_[idx].next = next;
                animCount++;
            }
            else if(delay > 0)
            {
                animRules_[idx].delay = delay;
            }
        }
#endif
        // find animation cycles and annotate
        for (int gid=minGID_; gid <= maxGID_; gid++)
        {
            struct CCTMXAnimRule *rule = animRules_ + (gid - minGID_);
            if (!rule->next)
            {
                // no animation here
                rule->last = gid;
            }
            else if (!rule->cycleTime && !rule->last)
            {
                animCount++;
                rule->cycleTime = rule->delay;
                unsigned int state = rule->next;
                while (1)
                {
                    // found loop
                    if (state == gid) break;
                    // found endpoint
                    if (!animRules_[state - minGID_].next)
                    {
                        rule->last = state;
                        break;
                    }
                    // keep looking
                    rule->cycleTime += animRules_[state - minGID_].delay;
                    state = animRules_[state - minGID_].next;
                }
                // XXX propagate result forward through the cycle to avoid quadratic startup lag
            }
        }
        animClock_ = 0.0;
        //dirtyAt_ = -INFINITY;
        if (animCount > 0)
            [self scheduleUpdate];
    }
    return self;
}

- (void) update: (ccTime) delta
{
	animClock_ += delta;
}

Posted 3 months ago #

skyhawk
Member

the init only sets up the animation cycles and the update only updates the clock.

All the animation work is done in draw

The better thing to do is fix the error.
1) First, if using 2.0, make sure you have https://github.com/cocos2d/cocos2d-iphone-extensions/tree/develop-v2 (unsure if it has fixes from this thread).
2) make sure every layer has at least 1 tile
3) make sure every layer has no more than 1 tilemap

Posted 3 months ago #
ffede81
Member

This one is indeed a different one from the branch I used, though it has much more errors I had to fix (like the superclass for the HKTMXLayer who doesn't exist in 2.1).

Anyway, I'm still getting the "TMX: Only one tileset per layer is supported" though I have everything in one tileset and all my layers have at least one tile.

That's a pity because it is a great class and would really save me tons of time animating tiles one by one in my code. Anyway, I hope a 2.x compatibility will be released soon :)

Posted 3 months ago #
iKonrad
Member

Yeah amazing piece of software. Do you plan to support isometric tilemaps as well? That would be lovely.

Posted 3 months ago #
skyhawk
Member

@ffede81: sorry. I can't think of immediately what your problem is if it isn't 1 of the 3 things.

Might also be related to tile flipping/rotation (though I thought we had fixes for all of those)

@iKonrad: I have no immediate plans to support isometric. It's a much harder and different beast than ortho to optimize and support the few features that I do have. Maybe one day, but as it doesn't directly help my case (ortho RPG) investing a lot of time (in what little I have) in it isn't in my agenda. That being said, I do support submissions / pulls to add features.

Posted 3 months ago #
rakkarage
Member

i am using it in 2.1
i do not get that error
maybe you have a simple test file that shows the problem?

Posted 3 months ago #
skyhawk
Member

@ffede81 your problem is you didn't apply the fix here: http://www.cocos2d-iphone.org/forum/topic/17945/page/8#post-196033 if you're running in retina mode.

The Latest versions of HKTMXTiledMap found here(ish)
http://hkasoftware.com/fileserve/HKTMXTiledMap/

2.1 is hosted here:
http://hkasoftware.com/fileserve/HKTMXTiledMap/cocos2d2.1/HKTMXTiledMap.zip

1.1 is hosted in 2 places:
* https://github.com/skyhawk2891/cocos2d-iphone-extensions/tree/HKTMXTiledMap/Extensions/HKTMXTiledMap
* http://hkasoftware.com/fileserve/HKTMXTiledMap/cocos2d1.1/HKTMXTiledMap.zip

These files should have all fixes applied (might be worthwhile for riq to update his version with the small fix)

Posted 3 months ago #
ffede81
Member

Thanks for the updated link!

The fact is that I keep getting this error with the new version in HKTMXTiledMap line 87:

@interface HKTMXLayer : CCNodeRGBA <CCBlendProtocol>

Cannot find interface declaration for 'CCNodeRGBA', superclass of 'HKTMXLayer'

In order to fix it I can simply replace CCNodeRGBA with CCNode (is it safe enough?)

Another issue is for CGPointExtension import which should be fixed from:

#import "Support/CGPointExtension.h"

to

#import "CGPointExtension.h"

And in HKTMXTiledMap at line 178 need to change:

_children to children_ (this has probably already been fixed in 2.1rc0, while I'm using beta4)

After these changes I get the following EXC_BAD_ACCESS error in CCTextureAtlas class, line 519:

#if CC_TEXTURE_ATLAS_USE_TRIANGLE_STRIP
glDrawElements(GL_TRIANGLE_STRIP, (GLsizei) n*6, GL_UNSIGNED_SHORT, (GLvoid*) (start*6*sizeof(indices_[0])) );
#else
glDrawElements(GL_TRIANGLES, (GLsizei) n*6, GL_UNSIGNED_SHORT, (GLvoid*) (start*6*sizeof(indices_[0])) );
#endif

I think it's caused by the CCNodeRGBA class which is actually missing and that I replaced with CCNode. Could that be?

Anyway, in the game I'm developing I'm massively using the CCSprite tiles behavior. I know that there's an experimental class included in your project that could help me in this way, but I will probably keep using the standard CCTMXTiledMap class for now and live with some manual work, I'm used to it, no problem :)

Posted 3 months ago #
riq
Key Master

@skyhawk:

if possible, could you send me a pull request with your latest changes ?
I placed it here:
https://github.com/cocos2d/cocos2d-iphone-extensions/tree/develop-v2

thanks.

Posted 3 months ago #
skyhawk
Member

@rakkarage, your version: does it use #import "Support/CGPointExtension.h" or #import "CGPointExtension.h"
(seems like it's entirely dependent on the users search paths)

Posted 3 months ago #
rakkarage
Member

i had to remove the Support/

Posted 3 months ago #
Richard
Member

I'm having a problem with the latest HKTMXTiledMap from either https://github.com/cocos2d/cocos2d-iphone-extensions/tree/develop-v2 or http://hkasoftware.com/fileserve/HKTMXTiledMap/cocos2d2.1/HKTMXTiledMap.zip with cocos-2.1-rc0a

Basically if I have the director showStats:YES on it crashes as soon as the tilemap is rendered with the same crash location as @ffede81 reports above, but the call stack has it as being called from [CCDirector showStats] for the crash.

With showStats:NO it runs fine. tileMap is 200x200, just one layer being shown with one object layer containing one object.

Posted 3 months ago #
skyhawk
Member

provide a project please or tmx map for us to look at.

Posted 3 months ago #
Richard
Member

Project demonstrating the crash I see:

https://github.com/richardgroves/HKTMXTiledMap-crash.git

Examine HellowWorldLayer.m

Code at line 68 causes the crash (adding a HKTMXTiledMap from a menu item click), the same code run during init flow (line 87 of that file) doesn't crash.

Tilemap has had project confidential information wiped so it looks a bit odd, but demonstrates the problem.

Thanks,
Richard

Posted 3 months ago #
skyhawk
Member
in your ccConfig.h
set
```
#define CC_TEXTURE_ATLAS_USE_VAO 0
```
Posted 3 months ago #
Richard
Member

@skyhawk: Thanks that fixes it. Looks like @greyhoundgames was having the same problem above.

Is there any way for the code to assert that #define is the correct value - either at compile time if it should always be 0, or run time if the tilemap is too big to handle using the vertex array objects (I'm assuming it's an OpenGL memory/resource problem and too many vertex array objects are being created by a large tilemap?)

Posted 3 months ago #

RSS feed for this topic

« Previous 1…8910 Next »

Reply »

You must log in to post.