cocos2d for iPhone

A fast, easy to use, free, and community supported 2D game engine

1. 

   jd
   Member

   NSArray *j = [[AppDelegate get].upgradesMenu children];
   MenuItem *m = [j objectAtIndex: u.weaponID];
   m.isEnabled = ([AppDelegate get].cash >= u.cost) ? YES : NO;

   I want to set MenuItem at a specific index to YES or NO depending cash available vs. cost. Is there a way to combine these 3 lines into one line so I don't have to create temp objects? Am I being a nit?

   Posted 2 years ago #
2. 

   Codemattic
   Moderator

   seriously? I guess:

   [[[[AppDelegate get].upgradesMenu children] objectAtIndex: u.weaponID] setIsEnabled:(([AppDelegate get].cash >= u.cost) ? YES : NO)];

   but its ugly, maybe stick with your more readable code with the temp objects.

   Posted 2 years ago #
3. 

   jd
   Member

   Is it more efficient as 1 or 3? I'm originally from a perl background.

   Posted 2 years ago #
4. 

   Codemattic
   Moderator

   Get your app working first, optimize last. The difference here is too negligible to bother with, do whichever coding style works for you.

   Posted 2 years ago #
5. 

   psionic
   Member

   I agree.. optimize if and when you need to. The iPhone is a
   tremendously fast device (speaking from a standpoint of working w/ the
   original 80/88 and seeing the progression), just turn on showFPS in
   the Director and try to keep the fps above 30.

   Chris.

   On Thu, Jun 18, 2009 at 12:20 AM,
   <cocos2d-iphone-discuss@gamesforfood.cl> wrote:
   > codemattic says:
   >
   > Get your app working first, optimize last. The difference here is too
   > negligible to bother with, do whichever coding style works for you.
   >
   > Read the whole thread.

   Posted 2 years ago #
6. 

   Cypher
   Member

   My preference is for code readability. And in this case that means creating the necessary temporary variables on the stack and then have them get destroyed when we leave the function..

   I imagine that the iPhone would execute those 3 lines of code or the three lines munged into one long one at about the same rate, so you don't gain any performance or speed. But what you lose is readability which is crucial when you have to come back some time later to figure out what a piece of code is doing. :)

   Posted 2 years ago #
7. 

   tjweir
   Member

   >My preference is for code readability.

   Amen. That will pay more dividends than collapsing the calls.

   Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.