MenuItemImage and selector « cocos2d for iPhone

cocos2d for iPhone » Programming » cocos2d support (graphics engine)

MenuItemImage and selector

(11 posts) (3 voices)

Started 2 years ago by Wizermil
Latest reply from Wizermil

Tags:

Wizermil
Member

Hello,

I have absolutely no idea what is going wrong with my code but I cannot call a method from a click on a button. If anybody have any leads or tips to fix this issue it'll be cool.

(Sorry I don't know the tag to format the src code below)
Layer *layer = [[Layer alloc] init];
layer.isTouchEnabled = YES;

_music_btn = [MenuItemImage itemFromNormalImage:@"btn_music.png" selectedImage:@"btn_music.png" target:self selector:@selector(clickHandler:)];
_sound_btn = [MenuItemImage itemFromNormalImage:@"btn_sound.png" selectedImage:@"btn_sound.png" target:self selector:@selector(clickHandler:)];
_quality_btn = [MenuItemImage itemFromNormalImage:@"btn_quality.png" selectedImage:@"btn_quality.png" target:self selector:@selector(clickHandler:)];
Menu *menuBottomRight = [Menu menuWithItems: _music_btn,_sound_btn,_quality_btn,nil];
menuBottomRight.position = ccp( size.width -28/2-5, (28*3+10*3)/2 );
[menuBottomRight alignItemsVerticallyWithPadding:10.0];
[layer addChild:menuBottomRight];
/* ......

I add other Menus to the layer

*/

[self.manager.container addChild:layer]; //self.manager.container is layer attached to a scene
/* ......*/
-(void) clickHandler:(id)e {
NSLog(@"["__FILE__":%i] clickHandler",__FILE__,__LINE__);
}

Below you can see an error message appearing when I click on the last MenuItemImage of the last Menu added to the layer:

#0 0x918f8688 in objc_msgSend ()
#1 0x3024a10d in __invoking___ ()
#2 0x30249ff8 in -[NSInvocation invoke] ()
#3 0x0001de17 in -[MenuItem activate] (self=0xe24ec0, _cmd=0x9195934c) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/MenuItem.m:99
#4 0x0001b0f4 in -[Menu ccTouchEnded:withEvent:] (self=0xe60a60, _cmd=0x368c7, touch=0x6805b30, event=0xe13bf0) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/Menu.m:198
#5 0x0002d9e9 in -[TargetedTouchHandler updateKnownTouches:withEvent:selector:unclaim:] (self=0xe8a790, _cmd=0x3a33c, touches=0x689f7b0, event=0xe13bf0, selector=0x368c7, doUnclaim=1 '01') at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/TouchHandler.m:170
#6 0x0002d82f in -[TargetedTouchHandler ccTouchesEnded:withEvent:] (self=0xe8a790, _cmd=0x36846, touches=0x689f7b0, event=0xe13bf0) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/TouchHandler.m:153
#7 0x0002ca4e in -[TouchDispatcher touchesEnded:withEvent:] (self=0xe21230, _cmd=0x3199fa0c, touches=0x689fb80, event=0xe13bf0) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/TouchDispatcher.m:187
#8 0x000237f4 in -[EAGLView touchesEnded:withEvent:] (self=0xe1b320, _cmd=0x3199fa0c, touches=0x689fb80, event=0xe13bf0) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/Support/EAGLView.m:305
#9 0x30910fdf in -[UIWindow _sendTouchesForEvent:] ()
#10 0x308faecb in -[UIApplication sendEvent:] ()
#11 0x309013e1 in _UIApplicationHandleEvent ()
#12 0x32046375 in PurpleEventCallback ()
#13 0x30245560 in CFRunLoopRunSpecific ()
#14 0x30244628 in CFRunLoopRunInMode ()
#15 0x32044c31 in GSEventRunModal ()
#16 0x32044cf6 in GSEventRun ()
#17 0x309021ee in UIApplicationMain ()
#18 0x000028d4 in main (argc=1, argv=0xbfffef10) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/main.m:13

Thanks in advance for your help

Posted 2 years ago #
Codemattic
Moderator

The tag to format src code is to put a backtick before and after it.

Instead of the NSLog you have, try NSLog(@"this is a test");

Otherwise it looks ok. I assume that -clickHandler: is a method in the same object where you build the menus.

Posted 2 years ago #
Blue Ether
Member

Yeah your NSLog looks pretty messed up to me.
NSLog(@"["__FILE__":%i] clickHandler",__FILE__,__LINE__);

For one, you need to use the escape character to put quotes in your formatting string. For another, you are passing two arguments but only printing one of them. If __FILE__ is a string, then you should use %s instead of __FILE__ in the formatting string.

NSLog(@"[\"%s\":%i] clickHandler",__FILE__,__LINE__);

Posted 2 years ago #
Wizermil
Member

(Codematic thanks for the tip)

I 100% agree this NSLog code is a mess, but commenting this code or changing it to a simple string doesn't change anything.

My current container is a class extending Layer is it possible that because I didn't override some methods the target and the selector are not registered ? This will explain why the the method is not called isn't it ? However it won't explain the error on clicking on the last item of the last added menu.

Posted 2 years ago #
Codemattic
Moderator

"is it possible that because I didn't override some methods the target and the selector are not registered"

doesnt sound like thats the problem. Do all of the menuitems fail - or just the last one?

Posted 2 years ago #
Wizermil
Member

Just the last one

Posted 2 years ago #
Codemattic
Moderator

well that doesnt make sense! If you dont add _quality_btn, does the _sound_btn now cause it to crash, i.e. is always the last button that crashes, or is it a problem with _quality_btn?

Posted 2 years ago #
Wizermil
Member

It's just an area of the screen, in fact it's the last area I used for another Layer to display an MenuItem. But before displaying this new layer a called
removeChild: cleanup:YES
Do I have to do remove all the component I added to the Layer or a called to removeChild will unregistered a free all the component I used for a Layer ?

Posted 2 years ago #

Wizermil
Member

Step by step t's better so know the las layer is well released, I forget the retain after the addChild.
So all the items of the previous layer are correctly deallocated and the menuitem of the new layer are all generating this error message:

#0  0x918f868c in objc_msgSend ()
#1  0x0002d427 in -[StandardTouchHandler ccTouchesBegan:withEvent:] (self=0xe24210, _cmd=0x36876, touches=0xe9e600, event=0xe13bf0) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/TouchHandler.m:74
#2  0x0002c824 in -[TouchDispatcher touchesBegan:withEvent:] (self=0xe22440, _cmd=0x3199fa3c, touches=0x682c560, event=0xe13bf0) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/TouchDispatcher.m:153
#3  0x000238d7 in -[EAGLView touchesBegan:withEvent:] (self=0xe1b2c0, _cmd=0x3199fa3c, touches=0x682c560, event=0xe13bf0) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/cocos2d/Support/EAGLView.m:289
#4  0x30910f33 in -[UIWindow _sendTouchesForEvent:] ()
#5  0x308faecb in -[UIApplication sendEvent:] ()
#6  0x309013e1 in _UIApplicationHandleEvent ()
#7  0x32046375 in PurpleEventCallback ()
#8  0x30245560 in CFRunLoopRunSpecific ()
#9  0x30244628 in CFRunLoopRunInMode ()
#10 0x32044c31 in GSEventRunModal ()
#11 0x32044cf6 in GSEventRun ()
#12 0x309021ee in UIApplicationMain ()
#13 0x00002aa8 in main (argc=1, argv=0xbfffef10) at /Users/wizermil/Desktop/Work/uphill_rush_2/code/tmp/Test/main.m:13

Posted 2 years ago #

Wizermil
Member

Could It be linked to the TouchDispatcher registering my old removed Layer ?

Posted 2 years ago #
Wizermil
Member

I found a way to fix my bug. I was trying to use only one scene and multi layers, releasing asap the useless layers. It seems the approach was not the right one, so now I'm back to a multi scene app and no more problems with the TouchDispatcher.

Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.