cocos2d for iPhone

A fast, easy to use, free, and community supported 2D game engine

1. 

   fionel
   Member

   I made the function below to update my game's score labelAtlas. However, SOMETIMES I would get an EXC_BAD_ACCESS after this function has returned. As you can see I am creating the 2 NSMutableString with alloc/init and am releasing them at the end of the function, so I really don't understand what I'm doing wrong. I also tried using the class constructor and autorelease and my app still crashes at the same spot. Any sort of advice would be greatly appreciated.

   -(void)updateScore:(int)scoreType
   {
   int score;
   if (scoreType == 0 ) {
   score = gameScore;
   }
   else {
   score = g_hiScore;
   }

   NSMutableString *str = [[NSMutableString alloc] init];
   NSMutableString *scoreStr = [[NSMutableString alloc] initWithFormat:@"%d", score];
   NSInteger blankLen = 12-[scoreStr length];
   for ( int i = 0; i < blankLen; i++ ) {
   [str appendString:@":"];
   }
   [str appendString:scoreStr];
   if ( scoreType == 0 ) {
   [scoreLabel setString:str]; // update labelAtlas
   }
   else {
   [hiScoreLabel setString:str];
   }
   NSLog(str);
   [str release];
   [scoreStr release];
   }

   Posted 2 years ago #
2. 

   Codemattic
   Moderator

   I dont see any memory errors. Are you sure scoreLabel and hiScoreLabel point to valid labels?

   FYI - when posting code, put backticks before and after so its formatted as code and will be easier to read. Also, if you are updating your score labels very often you may want to look in to using a LabelAtlas.

   Step through this function (or put a bunch of NSLog()s in your code) and find out exactly where you are blowing up.

   Posted 2 years ago #
3. 

   fionel
   Member

   Oops, missed the note about backticks.

   scoreLabel and hiScoreLabel are indeed LabelAtlas and member variables of my game layer and are defined in -init: as follows:

   scoreLabel = [[LabelAtlas labelAtlasWithString:@":::::::::::0" charMapFile:@"oa07.png" itemWidth:16 itemHeight:16 startCharMap:'0'] retain];
   		scoreLabel.position = ccp( 82, 434 );
   		[self addChild:scoreLabel z:2];
   		hiScoreLabel = [[LabelAtlas labelAtlasWithString:@":::::::::::0" charMapFile:@"oa07.png" itemWidth:16 itemHeight:16 startCharMap:'0'] retain];
   		hiScoreLabel.position = ccp( 82, 455 );
   		[self addChild:hiScoreLabel z:2];

   Both labelAtlas are released in the layer's dealloc, but I don't think it matters here. Funny thing is in my updateScore function, if I dropped the release for the 2 strings, then it seems like I won't get the error. Of course it's not a fix because it's a memory leak. Very puzzled here...

   Posted 2 years ago #
4. 

   Codemattic
   Moderator

   Fionel, I could be wrong but dont see the memory error here. The thing about memory leaks is that they can occur one place, but give you an error somewhere else. For example:

   int intArray[10];
   LabelAtlas * scoreLabel;
   ...

   so if somewhere else in your code you made the easy mistake of:

   intArray[10]=0;

   you would be writing over the scoreLabel pointer. So also check your code around where scoreLabel and hiScoreLabel are defined. Maybe the bug is in another part of the code you arent looking at.

   sorry couldnt be more help, Codemattic

   Posted 2 years ago #
5. 

   fionel
   Member

   Codemattic, Thanks a lot for your advice. I think I found the cause for the EXC_BAD_ACCESS which is not memory-related as I was led to believe, but was an infinite recursive loop somewhere else in the code. I should have learned how to use the stack frame more in the first place!

   Well, here's hoping that was the only cause of the problem! Thanks again for your time!

   Posted 2 years ago #
6. 

   Codemattic
   Moderator

   you are welcome - glad you got it!

   Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.