cocos2d for iPhone

A fast, easy to use, free, and community supported 2D game engine

1. 

   natanavra
   Member

   Hey...
   I've been testing my game for quite sometime and made a tweak for user input, so I won't get user input when the game is finished,
   so I added this line of code to my gameLayer :

   - (void)gameOver {
        state = kStateOver;
        isTouchEnabled = NO;
       .....
   }

   And then after sometime I return to the main menu, and the app would crash whenever I click on a MenuItem in my menu scene... I tracked the crash through the debugger and I got to the TouchHandler... and it says (NSSet *)touches is empty, no objects inside...
   After digging in code for hours, I removed the isTouchEnabled = NO line, and viola - everything is working....

   So my point is, if I defined at a certain layer to not receive touches, touchHandler won't change it back whenever I replace the scene/layer....
   I don't know if it's a bug or maybe it's just the wrong approach...
   I could create a test application that simulates the bug if you want Riq...

   ~ Natan Avra.

   Posted 2 years ago #
2. 

   riq
   Key Master

   It might be a bug, but I'm not sure.
   could you post the (if possible the minium) code the reproduce it ? thanks.

   Posted 2 years ago #
3. 

   natanavra
   Member

   Hmm I tried reproducing the bug in a separate project, but I can't seem to get it...
   It's possible that the bug was specific to my code...
   I copy pasted code from my game to the test project, but no bug...
   It's really weird, I was certain it was a bug with the isTouchEnabled property in relation to the TouchHandler...

   Well, if I ever encounter this bug again, I'll be sure to test first and declare later...

   Posted 2 years ago #
4. 

   etabubu
   Member

   Shouldn't your "isTouchEnabled = NO" be "self.isToucheEnabled = NO" ? I did this mistake few weeks ago!

   Posted 2 years ago #
5. 

   natanavra
   Member

   it doesn't really matter from my experience...
   isTouchEnabled is a property of layer, and we subclass it - meaning that property is sub-classed as well and if it's a property you can access it directly as a variable...
   The way I define isTouchEnabled works just fine so if it works, I guess it's not much of a mistake...

   Posted 2 years ago #
6. 

   riq
   Key Master

   you should use self.isTouchEnabled because the property has more functionality than getting/setting a BOOL value.

   Posted 2 years ago #
7. 

   adunsmoor
   Member

   @riq, This is a fairly recent change, correct? (8.0, I think)

   Since there is now a side effect of setting the isTouchEnabled property it would be useful to make the instance variable private (or change the name). That way subclasses would be forced to use the dot notation or the setTouchEnabled method. Of course, that would break backward compatiblity so maybe it's not worth it.

   Without following the changes very closely it's easy to miss these types of things. If @etabubu hadn't asked I wouldn't have noticed. Maybe I need to pay more attention :-)

   Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.