description of CCNode Address format

(5 posts) (4 voices)

Tags:

xinsight
Member
Is there a reason for using %08X to print the object address in the CCNode description method? The %p (pointer) format seems more common (0x069128E0 vs 069128E0) and it's also possible to copy/paste that pointer value right into gdb.

Here's the change i'm suggesting...
```
# CCNode.m
- (NSString*) description
{
	// return [NSString stringWithFormat:@"<%@ = %08X | Tag = %i>", [self class], self, tag_];
	return [NSString stringWithFormat:@"<%@ = %p | Tag = %i>", [self class], self, tag_];
}
```
(Repeat for all the other cocos2d classes... CCAction, CCAnimation, etc. ;)
Posted 1 year ago #
Benihana
Member

I think it keeps them nice and lined up for us. ;d

Posted 1 year ago #
Lam
Member

This makes a lot of sense and it's easy and quick to patch in!
Quick! Leeroy! Give the man a raise!

Leeroy: He doesn't work for us....

Posted 1 year ago #
TBBle
Moderator

I support this change too. ^_^

Posted 1 year ago #
xinsight
Member

Ah, true, there are no leading zeros with the %p formatter. Pro: pointer strings are all the same lenght. Con: the 0x added when trying to get a value from gdb (and the number doesn't look like a pointer).

Well, maybe it's a personal preference. Anyways, it's easy to tweak the cocos2d core. Or you could also just override the description method for any subclasses of CCNode.

Posted 1 year ago #

Reply

You must log in to post.