A fast, easy to use, free, and community supported 2D game engine
When i replace my game scene to go back to the menu (i'm using spacemanager in the menu too) i get this huge memory leak. And if i replace it twice the app crashes.
image:
I am creating about a 100 static bodies in a loop in the gamescene, are they getting deallocated? (i'm just calling [spaceMgr release] in the deallocate method)
My replace scene transition is 0.5 seconds long if that has anything to do with it.
How do you fix this?
Please help and thanks in advance ;D
It's not a recursive issue, it's actually a known bug in SpaceManager.... unfortunately.
There's a discussion over on the SpaceManager forum here:
http://mobile-bros.com/forum/viewtopic.php?f=3&t=59
Basically static bodies never get added to the chipmunk space, so when SpaceManager asks chipmunk to clean up, those bodies are never found...
I should have a fix in the repository soon for this. In the meantime, the workaround is to set the spaceManager property and the autoFreeShape property to YES on any cpCCNode types owning static shapes; if these shapes don't have owning cpCCNodes then you have to keep a list of them and ask SpaceManager to delete them manually (barf).
As it turns out i am already using the spacemanager property and autorelease like this:
for (int i=1; i < numVerts; i++)
{
cpShape* shape = [spaceMgr addSegmentAtWorldAnchor:verts[i]
toWorldAnchor:verts[i-1]
mass:STATIC_MASS radius:1];
cpShapeNode* node = [cpShapeNode nodeWithShape:shape];
node.spaceManager = spaceMgr;
node.autoFreeShape = YES;
node.color = ccRED;
if (debugDraw < 1) {
node.visible = NO;
}
[gamelayer addChild:node z:999];
}How can i fix this?
Ok excellent, you just have to make sure you remove all children from your layer before you release the SpaceManager.
[self removeAllChildrenWithCleanup:YES];
[smgr release];I'm pretty positive that's all that needs to happen.
No improvements yet, still the same leaks...
Here is my dealloc method (plus comments)
- (void) dealloc
{
NSLog(@"game is being deallocated"); //just to make sure it gets called
self.isTouchEnabled = NO; //to prevent some memory leaks
[am release]; //audiomanager
[toneSource release]; //soundengine
[self removeAllChildrenWithCleanup:YES];
[spaceMgr release]; //releasing spacemanager
[super dealloc];
}This problem pretty much stops me from implementing new things into my game. But if you look on the bright side of this problem: More time for graphics and music creation!
Ok well just to be sure, you have "gamelayer" in your last snippet, if "gamelayer" is a child of self then yes this should work.
I should have a fix in very soon.. just have to do a few tests.
Yes, that's correct... I guess I'm at a loss as to why it won't free it. If you're doing this like you do above:
node.spaceManager = spaceMgr;
node.autoFreeShape = YES;That tells the cpShapeNode on it's dealloc method, that it should also ask the SpaceManager to removeAndFreeShape (and body).
If you feel comfortable doing so, breakpoint on the dealloc method in cpCCNodeImpl.m and see if that is really getting called.
The proper fix is now in the repository... still needs a bit more testing I think though just to be sure.
Hey, the dealloc method does get called in cpCCNodeImpl.m when switching from the menu to the gamescene and gamescene to menu. I tested it by adding this:
-(void) dealloc
{
NSLog(@"calling dealloc in: cpCCNodeImpl");
if (_shape)
{
NSLog(@"calling dealloc with if in: cpCCNodeImpl");
_shape->data = NULL;
if (_autoFreeShape)
NSLog(@"calling autoFreeShape in: cpCCNodeImpl");
[_spaceManager scheduleToRemoveAndFreeShape:_shape];
}
_shape = nil;
[super dealloc];
}But when switching to the menu from the gamescene i get an EXC_BAD_ACCESS, heres the backtrace:
2011-01-29 12:01:41.828 funky truck 3.0[21965:307] game is being deallocated
2011-01-29 12:01:41.877 funky truck 3.0[21965:307] calling autoFreeShape in: cpCCNodeImpl
Program received signal: “EXC_BAD_ACCESS”.
(gdb) bt
#0 0x339737d8 in objc_msgSend ()
#1 0x00009364 in -[cpCCNodeImpl dealloc] (self=0x25c910, _cmd=0x32ca2574) at /Users/svp/Documents/funky truck 3.0/src/cpCCNodeImpl.m:43
#2 0x34411532 in -[NSObject(NSObject) release] ()
#3 0x000089d8 in -[cpCCNode dealloc] (self=0x25c7f0, _cmd=0x32ca2574) at /Users/svp/Documents/funky truck 3.0/src/cpCCNode.m:31
#4 0x34411532 in -[NSObject(NSObject) release] ()
#5 0x34415984 in CFRelease ()
#6 0x3443bedc in -[__NSArrayM dealloc] ()
#7 0x34411532 in -[NSObject(NSObject) release] ()
#8 0x0009a910 in -[CCNode dealloc] (self=0x24cdb0, _cmd=0x32ca2574) at /Users/svp/Documents/funky truck 3.0/libs/cocos2d/CCNode.m:254
#9 0x34411532 in -[NSObject(NSObject) release] ()
#10 0x34415984 in CFRelease ()
#11 0x3443bedc in -[__NSArrayM dealloc] ()
#12 0x34411532 in -[NSObject(NSObject) release] ()
#13 0x0009a910 in -[CCNode dealloc] (self=0x25b170, _cmd=0x32ca2574) at /Users/svp/Documents/funky truck 3.0/libs/cocos2d/CCNode.m:254
#14 0x00006be4 in -[HelloWorld dealloc] (self=0x25b170, _cmd=0x32ca2574) at /Users/svp/Documents/funky truck 3.0/Classes/HelloWorldScene.m:393
#15 0x34411532 in -[NSObject(NSObject) release] ()
#16 0x34415984 in CFRelease ()
#17 0x3443bedc in -[__NSArrayM dealloc] ()
#18 0x34411532 in -[NSObject(NSObject) release] ()
#19 0x0009a910 in -[CCNode dealloc] (self=0x245190, _cmd=0x32ca2574) at /Users/svp/Documents/funky truck 3.0/libs/cocos2d/CCNode.m:254
#20 0x34411532 in -[NSObject(NSObject) release] ()
#21 0x000f0c70 in -[CCTransitionScene dealloc] (self=0x27cc80, _cmd=0x32ca2574) at /Users/svp/Documents/funky truck 3.0/libs/cocos2d/CCTransition.m:168
#22 0x34411532 in -[NSObject(NSObject) release] ()
#23 0x000745d8 in -[CCDirector setNextScene] (self=0x245f10, _cmd=0x10ab0f) at /Users/svp/Documents/funky truck 3.0/libs/cocos2d/CCDirector.m:747
#24 0x0007169c in -[CCDirector mainLoop] (self=0x245f10, _cmd=0x10ac2a) at /Users/svp/Documents/funky truck 3.0/libs/cocos2d/CCDirector.m:241
#25 0x00075f40 in -[CCDisplayLinkDirector preMainLoop:] (self=0x245f10, _cmd=0x10a94e, sender=0x24f770) at /Users/svp/Documents/funky truck 3.0/libs/cocos2d/CCDirector.m:1111
#26 0x3072d702 in CA::Display::DisplayLink::dispatch ()
#27 0x3072d826 in CA::Display::IOMFBDisplayLink::callback ()
#28 0x305d3bfa in IOMobileFramebufferVsyncNotifyFunc ()
#29 0x3404c046 in ?? ()
#30 0x34448312 in __CFMachPortPerform ()
#31 0x3443fce2 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ ()
#32 0x3443fca6 in __CFRunLoopDoSource1 ()
#33 0x3443256c in __CFRunLoopRun ()
#34 0x34432276 in CFRunLoopRunSpecific ()
#35 0x3443217e in CFRunLoopRunInMode ()
#36 0x3026b5f2 in GSEventRunModal ()
#37 0x3026b69e in GSEventRun ()
#38 0x31ad0122 in -[UIApplication _run] ()
#39 0x31ace12e in UIApplicationMain ()
#40 0x00002920 in main (argc=1, argv=0x2ffff558) at /Users/svp/Documents/funky truck 3.0/main.m:13You're getting a crash because you modified the code....
if (_autoFreeShape)
NSLog(@"calling autoFreeShape in: cpCCNodeImpl");
[_spaceManager scheduleToRemoveAndFreeShape:_shape];instead of:
if (_autoFreeShape)
{
NSLog(@"calling autoFreeShape in: cpCCNodeImpl");
[_spaceManager scheduleToRemoveAndFreeShape:_shape];
}Looks like you're using a version before 0.0.6 if there's a schedule call.... hmmm that's got to be the issue now that I think about it, it would tell spaceManager to clean up the shapes after the next time step..... which is bad. This is gone in 0.0.6 and calling removeAllChildrenWithCleanup should work!
phew! that was a crazy one.
No improvements, my app chrashes during a switch from the gamescene to the menu but never during menu to gamescene switch, this occurs both when i'm using [self removeAllChildrenWithCleanup:YES]; and also when im not using it. Here's a backtrack of the error:
2011-02-01 16:35:38.545 STW[26270:307] game is being deallocated
Program received signal: “EXC_BAD_ACCESS”.
Previous frame inner to this frame (gdb could not unwind past this frame)
Previous frame inner to this frame (gdb could not unwind past this frame)
(gdb) bt
#0 0x339737d8 in objc_msgSend ()
#1 0x000041b0 in -[cpCCNodeImpl dealloc] (self=0x36a8d0, _cmd=0x32ca2574) at /Users/svp/Documents/STW/src/ccExtras/cpCCNodeImpl.m:44
#2 0x000041b0 in -[cpCCNodeImpl dealloc] (self=0x32ca2574, _cmd=0x36a7e0) at /Users/svp/Documents/STW/src/ccExtras/cpCCNodeImpl.m:44I've used NSLog in CCNodeImpl and i see that the freeing of shapes only occur once in my gamescene and then it crashes, but i'm not using NSLog in this bt. The freeing of shapes occur six times in my menu (i'm using six shapes there) so the shapes in the menu gets dealloced. I have updated cocos2D, spacemanager and Chipmunk in a new clean xcodeproject.
Any fix for this mobilebros?
Ummm... well the error is on line 44, so this line:
[_spaceManager removeAndFreeShape:_shape];This would suggest that maybe _spaceManager is garbage? Can you post your dealloc method as it currently is.
Here it is (with some comments but thats what it looks like atm):
- (void) dealloc
{
NSLog(@"game is being deallocated");
self.isTouchEnabled = NO;
// [self stopAllActions];
// [am release];
// [toneSource release];
// [self removeAllChildrenWithCleanup:YES];
[spaceMgr release];
[gamelayer release];
[HUDlayer release];
[super dealloc];
}hmmm... gamelayer is being released after spaceMgr?... thats definitely it. Either move the release above [spaceMgr release]; or change:
[self removeAllChildrenWithCleanup:YES];to
[gamelayer removeAllChildrenWithCleanup:YES];gamelayer is the one with all the cpShapeNode's and such right? If that's being retained and released after the spaceManager, CCNodeImpl is going to use a bad spaceManager.
That worked!
Now it's calling autofreeshape in CCNodeImpl 104 times (101 ground segs and three for the player) so its getting called but i'm still getting memory leaks in different numbers, sometimes 29 and sometimes 50 and each one takes 128 bytes. So half of the problem is fixed but it does still leak, why?
hmmm the leak is still with the body free'ing code?
Yes its still leaking, here's my dealloc method too:
- (void) dealloc
{
NSLog(@"game is being deallocated");
self.isTouchEnabled = NO;
// [self stopAllActions];
// [am release];
// [toneSource release];
[gamelayer removeAllChildrenWithCleanup:YES];
[gamelayer release];
[HUDlayer release];
[spaceMgr release];
[super dealloc];
}Are you positive that you have autoFreeShape and spaceManager properties set (on all of them)... I can't really think of anything else that would be letting them leak. Also make sure you have the same removeAllChildrenWithCleanup call in your menu.
Now that i think about it i have a scheduled method (1/60 of a second) and i apply forces and angular velocity to my player on each call and in the menu i apply angular velocity by accelerometer. Does this have anything to do with the leaks, IOW those methods (dont know how to say this correctly in english) collide with the memory freeing methods and thus leaves 25-50% of my shapes unreleased. I'm currently off my computer so i can't test this right now, but do you think that's the problem mobilebros?
Sry for my english if it i misspelled and again thanks!
Oh... Actually chipmunk had a bit of a leak relating to collisions a little while ago (maybe 5.3.3); you should update your chipmunk and see if these leaks go away.
But then again I don't think it was cpBody free'ing that was the problem... so I'm not sure if that will solve anything.
You must log in to post.