cocos2d for iPhone

A fast, easy to use, free, and community supported 2D game engine

1. 

   etabubu
   Member

   Hi,

   I might have found a bug in CocosDenshion, correct me if I'm wrong.
   In my game, I preload few sound effects with this code:

   
SimpleAudioEngine *audioEngine = [SimpleAudioEngine sharedEngine];
[audioEngine preloadEffect:@"WrongTapEffect.wav"];
[audioEngine preloadEffect:@"RightTapEffect.wav"];
[audioEngine preloadEffect:@"MenuTapEffect.wav"];


   But then at some point later in the code I want to play an effect that I didn't preload.
   So I do:

   
[[SimpleAudioEngine sharedEngine] playEffect:@"BonusEffect.wav"];


   but instead of that wav, the first preloaded effect is played (WrongTapEffect).

   I took a look at the playEffect method in SimpleAudioEngine and I think that there's a mistake there. In case the effect has not been preloaded, it gets loaded on the fly, but the variable "soundId" is still nil and then it's used to retrieve a value with [soundId intValude] that probably returns 0 and that corresponds to the first preloaded effect.

   Sorry, if this is not the case!

   Posted 2 years ago #
2. 

   Joao Caxaria
   Member

   Hi,

   Yes, you are completely right. I actually fixed that in my code but totally forgot to warn Steve about it.

   As a quick fix, this should be the implementation:

   -(ALuint) playEffect:(NSString*) filePath pitch:(Float32) pitch pan:(Float32) pan gain:(Float32) gain
   {
   	NSNumber* soundId = (NSNumber*)[loadedEffects objectForKey:filePath];
   
   	if(soundId == nil)
   	{
   #ifdef ASSERT_DEBUG
   		@throw [[[NSException alloc] initWithName:@"SimpleAudioEngine::playEffect"
   										   reason:filePath userInfo:nil] autorelease];
   #else
   		[self preloadEffect:filename];
   		soundId = (NSNumber*)[loadedEffects objectForKey:filename];
   #endif
   	}
   
   	return [soundEngine playSound:[soundId intValue] channelGroupId:0 pitch:pitch pan:pan gain:gain loop:false];
   }

   Posted 2 years ago #
3. 

   Steve Oldmeadow
   Administrator

   It was already raised as an issue and I fixed it yesterday.

   Posted 2 years ago #

RSS feed for this topic

Reply

You must log in to post.