cocos2d for iPhone

A fast, easy to use, free, and community supported 2D game engine

1. 

   knbmedia
   Member

   Hi,

   I found a memory leak using CCSpriteFrameCache with (some) pvr.ccz files

   

   The leak seems to be only with SOME pvr.ccz files (i tried the same graphic in pvr and png format without problem)

   Step to reproduce:
   -> create a new project with cocos2d template
   -> in init method, add
   [[CCSpriteFrameCache sharedSpriteFrameCache] addSpriteFramesWithFile:@"XXX.plist"];

   Here is a link with some pvr.ccz files to test : http://www.knbmedia.com/cocos2d/leak.zip

   Posted 1 year ago #
2. 

   riq
   Key Master

   The .pvr.ccz files should all leak or non of them should leak.
   If some of them are leaking memory and other are not leaking memory, then I would say that Instruments is not working properly.

   Posted 1 year ago #
3. 

   TBBle
   Moderator

   A quick look at ccInflateCCZFile, it's not freeing "compressed" in any of the error-returns _or_ the success return.

   I dunno if it matters or not, but I note that ccLoadFileIntoMemory doesn't check for NULL return from malloc, but immediately freads into the returned pointer.

   Looking at f19bfeb81a111663ffaa4d1661083950d4035aee in the git repo.

   Posted 1 year ago #
4. 

   riq
   Key Master

   yes. Thanks!

   fixed:
   https://github.com/cocos2d/cocos2d-iphone/commit/c64b00fc407393906a059285a0601214bf3065c3

   Posted 1 year ago #
5. 

   TBBle
   Moderator

   You missed the "success" case in c64b00fc407393906a059285a0601214bf3065c3. ^_^

   free(compressed); can be called immediately after uncompress, before checking the return value.

   Posted 1 year ago #
6. 

   riq
   Key Master

   Thanks! fixed.
   https://github.com/cocos2d/cocos2d-iphone/commit/1c79a79f335ae4bbe6c80298540e14d66fa2401f

   Posted 1 year ago #
7. 

   knbmedia
   Member

   I confirm, it works fine now: no more leaks.
   Thanks !

   Posted 1 year ago #

RSS feed for this topic

Reply

You must log in to post.