[proposal] spriteFrame change with a FrameName

cocos2d for iPhone » Programming » cocos2d internals

[proposal] spriteFrame change with a FrameName

(5 posts) (3 voices)

Started 1 year ago by napierzaza
Latest reply from napierzaza

Tags:

No tags yet.

napierzaza
Member

Currently you can create a sprite with a "spriteFrameName" that is referenced in teh FrameCache. CCSprite automatically resolves it via the name and creates the sprite. However, you can't change the spriteFrame using a FrameName later on, you have to pull it out of the cache yourself.

+(id)spriteWithSpriteFrameName:(NSString*)spriteFrameName
{
CCSpriteFrame *frame = [[CCSpriteFrameCache sharedSpriteFrameCache] spriteFrameByName:spriteFrameName];
return [self spriteWithSpriteFrame:frame];
}

Why not have something like

-(void) setDisplayWithFrameName:(NSString*)spriteFrameName
{
CCSpriteFrame *frame = [[CCSpriteFrameCache sharedSpriteFrameCache] spriteFrameByName:spriteFrameName];
[self setDisplayFrame:frame];
}

Posted 1 year ago #
Vramin
Member

Just use the rect property.

[self setDisplayFrame [[CCSpriteFrameCache sharedSpriteFrameCache] spriteFrameByName:spriteFrameName].rect]

Posted 1 year ago #
napierzaza
Member

Why not assign it using bytes? Why was there ever a "+(id)spriteWithSpriteFrameName:(NSString*)spriteFrameName" ?? Because it's convenient for the developer to only refer to the frame by name as per the setup plist. Why depart from that convention IMMEDIATELY after initialization? Why have your multi-stage method instead of a simple method that doesn't refer to a singleton you may never ever need to communicate with otherwise?

It makes for clumpier code and code that functions in different ways depending on whether it's in initialization or after.

Posted 1 year ago #
Steve Oldmeadow
Administrator
The way I see it we can't replace this method:
```
-(void) setDisplayFrame:(CCSpriteFrame*)newFrame;
```
because it is not a good idea to force all frames to be stored in the frame cache and named.

So, is it worthwhile adding a new method just to save someone from writing one line of code? I don't think so. You could easily create a macro or add a category to CCSprite if it really bothers you.
Posted 1 year ago #
napierzaza
Member

I didn't say to replace anything.

Meh.

Posted 1 year ago #

RSS feed for this topic

Reply

You must log in to post.